823973 - nsIGConfService seems to not work as expected on ubuntu 12.04

Status: RESOLVED FIXED

(Firefox :: Shell Integration, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

on ubuntu 12.04, I am running the browser chrome tests and http://mxr.mozilla.org/mozilla-central/source/browser/components/shell/test/browser_420786.js fails on me:
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/shell/test/browser_420786.js | Wallpaper file GConf key is correct - Got file:///home/cltbld/Nightly_wallpaper.png, expected /home/cltbld/Nightly_wallpaper.png
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/shell/test/browser_420786.js | Wallpaper position GConf key is correct - Got stretched, expected wallpaper
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/shell/test/browser_420786.js | Wallpaper file GConf key is correct - Got file:///home/cltbld/Nightly_wallpaper.png, expected /home/cltbld/Nightly_wallpaper.png
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/shell/test/browser_420786.js | Wallpaper file GConf key is correct - Got file:///home/cltbld/Nightly_wallpaper.png, expected /home/cltbld/Nightly_wallpaper.png
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/shell/test/browser_420786.js | Wallpaper position GConf key is correct - Got stretched, expected centered
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/shell/test/browser_420786.js | Wallpaper file GConf key is correct - Got file:///home/cltbld/Nightly_wallpaper.png, expected /home/cltbld/Nightly_wallpaper.png
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/shell/test/browser_420786.js | Wallpaper position GConf key is correct - Got stretched, expected zoom
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/shell/test/browser_420786.js | Wallpaper file GConf key is correct - Got file:///home/cltbld/Nightly_wallpaper.png, expected /home/cltbld/Nightly_wallpaper.png
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/shell/test/browser_420786.js | Wallpaper position GConf key is correct - Got stretched, expected scaled

Can we fix this on Ubuntu or find some way to disable this test?

Comment 1

[:Gavin Sharp [email: [e-mail]]]

You may be running into bug 383348? We have build dependencies that don't cause the build to fail, but instead result in run-time errors.

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

Fixing bug 823994 didn't resolve this.  Do these need to be built on Ubuntu boxes?  Is there anyway that using a regular CI build (non nightly, non pgo) from inbound could still fail?

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

gavin, do you have any ideas why I would still be experiencing these problems after installing the proper libraries on the build machines?

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Yeah, I started looking into this a bit yesterday. Now that I actually look at the errors from comment 0 in more detail, it seems like something weirder is going on. In particular:

Got file:///home/cltbld/Nightly_wallpaper.png, expected /home/cltbld/Nightly_wallpaper.png

The test is checking the GConf /desktop/gnome/background/picture_filename key, to see whether it matches the value that the shell service should be setting here: http://hg.mozilla.org/mozilla-central/annotate/b5a78c274c09/browser/components/shell/src/nsGNOMEShellService.cpp#l476.

Is is possible that GConf is re-writing the value being set into a URI rather than a filename, but only on some systems? I don't know this code very well, CCing some people who might.

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

thanks Gavin.

Comment 6

[Chris Coulson]

The problem is that on Ubuntu 12.04, the shell service will set the wallpaper via GSettings rather than GConf, so I would expect these tests to always fail there.

We've just started running these tests on our builds too and hit the exact same issue, so we disabled this specific one for now (and browser/components/shell/test/unit/test_421977.js)

I need to update them so that they aren't GConf specific really

Comment 7

[Joel Maher ( :jmaher ) (UTC -8)]

Is there a bug to track disabling these two tests?  I don't see it on inbound, I assume it will be sometime soon on inbound/central.

Comment 8

[Chris Coulson]

There isn't a bug yet. Shall we use this one?

Comment 9

[Chris Coulson]

Attachment: Skip GConf-specific shell component tests on systems with GSettings

This is what we're using in Ubuntu to disable these 2 tests

Comment 10

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 702604 [details] [diff] [review]
Skip GConf-specific shell component tests on systems with GSettings

We should just land this and get a bug on file to improve the tests.

Comment 11

[:Gavin Sharp [email: [e-mail]]]

Thanks Chris!

Comment 12

[Joel Maher ( :jmaher ) (UTC -8)]

inbound:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ee33f3f12d2f

this will be closed when inbound merges to mozilla-central.

Comment 13

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/ee33f3f12d2f