383348 - configure should fail if you don't have gconf, gnome-vfs

Status: RESOLVED INVALID

(Firefox Build System :: General, defect)

Description

[Blake Kaplan (:mrbkap) (inactive)]

I've noticed that every time I right click in my debug build on Linux, I get:

*** e = [Exception... "Component returned failure code: 0x80570016 (NS_ERROR_XPC_GS_RETURNED_FAILURE) [nsIJSCID.getService]"  nsresult: "0x80570016 (NS_ERROR_XPC_GS_RETURNED_FAILURE)"  location: "JS frame :: chrome://browser/content/utilityOverlay.js :: getShellService :: line 285"  data: no]

Talking to gavin on IRC, he mentioned that the lack of a shell service on Linux is expected, and that we might just want to remove the dump that is filling my console with unnecessary spam.

Comment 1

[Blake Kaplan (:mrbkap) (inactive)]

This turned out to be because I didn't have gconf and friends installed. I'm rebuilding my tree now after installing them, and hopefully the console spam will go away. It would have been nice if configure had printed a warning that I was missing these. Currently, it silently just disables the affected modules.

Comment 2

[Adam Guthrie]

luser pointed out on IRC that we need to add an error message here (like is done with the other checks) instead of just silently disabling: http://mxr.mozilla.org/seamonkey/source/configure.in#4982.

Comment 3

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #2)
> luser pointed out on IRC that we need to add an error message here (like is
> done with the other checks) instead of just silently disabling:
> http://mxr.mozilla.org/seamonkey/source/configure.in#4982.

More permanent link:
http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/configure.in&rev=1.1918&root=/cvsroot#4856

Comment 5

[timeless]

Attachment: don't fail, but do complain

Comment 6

[:Gavin Sharp [email: [e-mail]]]

The build should fail, a complaint isn't enough.

Comment 7

[(not currently active) Ted Mielczarek]

Comment on attachment 318937 [details] [diff] [review]
don't fail, but do complain

No, I really think we should error. This is the only sane way to do things.

Comment 8

[Alexander Sack]

we should consider to provide a kde adaption layer for the basic desktop integration features that we deliver through gconf gnome-vfs atm.

Maybe the Ubuntu spec on this: https://wiki.ubuntu.com/Firefox3KDEIntegrationIntrepid

Comment 10

[(no longer active)]

Over in bug 506452, I didn't have the libgconf2-dev and libgnomevfs2-dev packages
installed, so the build system chose not to compile mozgnome at all instead of
warning me at configure stage.  I installed libgconf2-dev and libgnomevfs2-dev
and rebuilt, expecting that the problem would be solved, but it wasn't.  Turns
out that I needed to manually add these two lines to my .mozconfig file
manually.

mk_add_options MOZ_GCONF_CFLAGS=-I/usr/include/gconf/2
mk_add_options MOZ_GNOMEVFS_CFLAGS=-I/usr/include/gnome-vfs-2.0

I think the build system should be able to pick these directories up automatically.

Comment 11

[(not currently active) Ted Mielczarek]

It should, I think you just needed to reconfigure or possibly remove config.cache.

Comment 12

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch?

I'm not sure what to do about the MOZ_EXTENSIONS interaction.

Comment 13

[Joel Maher ( :jmaher ) (UTC -8)]

It looks like I am hitting this bug while testing on ubuntu 12.04 VMs in our EC2 cloud.

Comment 14

[Anup Kumar [:reznord]]

Hi, I would like to take on this bug. Can you please assign this to me?

Comment 15

[Kim Moir [:kmoir] ET]

Triaging, old bug, not applicable closing.