824135 - 150-character review length limit not enforced while typing

Status: RESOLVED DUPLICATE of bug 841168

(Marketplace Graveyard :: General, defect)

Description

[Brion Vibber]

Attachment: screenshot of "surprise! review too long" warning :)

Testing on unagi test phone, build 20121212.

When writing an app review in the Marketplace, there's a 150-character limit. Unfortunately this is not enforced while typing, but only at submit time.

Nor is there any character counter, so it's hard to tell whether you're over or under the limit except by actually submitting the review. Paring down a longish review can be painful!


Expected behavior: should stop being able to enter characters once we've hit 150, making it impossible to ever go beyond the limit.

Comment 1

[Wil Clouser [:clouserw]]

The character counter was specifically left off of in the designs (bug 790378).  Maria, what do you want to do here?

Comment 2

[Maureen Hanratty]

Attachment: Character limit (on desktop)

This is what I'm seeing on desktop--I'm assuming we want the same implementation on mobile rather than the screenshot the bug reporter posted (I'm having trouble logging into Marketplace on B2G so can't verify what the current design on mobile is).

From a UX point of view we should allow the user to keep typing past character limit count. This is the same implementation you will find on Twitter. I find that often on Twitter I'll allow myself to go over the character count and then edit my entry to get it under 140 characters. I think we should also support that behaviour.

One change we should make however, is to disable the "Submit" button when the character count is > 150 characters OR the text box is blank. Let me know if I need to submit a new bug to fix that.

Comment 3

[Maria Sandberg [:mushi]]

I agree with Maureen. The reason the char count was left out to begin with had to do with performance issues I think - cvan do you remember? I'd love to have it there if we solved those issues.

Comment 4

[Christopher Van Wiemeersch [:cvan]]

(In reply to Maria Sandberg [:mushi] from comment #3)
> I agree with Maureen. The reason the char count was left out to begin with
> had to do with performance issues I think - cvan do you remember? I'd love
> to have it there if we solved those issues.

Yes, it was slow to update. We can try to add it back but it was incredibly slow, especially on Firefox OS.