Closed Bug 824157 Opened 13 years ago Closed 13 years ago

tab key to move between chat windows

Categories

(Firefox Graveyard :: SocialAPI, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WORKSFORME

People

(Reporter: mixedpuppy, Unassigned)

Details

We need to add chat windows to the focus ring so you can tab through them.
OS: Mac OS X → All
Hardware: x86 → All
Target Milestone: Firefox 20 → ---
While I agree in principle, I'm worried about a future where there might be richer content in the "chat" windows (eg, WebRTC - picture a full "dialer" UI there) where the tab key might be better used by the content itself. Maybe Ctrl+Tab might work?
Looking into focus change behavior more, I realize either could be valid choices. I don't feel that behavior of content in the chat windows matters, it should be based on what the most consistent behavior for Firefox is. Tab/Shift+Tab moves focus between chrome (urlbar, status/find bar, etc) and content, and within content and in/out/within the social sidebar. For your selected tab, you can change focus into any part of the visible window. Ctrl+Tab/Ctrl+Shift+Tab changes the selected tab (moving focus between frames). If chat windows are a part of the tab ring, when you Ctrl+Tab out of the first/last chat window, you'll change the tab being viewed. If chat windows are more related to content, when you Tab out of the first/last chat window, your focus will either move into the tab content, or into the social sidebar.
Interestingly, the demo provider seems to have reasonable behaviour now. Each chat window with that provider has one text field and 2 buttons. If you open 2 chat windows and click to focus the text field in the left-most chat, pressing tab repeatedly focuses the 2 buttons in the chat, then shifts to the input field in the next chat, focuses the 2 buttons in that chat, then focus moves to the sidebar. ie, it does "the right thing" IMO, and I'm guessing that provider has no special focus handling in place. It sounds to me like the content in the chat window will impact this (eg, the content can possibly move focus between the chats as it sees fit). It's hard for me to know what the actual bug here is (ie, are we trying to prevent content from being able to switch focus in chats so the "default" focus-ring behaviour does the right thing, or something else?)
I am unable to reproduce any issue in moving around the focus ring using Tab/Shift+Tab. The chat windows are a part of the focus ring, and you are able to move back and forth between chat windows. There is a small related patch in bug 824162 that handles a part of the focus issue for chat windows, but it is more related to mouse clicks into chat windows than advancing focus with the keyboard. Closing this.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → WORKSFORME
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.