825306 - [JavaScript Error]: "Error: Syntax error, unrecognized expression: Persona authentication ."

Status: VERIFIED FIXED

(Marketplace Graveyard :: Consumer Pages, defect)

Description

[krupa raj[:krupa]]

steps to reproduce:
1. Launch marketplace app on your Firefox OS device
2. Click on Login/register
3. Enter an email address and set up password

expected behavior:
Log in is successful

observed behavior:
Logging in via persona fails with this JS error -

[JavaScript Error: "Error: Syntax error, unrecognized expression: Persona authentication ." {file: "https://marketplace-dev-cdn.allizom.org/media/js/mkt/consumer-min.js?build=5be75cd" line: 12}]

Comment 1

[Kumar McMillan [:kumar]]

Interesting. The view returns "Persona authentication failure" so it looks like the js in media/js/mkt/login.js is parsing that somehow?

Comment 2

[Christopher Van Wiemeersch [:cvan]]

login.js calls users.views.browserid_login, yeah. That's an assertion failure.

Comment 3

[Wil Clouser [:clouserw]]

This happens every time?  Is this a marketplace bug?

Comment 4

[Kumar McMillan [:kumar]]

It happens every time there is a Persona assertion error. Instead, the error should be handled more gracefully. The reason it's happening every time for krupa is because she is on an unagi phone that has not been configured to use native b2g persona. The assertion will always fail without that.

Comment 5

[Jason Smith [:jsmith]]

(In reply to Kumar McMillan [:kumar] from comment #4)
> It happens every time there is a Persona assertion error. Instead, the error
> should be handled more gracefully. The reason it's happening every time for
> krupa is because she is on an unagi phone that has not been configured to
> use native b2g persona. The assertion will always fail without that.

Lovely. Right now, we still haven't landed that pref on even though I've got checkin-needed. I'll go push back to get it landed.

Comment 6

[Jason Smith [:jsmith]]

Confirmed Kumar is correct - the current b2g shim requires the pref on.

Comment 7

[Kumar McMillan [:kumar]]

I'm not sure what's going on anymore. Perhaps this change is related https://github.com/mozilla/zamboni/commit/b65fad4f#L2R346

Comment 8

[krupa raj[:krupa]]

Now I see this JS error:


[JavaScript Error: "Error: Syntax error, unrecognized expression: Please use the verified email for this ." {file: "https://marketplace-dev-cdn.allizom.org/media/js/mkt/consumer-min.js?build=a918a1b" line: 12}]

Comment 9

[Jason Smith [:jsmith]]

FYI to those reading at home - we're officially prefed on now. Is comment 8 what we are getting when we are prefed on? Or does this bug even repo when we are prefed on?

Comment 10

[krupa raj[:krupa]]

We see this error even when pref'ed ON.

Comment 11

[Christopher Van Wiemeersch [:cvan]]

https://github.com/mozilla/zamboni/commit/499df4b
https://github.com/mozilla/zamboni/commit/0660235

You'll now see the error. But, yeah this removes the JS error.

Comment 12

[krupa raj[:krupa]]

The JS error was fixed. Thanks, cvan!