825630 - Build Thunderbird 17.0.4 using mock

Status: RESOLVED WONTFIX

(Release Engineering :: Release Requests, defect)

Comment 1

[Kim Moir [:kmoir] ET]

Attachment: patch

Comment 2

[John Hopkins (:jhopkins)]

Attachment: [buildbot-configs] follow-up patch

same as kmoir's patch + added mock_platforms

Comment 3

[[e-mail] (:bhearsum)]

Is this 100% ready to go? We're about 48 hours from go to build.

Comment 4

[[e-mail] (:bhearsum)]

It looks like this patch should land in advance of the go to build, otherwise we'll be building a release with mock before we've even tried dep/nightly builds with it...

Comment 5

[[e-mail] (:bhearsum)]

in production, forcing some builds to verify it

Comment 6

[[e-mail] (:bhearsum)]

The builds that I retriggered went fine.

Comment 7

[[e-mail] (:bhearsum)]

Comment on attachment 696774 [details] [diff] [review]
[buildbot-configs] follow-up patch

Backed out due to bug 826567.

Comment 8

[[e-mail] (:bhearsum)]

we'll try for this next time

Comment 9

[Nick Thomas [:nthomas] (UTC+12)]

Moving this to 17.0.4 because it's too close to 17.0.3 for comfort.

Comment 10

[John Hopkins (:jhopkins)]

Attachment: [buildbot-configs] updated patch

Comment 11

[[e-mail] (:bhearsum)]

I'll take care of this early in the next cycle.

Comment 12

[Massimo Gervasini [:massimo]]

Comment on attachment 711899 [details] [diff] [review]
[buildbot-configs] updated patch

Review of attachment 711899 [details] [diff] [review]:
-----------------------------------------------------------------

John it looks ok but this is my first review, so I am asking Ben for a second opinion in case I've missed something.

Comment 13

[[e-mail] (:bhearsum)]

Comment on attachment 711899 [details] [diff] [review]
[buildbot-configs] updated patch

Review of attachment 711899 [details] [diff] [review]:
-----------------------------------------------------------------

As with the patch from bug 825959, I'm pretty sure this needs l10n mozconfigs changes.

Comment 14

[John Hopkins (:jhopkins)]

Comment on attachment 711899 [details] [diff] [review]
[buildbot-configs] updated patch

The last hunk in the patch disables pymake on comm-release.  That has been dealt with in bug 841898.

Comment 15

[[e-mail] (:bhearsum)]

Attachment: enable mock w/ new gcc

Comment 16

[[e-mail] (:bhearsum)]

This is impossible to verify because we have no builders that comm-esr17+mozilla-esr17 under the comm-release branch name (bug 841903). However, the changes in bug 825959 worked fine, which is the same code branches.

Comment 17

[John Hopkins (:jhopkins)]

Comment on attachment 716549 [details] [diff] [review]
enable mock w/ new gcc

As long as mozilla2/linux*/comm-release/release/mozconfig don't need changing and build/unix/mozconfig.linux gets changed in-tree, r+.

Comment 18

[[e-mail] (:bhearsum)]

(In reply to John Hopkins (:jhopkins) from comment #17)
> Comment on attachment 716549 [details] [diff] [review]
> enable mock w/ new gcc
> 
> As long as mozilla2/linux*/comm-release/release/mozconfig don't need
> changing and build/unix/mozconfig.linux gets changed in-tree, r+.

Found in https://ftp.mozilla.org/pub/mozilla.org/thunderbird/candidates/17.0.3-candidates/build1/logs/release-comm-release-linux_build-bm34-build1-build8.txt.gz:
Executing: ['bash', '-c', 'if [ -f "mail/config/mozconfigs/linux32/release" ]; then                        echo Using in-tree mozconfig;                        cp mail/config/mozconfigs/linux32/release .mozconfig;                    else                        echo Downloading mozconfig;                        wget -O .mozconfig http://hg.mozilla.org/build/buildbot-configs/raw-file/THUNDERBIRD_17_0_3_RELEASE/mozilla2/linux/comm-release/release/mozconfig;                    fi']
Using in-tree mozconfig

Comment 19

[John Hopkins (:jhopkins)]

We also need a patch for *release-thunderbird-comm-release.py

Comment 20

[[e-mail] (:bhearsum)]

Attachment: patch the release configs too

Thanks for catching that!

Comment 21

[Rail Aliiev [:rail]]

In production

Comment 22

[[e-mail] (:bhearsum)]

Other than known intermittent test failures, things have greened up.

Comment 23

[[e-mail] (:bhearsum)]

Comment on attachment 716682 [details] [diff] [review]
patch the release configs too

This was backed out due to bustage in the chemspill 17.0.4esr release. Will be relanded once all the chemspills are done. Also need to land the mozilla-esr17 patch on the relbranches.

Comment 24

[[e-mail] (:bhearsum)]

This was backed out for chemspills. Planning to reland after they ship today.

Comment 25

[[e-mail] (:bhearsum)]

Comment on attachment 716682 [details] [diff] [review]
patch the release configs too

Relanded now that chemspills are over.

Comment 26

[[e-mail] (:bhearsum)]

This still broke shit. It's getting backed out again. See https://bugzilla.mozilla.org/show_bug.cgi?id=813613#c38 for details.

Comment 27

[[e-mail] (:bhearsum)]

Given all of the issues we've had with trying to do this, I don't think it's worthwhile investing any more time into. We'll just have to prop up the old build platform until esr17 dies.