841898 - disable pymake for comm-release

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[[e-mail] (:bhearsum)]

Because it's based on Gecko 17 still.

Comment 1

[[e-mail] (:bhearsum)]

Attachment: disable pymake

It don't work here.

Comment 2

[[e-mail] (:bhearsum)]

There's an open question around how we didn't catch this on TBPL. Are we not building the same thing that we're releasing on the Thunderbird-Release tree?

Comment 3

[Hal Wine [:hwine] (leaving Jan 17, ping on slack if needed)]

Comment on attachment 714568 [details] [diff] [review]
disable pymake

Review of attachment 714568 [details] [diff] [review]:
-----------------------------------------------------------------

yeah, no pymake

Comment 4

[[e-mail] (:bhearsum)]

Attachment: shorten comm-release directories

We need to do this too, otherwise win32 builds will start failing.

Comment 5

[Justin Wood (:Callek)]

Comment on attachment 714580 [details] [diff] [review]
shorten comm-release directories

Review of attachment 714580 [details] [diff] [review]:
-----------------------------------------------------------------

excuse me while I go take a shower after how dirty this feels....

Comment 6

[[e-mail] (:bhearsum)]

Leaving open so we can do something about the fact that pymake is off for dep/nightly when it shouldn't be.

Comment 7

[Mark Banner (:standard8)]

(In reply to Ben Hearsum [:bhearsum] from comment #2)
> There's an open question around how we didn't catch this on TBPL. Are we not
> building the same thing that we're releasing on the Thunderbird-Release tree?

Yes, we're not building the same on there at the moment as it picks up the latest gecko. However this has been ok from the development perspective as the code is identical on comm-esr17 to what we actually ship.

And tbh I thought Jhopkins included that in a patch post the staging builds.

Comment 8

[[e-mail] (:bhearsum)]

We should back this out the pymake disabling after bug 841903 is fixed.

Comment 9

[Rail Aliiev [:rail]]

in production

Comment 10

[John Hopkins (:jhopkins)]

(In reply to Mark Banner (:standard8) from comment #7)
> And tbh I thought Jhopkins included that in a patch post the staging builds.

The last hunk in this patch disables pymake on comm-release:
 
 https://bugzilla.mozilla.org/attachment.cgi?id=711899&action=edit

Unfortunately, it should have been attached to bug 815302 instead of bug 825630.

Comment 11

[[e-mail] (:bhearsum)]

(In reply to Ben Hearsum [:bhearsum] from comment #8)
> We should back this out the pymake disabling after bug 841903 is fixed.

Turns out we don't want to do this because bug 841903 ended up making comm-release point at esr17 repos.