Closed Bug 827493 Opened 7 years ago Closed 7 years ago

Marionette installation breaks with recent changes to mozbase/mozhttpd

Categories

(Testing :: Marionette, defect)

defect
Not set

Tracking

(b2g18 fixed, b2g18-v1.0.0 wontfix, b2g18-v1.0.1 fixed)

RESOLVED FIXED
mozilla21
Tracking Status
b2g18 --- fixed
b2g18-v1.0.0 --- wontfix
b2g18-v1.0.1 --- fixed

People

(Reporter: ffledgling, Assigned: ffledgling)

References

Details

Attachments

(1 file, 1 obsolete file)

runtests.py under marionette uses the iface method from mozhttpd, this however was removed in recent updates to mozhttpd and was moved to the moznetwork module and thus breaks the marionette installation using setup.py.
Assignee: nobody → ffledgling
Depends on: 827508
Adds moznetwork dependency to marionette setup, removes useage of old iface method from mozhttpd.
Attachment #698872 - Flags: review?(jhammel)
Comment on attachment 698872 [details] [diff] [review]
Adds moznetwork dependency to marionette setup, removes useage of old iface method

This looks good, except the setup.py will also need its version bumped.  In general, if a setup.py is substantively changed, its version should be bumped
Attachment #698872 - Flags: review?(jhammel) → review-
Depends on: 827531
We'll also need to wait for bug 827508 or somehow otherwise fix the disparity between mozharness and m-c
(and bug 827531)
Adds moznetwork dependency to marionette setup, removes useage of old iface method, Also adds a minor version bump to Marionette.
Attachment #698872 - Attachment is obsolete: true
Attachment #698889 - Flags: review?(jhammel)
OS: Linux → All
Hardware: x86 → All
Comment on attachment 698889 [details] [diff] [review]
Same as previous patch with minor version bump

lgtm! thanks
Attachment #698889 - Flags: review?(jhammel) → review+
So, now that bug 827531 is fixed, I can finally circle back to this bug!  Before we can land this, we'll need to upload moznetwork to puppetagain, and then update this patch with the current version number.  We'll probably want to mirror moznetwork to m-c as well.  I'll file the appropriate bugs.
Depends on: 840668
Updated version number in patch and pushed to try: https://tbpl.mozilla.org/?tree=Try&rev=c0682e948b75
(In reply to Jonathan Griffin (:jgriffin) from comment #8)
> Updated version number in patch and pushed to try:
> https://tbpl.mozilla.org/?tree=Try&rev=c0682e948b75

15:08:24     INFO -  starting httpd
15:08:24    ERROR -  Traceback (most recent call last):
15:08:24     INFO -    File "/builds/slave/talos-slave/test/build/tests/marionette/marionette/runtests.py", line 703, in <module>
15:08:24     INFO -      cli()
15:08:24     INFO -    File "/builds/slave/talos-slave/test/build/tests/marionette/marionette/runtests.py", line 698, in cli
15:08:24     INFO -      runner = startTestRunner(runner_class, options, tests)
15:08:24     INFO -    File "/builds/slave/talos-slave/test/build/tests/marionette/marionette/runtests.py", line 693, in startTestRunner
15:08:24     INFO -      runner.run_tests(tests, testtype=options.type)
15:08:24     INFO -    File "/builds/slave/talos-slave/test/build/tests/marionette/marionette/runtests.py", line 352, in run_tests
15:08:24     INFO -      self.run_test(test, testtype)
15:08:24     INFO -    File "/builds/slave/talos-slave/test/build/tests/marionette/marionette/runtests.py", line 383, in run_test
15:08:24     INFO -      self.start_httpd()
15:08:24     INFO -    File "/builds/slave/talos-slave/test/build/tests/marionette/marionette/runtests.py", line 254, in start_httpd
15:08:24     INFO -      host = moznetwork.get_ip()
15:08:24     INFO -  AttributeError: 'module' object has no attribute 'get_ip'
15:08:24    ERROR - Return code: 1

We need to versionbump moznetwork and release to pypi.
Depends on: 840789
Depends on: 840796
Updated moznetwork version number in patch and pushed to try again: https://tbpl.mozilla.org/?tree=Try&rev=bf127b74cfa1
19:20:27    ERROR -  Traceback (most recent call last):
19:20:27     INFO -    File "/Users/cltbld/talos-slave/test/build/tests/marionette/marionette/runtests.py", line 703, in <module>
19:20:27     INFO -      cli()
19:20:27     INFO -    File "/Users/cltbld/talos-slave/test/build/tests/marionette/marionette/runtests.py", line 698, in cli
19:20:27     INFO -      runner = startTestRunner(runner_class, options, tests)
19:20:27     INFO -    File "/Users/cltbld/talos-slave/test/build/tests/marionette/marionette/runtests.py", line 693, in startTestRunner
19:20:27     INFO -      runner.run_tests(tests, testtype=options.type)
19:20:27     INFO -    File "/Users/cltbld/talos-slave/test/build/tests/marionette/marionette/runtests.py", line 352, in run_tests
19:20:27     INFO -      self.run_test(test, testtype)
19:20:27     INFO -    File "/Users/cltbld/talos-slave/test/build/tests/marionette/marionette/runtests.py", line 383, in run_test
19:20:27     INFO -      self.start_httpd()
19:20:27     INFO -    File "/Users/cltbld/talos-slave/test/build/tests/marionette/marionette/runtests.py", line 264, in start_httpd
19:20:27     INFO -      self.httpd.start()
19:20:27     INFO -    File "/Users/cltbld/talos-slave/test/build/venv/lib/python2.6/site-packages/mozhttpd/mozhttpd.py", line 223, in start
19:20:27     INFO -      self.httpd = EasyServer((self.host, self.port), self.handler_class)
19:20:27     INFO -    File "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/SocketServer.py", line 400, in __init__
19:20:27     INFO -      self.server_bind()
19:20:27     INFO -    File "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/BaseHTTPServer.py", line 108, in server_bind
19:20:27     INFO -      SocketServer.TCPServer.server_bind(self)
19:20:27     INFO -    File "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/SocketServer.py", line 411, in server_bind
19:20:27     INFO -      self.socket.bind(self.server_address)
19:20:27     INFO -    File "<string>", line 1, in bind
19:20:27    ERROR -  TypeError: coercing to Unicode: need string or buffer, NoneType found
19:20:27    ERROR - Return code: 1

This seems like moznetwork.get_ip() is returning None on the slaves, Mac at least.
Depends on: 841085
Depends on: 841091
Who knew this would be so complicated? ;)
Depends on: 841128
Updated version number in patch and pushed to try again: https://tbpl.mozilla.org/?tree=Try&rev=edf911851126

Third time's the charm!
(In reply to Jonathan Griffin (:jgriffin) from comment #13)
> Updated version number in patch and pushed to try again:
> https://tbpl.mozilla.org/?tree=Try&rev=edf911851126
> 
> Third time's the charm!

It's green!  Time to land.
https://hg.mozilla.org/mozilla-central/rev/33247c135813
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in before you can comment on or make changes to this bug.