827804 - [Lockscreen UX] Entering passcode. "Emergency call" and "Cancel" buttons should be vertically centered

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect)

Description

[Victoria Gerchinhoren [:vicky]]

Attachment: Correct alignment of text buttons in keypad

Both texts should be vertically aligned in the middle and be 6,5 pt. See attachment.

Comment 1

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: After patch

Comment 2

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: patch for UX branch

Comment 3

[Sam Joch [:samjoch]]

Comment on attachment 710854 [details]
patch for UX branch

Pavel, seems that we lost the white color in the two buttons (https://bug827804.bugzilla.mozilla.org/attachment.cgi?id=710852) also i don't understand why you use a :after for a vertical alignment ?

Comment 4

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

I update the PR(fixed the white color) 
:after - it was used for easy vertical centering of text, regardless of its size(multi line text)

Comment 5

[Sam Joch [:samjoch]]

Landed in uxbranch: https://github.com/gordonbrander/gaia/commit/1ad083d8e302b47f7fa09d8e5cc43072efd10d59

Comment 6

[Sam Joch [:samjoch]]

https://github.com/mozilla-b2g/gaia/commit/25d9e53380db967d76223c5f1e1940ed907ed447

Comment 7

[Stephany Wilkes]

Comment on attachment 710854 [details]
patch for UX branch

Hi Pavel,

Checking in on this (per Jaime's email) as we strive to wrap up all Yedo and VxD changes by April 5th.

Is this ready to raise to approval? with user value and risk in the comments? Let me know. Thanks!

Comment 8

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Yes, this one is ready :)

Comment 9

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Comment on attachment 710854 [details]
patch for UX branch

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: 
Testing completed: 
Risk to taking this patch (and alternatives if risky):
String or UUID changes made by this patch:

Comment 10

[Sam Joch [:samjoch]]

Master commit hash is 2d65422

Comment 11

[Lukas Blakk [:lsblakk] use ?needinfo]

Can someone please fill out the form in comment 9, esp with regards to risk.

Comment 12

[Alex Keybl [:akeybl]]

Comment on attachment 710854 [details]
patch for UX branch

Please renominate with a risk evaluation.

Comment 13

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Pavel, can you fill in the information in comment 9 please?

Comment 14

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Also to note, I can't verify this because of bug 855107.

Comment 16

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

(In reply to Naoki Hirata :nhirata (please use needinfo instead of cc) from comment #14)
> Also to note, I can't verify this because of bug 855107.

This is fixed in Bug 847552 can you check it again?

Comment 17

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

verified the alignment, the problem is with l10n items: bug 858754.  Also filed bug 858716

Comment 18

[Germán Toro del Valle (:gtorodelvalle)]

Comment on attachment 710854 [details]
patch for UX branch

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Incorrect vertical alignment of button text
User impact if declined: Bad experience
Testing completed: Tested in the device (Unagi)
Risk to taking this patch (and alternatives if risky): Low risk (it only includes classes in the HTML code and CSS updates)
String or UUID changes made by this patch: None

Comment 19

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 710854 [details]
patch for UX branch

approving for uplift since bug 858754 does not, to our knowledge, look to affect shipping locales for v1.1

Comment 20

[John Ford [:jhford] CET/CEST Berlin Time]

I was not able to uplift this bug to v1-train.  If this bug has dependencies which are not marked in this bug, please comment on this bug.  If this bug depends on patches that aren't approved for v1-train, we need to re-evaluate the approval.  Otherwise, if this is just a merge conflict, you might be able to resolve it with:

  git checkout v1-train
  git cherry-pick -x -m1 25d9e53380db967d76223c5f1e1940ed907ed447
  <RESOLVE MERGE CONFLICTS>
  git commit

Comment 21

[Eric Pang [:epang] UX]

Sam/Pavel, can you please looks into this? Thanks :)

Comment 22

[Sam Joch [:samjoch]]

Sorry wrong hash, uplifted from 2d654221796a99d2b6e02d56605a553fe053f965

v1-train: 7c55debc55174791399a182cca216cd1d038d538

Comment 23

[Al Tsai [:atsai]]

Verified w/ Unagi
on v1-train
Gaia:  0ddb515f15cbc6b74fc2742b7599d6ae74c6413f
Gecko: 5d2cf5184ac6f99758668da9e6a5b1a34f9fefc8