827892 - Each panda should know to which mobile imaging server to talk to

Status: RESOLVED FIXED

(Infrastructure & Operations Graveyard :: CIDuty, task, P3)

Description

[Armen [:armenzg]]

Our configs have hard-coded the address of one of the 10 mobile imaging servers:
"mozpool_api_url": "http://mobile-imaging-001.p1.releng.scl1.mozilla.com"

I should fix this so we can use the remaining racks that have been allocated for b2g work.

Comment 1

[Armen [:armenzg]]

Attachment: remove hardcoded value

What do you think?

Comment 2

[Aki Sasaki (not active)]

Comment on attachment 699457 [details] [diff] [review]
remove hardcoded value

>-    def query_mozpool_handler(self):
>+    def determine_mozpool_host(self, device):
>+        fqdn = socket.getfqdn(device)
>+        vlan_match = re.search("%s\.p([0-9]+)\.releng.*" % device, fqdn)
>+        if vlan_match:
>+            vlan = int(vlan_match.group(1))
>+        else:
>+            raise MozpoolException("This panda board does not have an associated BMM.")
>+        return "http://mobile-imaging-%03i.p%i.releng.scl1.mozilla.com" % (vlan, vlan)

Cool, I didn't realize this mapped that way.
If you wanted to be super cool you could make "http://mobile-imaging-%03i.p%i.releng.scl1.mozilla.com" part of the config rather than hardcoding here, but this works for now.

>+    def query_mozpool_handler(self, device=None, mozpool_api_url=None):
>         if not self.mozpool_handler:
>-            if 'mozpool_api_url' not in self.config:
>-                self.fatal("Can't create mozpool handler without mozpool_api_url set!")
>+            assert device != None or mozpool_api_url != None

This assert is probably ok, though I'd tend to prefer a human-readable |self.fatal("query_mozpool_handler() requires either a device or mozpool_api_url!")|
That may just be me.

Comment 3

[Armen [:armenzg]]

Attachment: remove hardcoded value

I've taken aki's suggestions.

Comment 4

[John Hopkins (:jhopkins)]

Comment on attachment 699457 [details] [diff] [review]
remove hardcoded value

Patch is failing unit tests.  I will attach the unit test log.

Comment 5

[John Hopkins (:jhopkins)]

Attachment: unit test log

Comment 6

[Armen [:armenzg]]

Attachment: remove mozpool-api-url hardcoded value

This passes the test.
I will file a bug for the remaining tests.

Comment 7

[John Hopkins (:jhopkins)]

Comment on attachment 700573 [details] [diff] [review]
remove mozpool-api-url hardcoded value

r+ with one change - move just the assertion of mozpool_api_url to _after_ the |self.mozpool_api_url=| line, as discussed in IRC:

+    def query_mozpool_handler(self, device=None, mozpool_api_url=None):
         if not self.mozpool_handler:
-            if 'mozpool_api_url' not in self.config:
-                self.fatal("Can't create mozpool handler without mozpool_api_url set!")
+            assert device != None or mozpool_api_url != None, \
+                "query_mozpool_handler() requires either a device or mozpool_api_url!"
+            self.mozpool_api_url = self.determine_mozpool_host(device) if device else mozpool_api_url

Comment 8

[Armen [:armenzg]]

Comment on attachment 700573 [details] [diff] [review]
remove mozpool-api-url hardcoded value

ff4a8964387d