Closed Bug 828892 Opened 7 years ago Closed 7 years ago
Favicons are missing for the default bookmarked pages besides about: ones
Firefox 21.0a1 (2013-01-09) Device: Galaxy S2 OS: Android 4.0.3 Steps to reproduce: 1. Open Firefox for Android using a clean profile 2. Go to Awesomescreen > Top Sites and Bookmarks tabs Expected result: All favicons are displayed for the default bookmarked pages. Actual results: Just the favicons for the about: pages are displayed.
Can we get a regression window for this issue.
We wouldn't block the release on this, but it is worth tracking.
Good build:Nightly 20.0a1 (2012-12-15) http://hg.mozilla.org/mozilla-central/rev/5ea1c76e4bb3 Bad build:Nightly 20.0a1 (2012-12-16) http://hg.mozilla.org/mozilla-central/rev/c8a1314aa449 Possible range: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=5ea1c76e4bb3&tochange=c8a1314aa449 Could be a regression from bug #715258 ?
Looking for a tighter regression range. Unfortunately we mozilla-inbound only has builds from the Dec-17 and later. Needs manual bisection.
MFinkle any idea from the tighter regression range? Not a lot jumping out at me.
bug 715258 is the culript
This patch adds back two lines that were removed bug bug 715258. Tested with a fresh profile and I see favicons now.
Assignee: nobody → mark.finkle
Attachment #708456 - Flags: review?(bnicholson)
Attachment #708456 - Flags: review?(bnicholson) → review+
Comment on attachment 708456 [details] [diff] [review] patch [Approval Request Comment] Bug caused by (feature/regressing bug #): bug 715258 User impact if declined: missing favicons for some default bookmarks Testing completed (on m-c, etc.): Risk to taking this patch (and alternatives if risky): low risk. the images are still in the source repo. the patch just adds them to the APK. String or UUID changes made by this patch: none Looks like bug 715258 is on Fx20, so I am not requesting Fx19 uplift.
Attachment #708456 - Flags: approval-mozilla-aurora?
Attachment #708456 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Target Milestone: Firefox 21 → ---
Verified using Asus Transformer TF101 (Android 4.0.3) on: Nightly 21.0a1(2013-02-07) and Aurora 20.0a2(2013-02-07).
You need to log in before you can comment on or make changes to this bug.