If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Trusted UI for identity needs a localized title

VERIFIED FIXED in B2G C4 (2jan on)

Status

Firefox OS
Gaia::System
VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: jedp, Assigned: jedp)

Tracking

({late-l10n})

unspecified
B2G C4 (2jan on)
late-l10n
Dependency tree / graph

Firefox Tracking Flags

(blocking-b2g:tef+, b2g18 fixed, b2g18-v1.0.0 fixed)

Details

(Whiteboard: interaction)

Attachments

(1 attachment)

The Trusted UI should display a localized "Sign In" title for Persona.

We can add the string 'persona-signin' to locale files, with the persona- prefix there to prevent overlap with other applications that have a signin concept (like the system app).
Hm, I'm confused. 

I believe we can only have one title for the entire flow where Persona sign in might be a piece or all of it (paid vs free app). Per bug 813811 that title will be the name of the initiating app, so there shouldn't be any need to localize?
Created attachment 700759 [details]
gaia PR 7533

Axel, I'm new to L10n - am I doing this correctly? And will locales not yet supported all default back to this en-US file?  Thank you!
Attachment #700759 - Flags: feedback?(l10n)
(In reply to Maria Sandberg [:mushi] from comment #1)
> Hm, I'm confused. 
> 
> I believe we can only have one title for the entire flow where Persona sign
> in might be a piece or all of it (paid vs free app). Per bug 813811 that
> title will be the name of the initiating app, so there shouldn't be any need
> to localize?

Hi, Maria.  Because the persona sign-in is a completely separate component from marketplace.  The Trusty UI needs a title when identity is requested by a website or app using persona.

The title for marketplace can be the name of the initiating app.  But even if it wanted to, there's no way for the marketplace app to tell the identity app what title to give itself.  They are two separate layers, one on top of the other, in the Trusty UI stack.
Sorry, I see we're also having this discussion on the parent bug.  Let's keep the discussion about the interaction of Marketplace and Identity over there (bug 813811).
Comment on attachment 700759 [details]
gaia PR 7533

Kaze I know is at the work week and can probably look at this quickly and he knows how to review l10n patches.
Attachment #700759 - Flags: feedback?(kaze)
Jason, thank you

Kaze, thank you in advance for taking a look!
This looks OK, I just have a small doubt regarding the initialization process — see my comment on the PR.

Comment 8

5 years ago
Comment on attachment 700759 [details]
gaia PR 7533

With Kaze's comment, I guess this is OK.

The string is a dialog title, right? Then CamelCase is OK, otherwise it should probably be just "Sign in" in sentence case, according to https://etherpad.mozilla.org/gaia-copy-guidelines
Attachment #700759 - Flags: feedback?(l10n) → feedback+
Attachment #700759 - Flags: feedback?(kaze) → feedback+
(In reply to Fabien Cazenave [:kaze] from comment #7)
> This looks OK, I just have a small doubt regarding the initialization
> process — see my comment on the PR.

Thank you for that comment - I have updated the PR
(In reply to Axel Hecht [:Pike] from comment #8)
> Comment on attachment 700759 [details]
> gaia PR 7533
> 
> With Kaze's comment, I guess this is OK.

Thank you.  I've updated the PR to init as Kaze recommends.

> The string is a dialog title, right? Then CamelCase is OK, otherwise it
> should probably be just "Sign in" in sentence case, according to
> https://etherpad.mozilla.org/gaia-copy-guidelines

Yes, this is a window title; the camel-case is deliberate
Comment on attachment 700759 [details]
gaia PR 7533

Thanks for your feedback, Axel and Kaze!
Attachment #700759 - Flags: review?(l10n)

Comment 12

5 years ago
Comment on attachment 700759 [details]
gaia PR 7533

Forwarding the review request to kaze, I'm not a reviewer in the gaia module.
Attachment #700759 - Flags: review?(l10n) → review?(kaze)
Attachment #700759 - Flags: review?(kaze) → review+
Comment on attachment 700759 [details]
gaia PR 7533

l10n again, we need this

[Approval Request Comment]
Bug caused by (feature/regressing bug #): ?
User impact if declined: untranslated title
Testing completed: manual
Risk to taking this patch (and alternatives if risky): none
Attachment #700759 - Flags: approval-gaia-master?(21)

Comment 14

5 years ago
This is bb- because it started off as a clone of bug 813811 ? I only realize that now.
(In reply to Axel Hecht [:Pike] from comment #14)
> This is bb- because it started off as a clone of bug 813811 ? I only realize
> that now.

I think it was originally basecamp- because although the title shown was technically incorrect, the user would understand the intention of what the dialog was showing.

However - re-reading this bug, I now get the sense that the title shown isn't getting translated, so that actually makes this blocker worthy.

Can someone confirm that the existing "IdentityFlow" and "PaymentFlow" wording isn't getting translated to pt-BR? If it isn't, I'll nom both associated bugs.

Updated

5 years ago
No longer blocks: 813811

Updated

5 years ago
Blocks: 794552, 801561
Actually I just read the patch - yeah this isn't getting translated. This definitely should have been nomed to block originally with that rationale.
blocking-b2g: --- → tef?

Updated

5 years ago
Keywords: polish
Whiteboard: interaction, UX-P? → interaction

Updated

5 years ago
blocking-basecamp: - → ---
I've modified bug 813811 to reflect the fact that the payment title also isn't getting translated, so that's been nomed as well.
blocking-b2g: tef? → tef+
Attachment #700759 - Flags: approval-gaia-master?(21) → approval-gaia-master+
https://github.com/mozilla-b2g/gaia/commit/f95e3ce220ad4b1e09076a26817ab62ea4bff106
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED

Updated

5 years ago
Keywords: verifyme
QA Contact: jsmith

Updated

5 years ago
Duplicate of this bug: 830576

Updated

5 years ago
status-b2g18: --- → fixed
Target Milestone: --- → B2G C4 (2jan on)

Comment 20

5 years ago
It seems that identity tests are broken https://bugzilla.mozilla.org/show_bug.cgi?id=813811#c45 :\
I've filed Bug 831264 as a follow-up bug to fix them.
Depends on: 831264
Verified in English and pt-BR - I'm seeing a translated title and Sign In in English.
Status: RESOLVED → VERIFIED
Keywords: verifyme
Landed on mozilla-b2g18/gaia master prior to the 1/25 branching to mozilla-b2g18_v1_0_0/v1.0.0, updating status-b2g-v1.0.0 to fixed.
status-b2g18-v1.0.0: --- → fixed
tracking-b2g18: ? → ---
You need to log in before you can comment on or make changes to this bug.