813811 - Trusted UI for payments needs a localized title

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

Attachment: Screenshot of "IdentityFlow" title in Trusty UI

Do we have UX guidance for what the title of the Trusty UI should be for Identity?

Currently, the window simply says "IdentityFlow", which is probably not desirable.

Comment 1

[Jason Smith [:jsmith]]

Similar issue happens with payments - we use the title "PaymentFlow." Won't block on this, but this is definite polish. Josh?

Comment 2

[Josh Carpenter [:jcarpenter]]

Alberto, my original intent was to unify the entire payment process under a single title. eg: "Purchase AngryDucks". Individual steps within that process would not be able to modify the TrustedUI title. Is that feasible? 

Maria/Maureen, does that conform with your thinking?

Comment 3

[alberto.pastor]

(In reply to Josh Carpenter [:jcarpenter] from comment #2)
> Alberto, my original intent was to unify the entire payment process under a
> single title. eg: "Purchase AngryDucks". Individual steps within that
> process would not be able to modify the TrustedUI title. Is that feasible? 
> 
> Maria/Maureen, does that conform with your thinking?

The TrustedUIManager allows you to pass a "name" attribute, which is set in the title. As long as the TrustedUI opener send that parameter, the TrustedUI will show it.

In the example of "Purchase AngryDucks", the marketplace should pass that name to the Payment api, and the Payment open the trustedUI with it. Not sure if that's possible right now. Fernando?

Comment 4

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

(In reply to Josh Carpenter [:jcarpenter] from comment #2)
> Alberto, my original intent was to unify the entire payment process under a
> single title. eg: "Purchase AngryDucks". Individual steps within that
> process would not be able to modify the TrustedUI title. Is that feasible? 
> 
> Maria/Maureen, does that conform with your thinking?

In the case of Identity, we'll still need guidance for logging into (non-marketplace sites) in general.

Also, fwiw, there's not much real estate on that title bar.  "Purchase AngryDucks" would just about fit, but not "Purchase AngryDucks Pond Life Upgrade".

Comment 5

[Jason Smith [:jsmith]]

(In reply to Josh Carpenter [:jcarpenter] from comment #2)
> Alberto, my original intent was to unify the entire payment process under a
> single title. eg: "Purchase AngryDucks". Individual steps within that
> process would not be able to modify the TrustedUI title. Is that feasible? 

So exactly why shouldn't we let the title be controlled by the trusted content? In other words, why can't the trusted content title be set to what's in <title></title> for example?

Right now we do the following for the title:

mozPay = PaymentFlow
id = IdentityFlow

Comment 6

[alberto.pastor]

(In reply to Jason Smith [:jsmith] from comment #5)
> (In reply to Josh Carpenter [:jcarpenter] from comment #2)
> > Alberto, my original intent was to unify the entire payment process under a
> > single title. eg: "Purchase AngryDucks". Individual steps within that
> > process would not be able to modify the TrustedUI title. Is that feasible? 
> 
> So exactly why shouldn't we let the title be controlled by the trusted
> content? In other words, why can't the trusted content title be set to
> what's in <title></title> for example?
> 
> Right now we do the following for the title:
> 
> mozPay = PaymentFlow
> id = IdentityFlow

The trusted content is only an iFrame inside the TrustedUI. That content can control his own title, but not the trustedUI one, so it must be set when opening it.

Comment 7

[Josh Carpenter [:jcarpenter]]

(In reply to Jed Parsons [:jparsons] from comment #4)
> Also, fwiw, there's not much real estate on that title bar.  "Purchase
> AngryDucks" would just about fit, but not "Purchase AngryDucks Pond Life
> Upgrade".

For overflows we'll should use a css ellipsis. Enough of the app's lettering will remain visible to make sense of the meaning.

(In reply to Jason Smith [:jsmith] from comment #5)
> So exactly why shouldn't we let the title be controlled by the trusted
> content? In other words, why can't the trusted content title be set to
> what's in <title></title> for example?
 
Usability and user confidence. You and I might understand the difference between "Payment" vs "Identity" flows, but the user thinks of it as one task (get new app) and we would like to try to unify the steps as much as possible. We're open to tweaking it in the future, but this approach is preferred for v1, and more feasible (per Alberto's comment below)

Comment 8

[Fernando Jiménez Moreno [:ferjm]]

(In reply to Alberto Pastor from comment #3)
> (In reply to Josh Carpenter [:jcarpenter] from comment #2)
> > Alberto, my original intent was to unify the entire payment process under a
> > single title. eg: "Purchase AngryDucks". Individual steps within that
> > process would not be able to modify the TrustedUI title. Is that feasible? 
> > 
> > Maria/Maureen, does that conform with your thinking?
> 
> The TrustedUIManager allows you to pass a "name" attribute, which is set in
> the title. As long as the TrustedUI opener send that parameter, the
> TrustedUI will show it.
> 
> In the example of "Purchase AngryDucks", the marketplace should pass that
> name to the Payment api, and the Payment open the trustedUI with it. Not
> sure if that's possible right now. Fernando?

I am afraid that this is not possible anymore since Bug 800511 :\. We don't expose the product name to the DOM anymore.

Comment 9

[Josh Carpenter [:jcarpenter]]

Maria is currently PTO. 

Fernando and Alberto, can you clarify? We need a way to set the name of the Trusted UI window. Leaving it blank is not acceptable. 

As a last resort we can give it a hard coded generic name like "Purchase", but that sucks.

Comment 10

[Fernando Jiménez Moreno [:ferjm]]

Currently, there is no way to get the product name being purchased in Gaia unless we revert some of the changes introduced by Bug 800511. The only information that Gaia receives from the platform is the payment provider name (in this case, the Marketplace). So I am afraid that we might need to go for the hard coded generic name option.

Comment 11

[Josh Carpenter [:jcarpenter]]

(In reply to Fernando Jiménez Moreno [:ferjm] from comment #10)
> Currently, there is no way to get the product name being purchased in Gaia
> unless we revert some of the changes introduced by Bug 800511. 

What's the degree of work involved? 

If we hard code, the problem is finding a string that is meaningful. Here are some options that I see:

* "Purchase" — Not all invocations of Trusted UI will involve paid content.
* "Download" — Too ambiguous and inaccurate, IMO. 
* [Name of invoking app] — eg: "Marketplace". Not bad, but is still ambiguous. Can we get this information, Alberto?

Maria, would you mind commenting here when you're back from PTO?

Comment 12

[Fernando Jiménez Moreno [:ferjm]]

(In reply to Josh Carpenter [:jcarpenter] from comment #11)
> (In reply to Fernando Jiménez Moreno [:ferjm] from comment #10)
> > Currently, there is no way to get the product name being purchased in Gaia
> > unless we revert some of the changes introduced by Bug 800511. 
> 
> What's the degree of work involved? 

The work required is not too much, but it requires modifications in the API, which is kind of risky at this point.

Comment 13

[Josh Carpenter [:jcarpenter]]

Okay, thanks Fernando. I will discuss with Maria (who is back from vacation today) and one of us will follow up asap.

Comment 14

[Maria Sandberg [:mushi]]

I'm back :)

As Jed pointed out there are other use cases we need to consider, for example the user could choose to reset their password or pin code while still in the trusted UI. Taking those into account it makes it even more difficult to come up with an "action" title that makes sense - purchase/download/install or even the name of the app won't be great. 

We could use "Marketplace" for all windows but that might be confusing when making an in-app purchase? Josh, let's discuss offline. I sense some back and forth coming up :)

Comment 15

[Jason Smith [:jsmith]]

Already blocking the trusted UI bug for tracking.

Comment 16

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

There's a localization component to this, isn't there?

Is it enough to say "Marketplace" or "Sign In", without translating for locale?

(Adding :skinny)

Comment 17

[Axel Hecht [:Pike]]

"Sign In" wouldn't work without translating it, but I think we have a slushy policy against translating Marketplace.

Requesting basecamp to make sure this is tracked if it's late-l10n or not. We should un-flag it if it's bb-.

Comment 18

[Joe Cheng [:jcheng] (please needinfo)]

Triage: BB-, tracking-b2g18+

Comment 19

[Maria Sandberg [:mushi]]

I believe we decided to use the name of the initiating application as the window title. For example:

1. buying an app from the Marketplace - title "Firefox Marketplace"
2. in-app payment from SoundCloud - title "SoundCloud"

Josh, can you confirm?

Comment 20

[Jason Smith [:jsmith]]

Honestly, I wouldn't track this. The title though not intentional off of original UX design is minor polish. There's other bugs worth fighting for to spend our time on this unless we start seeing users complaining.

Comment 21

[Crystal Beasley [:skinny, :crystal]]

:mushi & :jcarpenter

I'm fine with either
a) the Identity flow continuing to use the same title as the complete task flow.
b) the Identity flow having "Sign In" as the title.

You guys have better context, so I'll leave it up to you.


:jsmith

I'm curious, why do you find this to be a minor bug?

Comment 22

[Jason Smith [:jsmith]]

(In reply to Crystal Beasley [:skinny, :crystal] from comment #21)
> :mushi & :jcarpenter
> 
> I'm fine with either
> a) the Identity flow continuing to use the same title as the complete task
> flow.
> b) the Identity flow having "Sign In" as the title.
> 
> You guys have better context, so I'll leave it up to you.
> 
> 
> :jsmith
> 
> I'm curious, why do you find this to be a minor bug?

Probably because the user still has knowledge that they are within a "payment" workflow vs. a "identity" workflow. The string may be incorrect, but in the grand scheme of the bugs out there, this one feels minor as the user impact is minimal. There's far worse UX bugs (I know Josh knows about) that I'd be willing to fight for that really impact a user's workflow, but I don't feel this one hits that category. I'll put it up for UX prioritization though to see what Josh thinks.

Comment 23

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

Created Bug 829355 to track the Persona title

Comment 24

[Maria Sandberg [:mushi]]

(In reply to Crystal Beasley [:skinny, :crystal] from comment #21)
> :mushi & :jcarpenter
> 
> I'm fine with either
> a) the Identity flow continuing to use the same title as the complete task
> flow.
> b) the Identity flow having "Sign In" as the title.

I think we only have the option of a) which is why we are going with the initiating application name as the window title. We also believe having one title will help pull together the flow.

Comment 25

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

(In reply to Maria Sandberg [:mushi] from comment #24)
> (In reply to Crystal Beasley [:skinny, :crystal] from comment #21)
> > :mushi & :jcarpenter
> > 
> > I'm fine with either
> > a) the Identity flow continuing to use the same title as the complete task
> > flow.
> > b) the Identity flow having "Sign In" as the title.
> 
> I think we only have the option of a) which is why we are going with the
> initiating application name as the window title. We also believe having one
> title will help pull together the flow.

The problem with this is that Identity is a completely separate component from Marketplace.  Marketplace uses it, but so will any site or app that has a persona sign in.  So we need a title for those sites.  (Hence my opening of a separate bug to keep Identity distinct.)

Also, even if Marketplace wanted to set the title on the Trusty UI for Identity, there is no way for it to do that right now.  We could make it so that the initiating app sets the title on the entire Trusty UI stack.  That way Marketplace would get there first, set the title, and Identity would inherit it.

That would also allow Identity to set its own title in all the cases where it's not launched by marketplace.

Comment 26

[Lucas Adamski [:ladamski]]

Lets just decide on something very soon as the window to land anything is rapidly closing. :)

Comment 27

[Jason Smith [:jsmith]]

Breaking off this bug into the payments specific bug given that bug 829355 became the identity version of the bug.

Comment 28

[Jason Smith [:jsmith]]

Turns out the same comment over the other bug applies here as well - this title isn't getting translated after looking at the code.

That definitely now makes this blocker worthy. Noming to block.

Comment 29

[Fernando Jiménez Moreno [:ferjm]]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/7617

Pointer to Github pull-request

Comment 30

[Fernando Jiménez Moreno [:ferjm]]

Comment on attachment 702256 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/7617

Since this one is only related to payments, I'm stealing it from Jed.

At some point we might want to get rid of payment.js and identity.js and unify their functionality.

Comment 31

[Fernando Jiménez Moreno [:ferjm]]

Comment on attachment 702256 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/7617

With the attached patch, the trusted UI triggered from a payment request should show the mozPay caller app name as the dialog title or the localized 'Purchase' string (not sure if this is the most appropriate one) in the unlikely case that we cannot retrieve the caller app name.

Comment 32

[Axel Hecht [:Pike]]

Comment on attachment 702256 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/7617

I've already jumped on the PR :-). The title ? title snippets don't actually assign to title, afaict, I think those should be

title = title ? title : ...

The string itself looks OK, though.

Comment 33

[Fernando Jiménez Moreno [:ferjm]]

Comment on attachment 702256 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/7617

Thanks Axel. Fixed.

Comment 34

[Axel Hecht [:Pike]]

Comment on attachment 702256 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/7617

yw, f=me.

Comment 35

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

Comment on attachment 702256 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/7617

Looks good!  r=me

Once that lands, I'll merge and fix any collisions in the PR for bug 828182.

I don't have the ability to merge into gaia - can you do that or nominate someone to do it?  Cheers,
j

Comment 36

[Fernando Jiménez Moreno [:ferjm]]

Thanks Jed! I'll merge it after bug 828182.

BTW, we should probably get you Gaia merge permissions. I'll ask Vivien for it.

Comment 37

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

Thanks, Fernando, I now have the awesome power.

Looking forward to merging this as my first action.

But I shall wait, as you suggest in Bug 828182, for that patch to merge first.

Comment 38

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

The default title, Mozilla Marketplace, is truncated in the ui title to "Mozilla Marketplac...".

I think that this is not a problem with the patch you've submitted here, but with the behavior of the UI and/or the way text is truncated.  I've opened Bug 831091 to focus on that issue.

Comment 39

[Jason Smith [:jsmith]]

(In reply to Jed Parsons [:jparsons] from comment #38)
> The default title, Mozilla Marketplace, is truncated in the ui title to
> "Mozilla Marketplac...".
> 
> I think that this is not a problem with the patch you've submitted here, but
> with the behavior of the UI and/or the way text is truncated.  I've opened
> Bug 831091 to focus on that issue.

How is the titled being derived? By the app name? By the payment provider?

Comment 40

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

The title is derived from the name of the currently-displayed app.

But jsmith and I just spoke on IRC about this.  If the desired title is simply "Marketplace", and that's also the desired title for the icon, then this merely requires a change to the marketplace manifest file.

Comment 41

[Maria Sandberg [:mushi]]

(In reply to Jed Parsons [:jparsons] from comment #40)
> The title is derived from the name of the currently-displayed app.
> 
> But jsmith and I just spoke on IRC about this.  If the desired title is
> simply "Marketplace", and that's also the desired title for the icon, then
> this merely requires a change to the marketplace manifest file.

UX would rather have it be "Marketplace" than truncated :)

Comment 42

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

(In reply to Maria Sandberg [:mushi] from comment #41)
> (In reply to Jed Parsons [:jparsons] from comment #40)
> > The title is derived from the name of the currently-displayed app.
> > 
> > But jsmith and I just spoke on IRC about this.  If the desired title is
> > simply "Marketplace", and that's also the desired title for the icon, then
> > this merely requires a change to the marketplace manifest file.
> 
> UX would rather have it be "Marketplace" than truncated :)

Aha!  Agreed, certainly.  But it won't be truncated!  It was truncated because the actual title was "Mozilla Marketplace (Dev)" (with that trailing Dev bit).  At first I did not realize that was the actual title in question.  And without the "Dev" it doesn't get truncated.  So UX can have either "Marketplace" or "Mozilla Marketplace" as it prefers!

Ironically, if "Mozilla Marketplace" is the preferred title, we need to change the marketplace manifest file (which is easy).  If "Marketplace" is desired, no action is required.

Comment 43

[Fernando Jiménez Moreno [:ferjm]]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/7640

Pointer to Github pull-request

Comment 44

[Fernando Jiménez Moreno [:ferjm]]

Comment on attachment 702755 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/7640

r=jparsons in comment 35.

Rebased and ready to merge.

Sorry, I had to close the other PR and send this new one.

Comment 45

[Julien Wajsberg [:julienw]]

Why is it still "NEW" when it landed in Gaia master ?
https://github.com/mozilla-b2g/gaia/commit/26a3bebd7d8ff2921c1c5b03ba31a73a1c6632ff

FYI this broke the tests for identity.js :(

Comment 46

[Fernando Jiménez Moreno [:ferjm]]

(In reply to Julien Wajsberg [:julienw] from comment #45)
> Why is it still "NEW" when it landed in Gaia master ?
> https://github.com/mozilla-b2g/gaia/commit/
> 26a3bebd7d8ff2921c1c5b03ba31a73a1c6632ff
> 

Because that PR and commit belongs to Bug 829355. The commit message is incorrect.

> FYI this broke the tests for identity.js :(

:( I'll file a bug to track the issue.

Comment 47

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

Fernando filed Bug 831264 as a follow-up, and it is resolved fixed.

In an attempt to test this PR, I am running a glitch with the sms phase of the payment flow in marketplace-dev that's preventing me from going through the entire flow in testing.  Still, Fernando has tested, and I have tested extensively with Marketplace and Identity flows.  Ergo: merged.

Comment 48

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

The last detail we need to hit before we can close this is to decide what to do with the title in the marketplace manifest file.  It can be any of these three and still fit on the trusted ui title bar:

1. Mozilla Marketplace (this is what the UX style guide shows)
2. Firefox Marketplace
3. Marketplace (this is what it is now)

I see that only 'Marketplace' fits under an icon on the home screen itself.

The current title is 'Marketplace', which would therefore require no further changes.

Maria, would you make the call?

Comment 49

[Maria Sandberg [:mushi]]

(In reply to Jed Parsons [:jparsons] from comment #48)
> The last detail we need to hit before we can close this is to decide what to
> do with the title in the marketplace manifest file.  It can be any of these
> three and still fit on the trusted ui title bar:
> 
> 1. Mozilla Marketplace (this is what the UX style guide shows)
> 2. Firefox Marketplace
> 3. Marketplace (this is what it is now)
> 
> I see that only 'Marketplace' fits under an icon on the home screen itself.
> 
> The current title is 'Marketplace', which would therefore require no further
> changes.
> 
> Maria, would you make the call?

Thanks for the summary Jed! Let's go with 'Marketplace' only to not get a truncated title on the home screen.

Comment 50

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

Thanks, Maria.  Then no further action is needed (yay!).  Closing this as fixed, since both the Identity and Marketplace localizations have landed.

Comment 51

[Jason Smith [:jsmith]]

Looks good. I tested this by using Kumar's test app on marketplace dev in the browser first in English to see the "Browser" app name referenced in the title.

I then repeated the same test case with pt-BR and got the translation to show up.

Comment 52

[Lukas Blakk [:lsblakk] use ?needinfo]

Landed on mozilla-b2g18/gaia master prior to the 1/25 branching to mozilla-b2g18_v1_0_0/v1.0.0, updating status-b2g-v1.0.0 to fixed.