830351 - makefiles: remove unused .mkdir.deps rule and add cosmetic edits for Makefile.in to match coding standards.

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Comment 1

[Joey Armstrong [:joey]]

Attachment: remove unused .mkdir.deps rule and clenaup cosmetic makefile problems

Comment 2

[Joey Armstrong [:joey]]

Comment on attachment 701985 [details] [diff] [review]
remove unused .mkdir.deps rule and clenaup cosmetic makefile problems

Edits moved from 747540 patch.
Cosmetic makefile edits to match content in the style guide.

Insert space between operator and line continuation.
Remove trailing whitespace.
Remove leading tabs in rules.mk { editor catch }.
Sort/unique and prevent path=$(space) for vars GENERATED_DIRS and AUTO_DEPS.

Removed un-needed .mkdir.deps rule setup to match deps w/o a directory prefix.

Try job: https://tbpl.mozilla.org/?tree=Try&rev=e0abbe8eaa03

Comment 3

[Joey Armstrong [:joey]]

Inbound push: committed changeset 120479:40aeae12d091

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/40aeae12d091

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

My build is broken with "No rule to make target '.mkdir.done' needed by ['<command-line>', '.mkdir.done']" (after clobbering). Reverting this patch fixes the build.

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

This is a Windows build.