makefiles: remove unused .mkdir.deps rule and add cosmetic edits for Makefile.in to match coding standards.

RESOLVED FIXED in mozilla21

Status

()

Core
Build Config
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: joey, Assigned: joey)

Tracking

unspecified
mozilla21
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Updated

5 years ago
Assignee: nobody → joey
(Assignee)

Updated

5 years ago
See Also: → bug 747540
(Assignee)

Comment 1

5 years ago
Created attachment 701985 [details] [diff] [review]
remove unused .mkdir.deps rule and clenaup cosmetic makefile problems
(Assignee)

Comment 2

5 years ago
Comment on attachment 701985 [details] [diff] [review]
remove unused .mkdir.deps rule and clenaup cosmetic makefile problems

Edits moved from 747540 patch.
Cosmetic makefile edits to match content in the style guide.

Insert space between operator and line continuation.
Remove trailing whitespace.
Remove leading tabs in rules.mk { editor catch }.
Sort/unique and prevent path=$(space) for vars GENERATED_DIRS and AUTO_DEPS.

Removed un-needed .mkdir.deps rule setup to match deps w/o a directory prefix.

Try job: https://tbpl.mozilla.org/?tree=Try&rev=e0abbe8eaa03
Attachment #701985 - Flags: review?(mh+mozilla)
Attachment #701985 - Flags: review?(mh+mozilla) → review+
(Assignee)

Comment 3

5 years ago
Inbound push: committed changeset 120479:40aeae12d091
https://hg.mozilla.org/mozilla-central/rev/40aeae12d091
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
My build is broken with "No rule to make target '.mkdir.done' needed by ['<command-line>', '.mkdir.done']" (after clobbering). Reverting this patch fixes the build.
Depends on: 837754
Depends on: 844387
No longer depends on: 844387
You need to log in before you can comment on or make changes to this bug.