844387 - Valgrind buildbot builds are burning (again)

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

+++ This bug was initially created as a clone of Bug #837754 +++

Valgrind builds are burning again, this time with:

Traceback (most recent call last):
  File "_profile/pgo/profileserver.py", line 23, in <module>
    MOZ_JAR_LOG_FILE = os.path.abspath(os.getenv("JARLOG_FILE"))
  File "/usr/lib/python2.6/posixpath.py", line 342, in abspath
    if not isabs(path):
  File "/usr/lib/python2.6/posixpath.py", line 52, in isabs
    return s.startswith('/')
AttributeError: 'NoneType' object has no attribute 'startswith'

Full 64-bit log:
https://tbpl.mozilla.org/php/getParsedLog.php?id=19981232&tree=Firefox&full=1

Regression window:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=d57a813c77a4&tochange=885cde564ff3

Comment 1

[Gregory Szorc [:gps]]

It's not the underlying problem, but Python 2.6?!

Comment 2

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

(In reply to Gregory Szorc [:gps] from comment #1)
> It's not the underlying problem, but Python 2.6?!

I filed bug 844389.

Comment 4

[Phil Ringnalda (:philor)]

Attachment: fix

That's http://hg.mozilla.org/build/tools/annotate/2cade0ca1ebe/scripts/valgrind/valgrind.sh#81.

Comment 5

[Mike Hommey [:glandium]]

Comment on attachment 723219 [details] [diff] [review]
fix

Review of attachment 723219 [details] [diff] [review]:
-----------------------------------------------------------------

::: scripts/valgrind/valgrind.sh
@@ +77,5 @@
>      debugger_args="$debugger_args --suppressions=$suppression_file"
>  fi
>  
>  export OBJDIR=.
> +export JARLOG_FILE=./jarlog/en-US.log

What is that used for?

Comment 6

[(not currently active) Ted Mielczarek]

Nothing, it's just that profileserver.py expects it to be set:
http://mxr.mozilla.org/mozilla-central/source/build/pgo/profileserver.py#23

Comment 7

[Mike Hommey [:glandium]]

How about fixing that instead?

Comment 8

[Phil Ringnalda (:philor)]

Not requiring it at all does indeed sound like a fine idea, I look forward to seeing someone file and fix that.

http://hg.mozilla.org/build/tools/rev/a5f0cd9e1e86

Comment 9

[Phil Ringnalda (:philor)]

And, whee, somebody added a leak while they were burning, https://tbpl.mozilla.org/php/getParsedLog.php?id=20552379&tree=Firefox

Comment 10

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

(In reply to Phil Ringnalda (:philor) from comment #9)
> And, whee, somebody added a leak while they were burning,
> https://tbpl.mozilla.org/php/getParsedLog.php?id=20552379&tree=Firefox

Filed bug 850134.