Closed Bug 844387 Opened 11 years ago Closed 11 years ago

Valgrind buildbot builds are burning (again)

Categories

(Release Engineering :: General, defect)

x86_64
Linux
defect
Not set
critical

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: gkw, Assigned: philor)

References

Details

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #837754 +++

Valgrind builds are burning again, this time with:

Traceback (most recent call last):
  File "_profile/pgo/profileserver.py", line 23, in <module>
    MOZ_JAR_LOG_FILE = os.path.abspath(os.getenv("JARLOG_FILE"))
  File "/usr/lib/python2.6/posixpath.py", line 342, in abspath
    if not isabs(path):
  File "/usr/lib/python2.6/posixpath.py", line 52, in isabs
    return s.startswith('/')
AttributeError: 'NoneType' object has no attribute 'startswith'

Full 64-bit log:
https://tbpl.mozilla.org/php/getParsedLog.php?id=19981232&tree=Firefox&full=1

Regression window:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=d57a813c77a4&tochange=885cde564ff3
No longer blocks: 830351
It's not the underlying problem, but Python 2.6?!
(In reply to Gregory Szorc [:gps] from comment #1)
> It's not the underlying problem, but Python 2.6?!

I filed bug 844389.
Attached patch fixSplinter Review
That's http://hg.mozilla.org/build/tools/annotate/2cade0ca1ebe/scripts/valgrind/valgrind.sh#81.
Assignee: nobody → philringnalda
Status: NEW → ASSIGNED
Attachment #723219 - Flags: review?(mh+mozilla)
Blocks: 840094
Component: Build Config → Release Engineering: Automation (General)
Product: Core → mozilla.org
QA Contact: catlee
Version: Trunk → other
Comment on attachment 723219 [details] [diff] [review]
fix

Review of attachment 723219 [details] [diff] [review]:
-----------------------------------------------------------------

::: scripts/valgrind/valgrind.sh
@@ +77,5 @@
>      debugger_args="$debugger_args --suppressions=$suppression_file"
>  fi
>  
>  export OBJDIR=.
> +export JARLOG_FILE=./jarlog/en-US.log

What is that used for?
Attachment #723219 - Flags: review?(mh+mozilla) → review+
Nothing, it's just that profileserver.py expects it to be set:
http://mxr.mozilla.org/mozilla-central/source/build/pgo/profileserver.py#23
How about fixing that instead?
Not requiring it at all does indeed sound like a fine idea, I look forward to seeing someone file and fix that.

http://hg.mozilla.org/build/tools/rev/a5f0cd9e1e86
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
And, whee, somebody added a leak while they were burning, https://tbpl.mozilla.org/php/getParsedLog.php?id=20552379&tree=Firefox
(In reply to Phil Ringnalda (:philor) from comment #9)
> And, whee, somebody added a leak while they were burning,
> https://tbpl.mozilla.org/php/getParsedLog.php?id=20552379&tree=Firefox

Filed bug 850134.
Summary: Valgrind tbpl builds are burning (again) → Valgrind buildbot builds are burning (again)
Product: mozilla.org → Release Engineering
Component: General Automation → General
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: