Closed Bug 830668 Opened 8 years ago Closed 7 years ago

Add a keyboard shortcut for Profiler

Categories

(DevTools :: Performance Tools (Profiler/Timeline), enhancement, P2)

enhancement

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 21

People

(Reporter: mihaelav, Assigned: anton)

References

Details

Attachments

(1 file, 1 obsolete file)

All developer tools have a keyboard shortcut (which is also mentioned next to the tool's name in the Tools>Web Developer menu). Profiler doesn't have one and it should, in order to be consistent with the other tools.
Assignee: nobody → anton
Priority: -- → P2
I don't think command-alt-P is reserved for anything (at least hitting that shortcut on my build didn't do anything) so I used it. Also sneaking in a better localization comment for Self.
Attachment #710427 - Flags: review?(vporof)
Attachment #710427 - Flags: review?(rcampbell)
Comment on attachment 710427 [details] [diff] [review]
Add a keyboard shortcut to the Profiler

Review of attachment 710427 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/framework/ToolDefinitions.jsm
@@ +148,5 @@
>    id: "jsprofiler",
> +  accesskey: l10n("profiler.accesskey", profilerStrings),
> +  key: l10n("profiler.commandkey", profilerStrings),
> +  ordinal: 4,
> +  modifiers: osString == "Darwin" ? "accel,alt" : "accel,shift",

that's not going to work on windows. Conflicts with New Private Window.
Attachment #710427 - Flags: review?(rcampbell)
Y instead of P :(
Attachment #710427 - Attachment is obsolete: true
Attachment #710427 - Flags: review?(vporof)
Attachment #711086 - Flags: review?(rcampbell)
Attachment #711086 - Flags: review?(rcampbell) → review+
https://hg.mozilla.org/mozilla-central/rev/b3c6f1442ccc
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 21
Blocks: 839760
CTRL+SHIFT+Y shortcut was already taken on Ubuntu (by download manager) so it doesn't open the profiler: see bug #843559.
Status: RESOLVED → REOPENED
Depends on: 843559
Resolution: FIXED → ---
Status: REOPENED → RESOLVED
Closed: 7 years ago7 years ago
Resolution: --- → FIXED
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.