830668 - Add a keyboard shortcut for Profiler

Status: RESOLVED FIXED

(DevTools :: Performance Tools (Profiler/Timeline), enhancement, P2)

Description

[Mihaela Velimiroviciu (:mihaelav)]

All developer tools have a keyboard shortcut (which is also mentioned next to the tool's name in the Tools>Web Developer menu). Profiler doesn't have one and it should, in order to be consistent with the other tools.

Comment 1

[Anton Kovalyov (:anton)]

Attachment: Add a keyboard shortcut to the Profiler

I don't think command-alt-P is reserved for anything (at least hitting that shortcut on my build didn't do anything) so I used it. Also sneaking in a better localization comment for Self.

Comment 2

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 710427 [details] [diff] [review]
Add a keyboard shortcut to the Profiler

Review of attachment 710427 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/framework/ToolDefinitions.jsm
@@ +148,5 @@
>    id: "jsprofiler",
> +  accesskey: l10n("profiler.accesskey", profilerStrings),
> +  key: l10n("profiler.commandkey", profilerStrings),
> +  ordinal: 4,
> +  modifiers: osString == "Darwin" ? "accel,alt" : "accel,shift",

that's not going to work on windows. Conflicts with New Private Window.

Comment 3

[Anton Kovalyov (:anton)]

Attachment: Add a keyboard shortcut for the Profiler

Y instead of P :(

Comment 4

[Anton Kovalyov (:anton)]

https://hg.mozilla.org/integration/fx-team/rev/b3c6f1442ccc

Comment 5

[Panos Astithas (he/him) [:past] (please ni?)]

https://hg.mozilla.org/mozilla-central/rev/b3c6f1442ccc

Comment 6

[Mihaela Velimiroviciu (:mihaelav)]

CTRL+SHIFT+Y shortcut was already taken on Ubuntu (by download manager) so it doesn't open the profiler: see bug #843559.