Add a keyboard shortcut for Profiler

RESOLVED FIXED in Firefox 21

Status

P2
enhancement
RESOLVED FIXED
6 years ago
3 months ago

People

(Reporter: mihaelav, Assigned: anton)

Tracking

Trunk
Firefox 21
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

6 years ago
All developer tools have a keyboard shortcut (which is also mentioned next to the tool's name in the Tools>Web Developer menu). Profiler doesn't have one and it should, in order to be consistent with the other tools.
(Assignee)

Updated

6 years ago
Assignee: nobody → anton
Priority: -- → P2
(Assignee)

Comment 1

6 years ago
Created attachment 710427 [details] [diff] [review]
Add a keyboard shortcut to the Profiler

I don't think command-alt-P is reserved for anything (at least hitting that shortcut on my build didn't do anything) so I used it. Also sneaking in a better localization comment for Self.
Attachment #710427 - Flags: review?(vporof)
Attachment #710427 - Flags: review?(rcampbell)
Comment on attachment 710427 [details] [diff] [review]
Add a keyboard shortcut to the Profiler

Review of attachment 710427 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/framework/ToolDefinitions.jsm
@@ +148,5 @@
>    id: "jsprofiler",
> +  accesskey: l10n("profiler.accesskey", profilerStrings),
> +  key: l10n("profiler.commandkey", profilerStrings),
> +  ordinal: 4,
> +  modifiers: osString == "Darwin" ? "accel,alt" : "accel,shift",

that's not going to work on windows. Conflicts with New Private Window.
Attachment #710427 - Flags: review?(rcampbell)
(Assignee)

Comment 3

6 years ago
Created attachment 711086 [details] [diff] [review]
Add a keyboard shortcut for the Profiler

Y instead of P :(
Attachment #710427 - Attachment is obsolete: true
Attachment #710427 - Flags: review?(vporof)
Attachment #711086 - Flags: review?(rcampbell)
Attachment #711086 - Flags: review?(rcampbell) → review+
https://hg.mozilla.org/mozilla-central/rev/b3c6f1442ccc
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 21
Blocks: 839760
(Reporter)

Comment 6

6 years ago
CTRL+SHIFT+Y shortcut was already taken on Ubuntu (by download manager) so it doesn't open the profiler: see bug #843559.
(Reporter)

Updated

6 years ago
Status: RESOLVED → REOPENED
Depends on: 843559
Resolution: FIXED → ---
(Assignee)

Updated

6 years ago
Status: REOPENED → RESOLVED
Last Resolved: 6 years ago6 years ago
Resolution: --- → FIXED

Updated

3 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.