843559 - [Ubuntu] Profiler keyboard shortcut (CTRL+SHIFT+Y) opens Library

Status: VERIFIED FIXED

(DevTools :: Performance Tools (Profiler/Timeline), defect)

Description

[Mihaela Velimiroviciu (:mihaelav)]

Reproducible on the latest Aurora (BuildID: 20130220042017): Mozilla/5.0 (X11; Linux i686; rv:21.0) Gecko/20130220 Firefox/21.0
Reproducible on the latest Nightly (BuildID: 20130220031126): Mozilla/5.0 (X11; Linux i686; rv:22.0) Gecko/20130220 Firefox/22.0

Steps to reproduce:
1. Open Firefox 
2. Press CTRL+SHIFT+Y

Expected results: Profiler is launched

Actual results: Library is launched

Notes:
1. This issue is Linux only (not reproducible on Win 7 and Mac 10.7.5)
2. This is reproducible ever since the Profiler shortcut was introduced.
3. CTRL+SHIFT+Y is the shortcut for Downloads Manager (since "forever").

Comment 1

[Anton Kovalyov (:anton)]

Attachment: Change Profiler shortcut to Shift-F5

This patch changes the shortcut to Shift-F5. We already use Shift-FN scheme and my manual tests on Windows, Linux and OS X confirmed that the shortcut seems to be unused.

Comment 2

[Mihai Sucan [:msucan]]

Comment on attachment 726438 [details] [diff] [review]
Change Profiler shortcut to Shift-F5

I can't comment on the new keyboard shortcut. It's fine as long as people won't scream at you for the change. :) (keyboard shortcuts tend to cause that)

l10n comment: any time you change a string you also need to rename the string name.

Otherwise r+.

Comment 3

[Anton Kovalyov (:anton)]

https://hg.mozilla.org/integration/fx-team/rev/348009ddf96d

> (keyboard shortcuts tend to cause that)

I don't think anyone will be particularly sad about the shortcut change because Profiler is still relatively new.

> l10n comment: any time you change a string you also need to rename the string name.

As for l10n, I talked to Victor (you weren't online) he said that we don't need to change the string name in this case. The whole changing string names is a pretty grey area as far as I can tell from different docs and comments.

Comment 4

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/348009ddf96d

Comment 5

[Mihaela Velimiroviciu (:mihaelav)]

Verified that the Shift+F5 shortcut opens the Profiler on latest Firefox 22.0a1 builds across main platforms(Win 7, Mac OS X 10.7 and Ubuntu 12.10).
Could you please land the patch for Firefox 21 - currently Aurora - as well? It should get fixed for that version also before the release.

Comment 6

[:Gavin Sharp [email: [e-mail]]]

(In reply to Anton Kovalyov (:anton) from comment #3)
> As for l10n, I talked to Victor (you weren't online) he said that we don't
> need to change the string name in this case. The whole changing string names
> is a pretty grey area as far as I can tell from different docs and comments.

Not sure what led to that conclusion - not changing the entity name will mean that localizers that have already localized this string likely won't notice the change, and indeed several haven't:

http://mxr.mozilla.org/l10n-central/search?string=profiler.commandkey

Comment 7

[:Gavin Sharp [email: [e-mail]]]

Attachment: followup patch to rename string

This will ensure that localizers notice the change on trunk.

Comment 8

[Anton Kovalyov (:anton)]

Pushed Gavin's followup patch to fx-team: https://hg.mozilla.org/integration/fx-team/rev/0b1907140f8c

Comment 9

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/0b1907140f8c