Closed Bug 83189 Opened 23 years ago Closed 22 years ago

documentation: Deprecated XPCOM Plugin API interfaces need to indicate deprecated status -- public frozen interfaces should be labled clearly in source

Categories

(Core Graveyard :: Plug-ins, defect, P2)

Product:
Core Graveyard
Component:
Plug-ins
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
mozilla1.2alpha

People

(Reporter: peterlubczynski-bugs, Assigned: serhunt)

References

Details

(Whiteboard: [PL2:NA])

Attachments

(1 file, 1 obsolete file)

patch v.2
16.89 KB, patch
serhunt
: review+
darin.moz
: superreview+
Details | Diff | Splinter Review 
It avoid confusion in the future, frozen public interfaces in plugins should be 
clearly labeled or locked down.
marking as enhancement.
Severity: normal → enhancement
Target Milestone: --- → mozilla1.1beta
putting in appropriate labels, moving to future - enhancements will be reviewed
at a later date
Status: NEW → ASSIGNED
Priority: -- → P5
Summary: Public frozen interfaces in plugins should be labeled in source comments → [RFE]Public frozen interfaces in plugins should be labeled in source comments
Target Milestone: mozilla1.1beta → Future
ah.... I think that we have burnt plugin venders one to many times.  This should
task should be completed as soon as possible.  Peter/Av, care to hit this before
mozilla 1.0?
Priority: P5 → --
Summary: [RFE]Public frozen interfaces in plugins should be labeled in source comments → Public frozen interfaces in plugins should be labeled in source comments
Target Milestone: Future → mozilla1.1beta
moving back to future, this is not an RTM stopper
Priority: -- → P5
Summary: Public frozen interfaces in plugins should be labeled in source comments → [RFE]Public frozen interfaces in plugins should be labeled in source comments
Target Milestone: mozilla1.1beta → Future
What files need to be marked? Some FROZEN some DEPRECATED. Lets make a list.
*** Bug 147083 has been marked as a duplicate of this bug. ***
List from bug 147083:

nsIPlugin
nsIPluginInstance
nsIPluginInstancePeer
nsIPluginInstancePeer2
nsIPluginManager
nsIPluginStreamInfo
nsIPluginStreamListener
nsIPluginTagInfo
nsIPluginTagInfo2
Severity: enhancement → normal
Summary: [RFE]Public frozen interfaces in plugins should be labeled in source comments → Public frozen interfaces in plugins should be labeled in source comments
Target Milestone: Future → mozilla1.1alpha
Blocks: 115528
*** Bug 147144 has been marked as a duplicate of this bug. ***
From bug 147144
The Adobe SVG plugin requires these interfaces to be frozen:
nsIJRILiveConnectPlugInstPeer
nsIJRILiveConnectPlugin
nsIJRILiveConnectPluginInstancePeer


ok, so looks like these files would need to be marked (list made from the nsI*
list above)

nsIPlugin.h
nsIPluginInstancePeer.idl
nsIPluginTagInfo.h
nsIPluginStreamListener.idl
nsIPluginInstancePeer2.idl
nsIPluginManager.idl
nsIPluginInstancePeer.h
nsIPluginInstance.h
nsIPluginStreamInfo.h
nsIPluginStreamListener.h
nsIPluginTagInfo2.h
nsIPlugin.idl
nsIPluginTagInfo.idl
nsIPluginInstance.idl
nsIPluginTagInfo2.idl
nsIPluginInstancePeer2.h

nsIJRILiveConnectPlugInstPeer.h
nsIJRILiveConnectPlugin.idl
nsIJRILiveConnectPlugin.h
nsIJRILiveConnectPlugInstPeer.idl
*** Bug 104299 has been marked as a duplicate of this bug. ***
Summary: Public frozen interfaces in plugins should be labeled in source comments → documentation: Deprecated XPCOM Plugin API interfaces need to indicate deprecated status -- public frozen interfaces should be labled clearly in source
Whiteboard: [PL2:P2]
Target Milestone: mozilla1.1alpha → mozilla1.2alpha
Priority: P5 → P2
adding nsbeta1+
Keywords: nsbeta1+
Whiteboard: [PL2:P2] → [PL2:NA]
Attached patch patch v.1 (obsolete) — — Splinter Review 

    
  
Whiteboard: [PL2:NA] → [PL2:NA][review needed]

    
    

    
  
Why choose frozen over deprecated? How about a few lines that plugin developers
should now use NPAPI+XPConnect?

    
    

    
  
I marked FROZEN only two interfaces -- nsIJRIPlugin*. They were not published in
the original XPCOMAPI docs and I don't know if DEPRECATED really applies here.
But if beleive it still makes sense I will do it.

    
    

    
  

      
      
      
      

        Attached patch
          
          
        patch v.2
        — 
          — Splinter Review
      

    


  
I marked FROZEN only two interfaces -- nsIJRIPlugin*. They were not published
in
the original XPCOMAPI docs and I don't know if DEPRECATED really applies here.
But if you beleive it still makes sense I have nothing against it. Done. And a
good point about adding a brief explanation is addressed.

        Attachment #93494 -
        Attachment is obsolete: true

    
    

    
  
Comment on attachment 93518 [details] [diff] [review]
patch v.2

sr=darin

        Attachment #93518 -
        Flags: superreview+

    
    

    
  
Comment on attachment 93518 [details] [diff] [review]
patch v.2

carrying over r=peterl given in the phone conversation.

        Attachment #93518 -
        Flags: review+

    
  
Whiteboard: [PL2:NA][review needed] → [PL2:NA][ready to check in]

    
    

    
  
In.
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED

    
  
Whiteboard: [PL2:NA][ready to check in] → [PL2:NA]

    
    

    
  
v ,patch is in.
Status: RESOLVED → VERIFIED

    
  
Product: Core → Core Graveyard

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: