83196 - Netscape hardwired in imapMsgs.properties

Status: RESOLVED FIXED

(MailNews Core :: Localization, defect, P3)

Description

[nhottanscp]

Separated from bug 80838, following file contains "Mozilla" or "Netscape", make 
it localizable if possible (e.g. by using "&brandShortName;").

# Containing "Mozilla"
mailnews/compose/resources/locale/en-US/composeMsgs.properties
mailnews/local/resources/locale/en-US/localMsgs.properties
# "Containing "Netscape"
mailnews/imap/resources/locale/en-US/imapMsgs.properties

Comment 1

[nhottanscp]

Ray, please review those files and if they needs code change then reassign to 
putterman.

Comment 2

[rchen]

The bug should go to the owner of the component.

Reassigned to putterman.

Comment 3

[scottputterman]

I found the Netscape reference, but I couldn't find the mozilla references using
lxr.  Reassigning to ssu.

Comment 4

[Gervase Markham [:gerv]]

I fixed the Mozilla references over in bug 80838. It's just imapMsgs.properties 
that needs fixing, but the fix isn't trivial.

Gerv

Comment 5

[Ben Bucksch (:BenB)]

Narrowing SUMMARY.

Comment 6

[Gervase Markham [:gerv]]

Although this is now a different bug from bug 80838, I would like to politely
point out that I did some work over there removing hardcoded "Mozilla"s in time
for nsbeta1, on the understanding that some Netscape employee would reciprocate
and remove the hardcoded Netscape's at some point, preferable for 0.9.2. We are
now at 0.9.4. :-|

Gerv

Comment 7

[ji]

Added [e-mail] on the cc list.

Comment 8

[Sean Su]

Attachment: possible fix?

Comment 9

[Sean Su]

nevermind.  my patch does not work.  looking for a real fix now...

Comment 10

[Scott MacGregor]

cleaning up nsbranch keywords. not an eMojo stopper although we'll certainly
take a fix!

Comment 11

[Gervase Markham [:gerv]]

<cough> I hope ssu is still planning to fix this pretty soon. I have pointed out
before in this bug why that would be the honourable thing to do. 

If it's not fixed soon, I may fix it myself by changing all the instances of
"Netscape" to "Mozilla", to match the tree this code resides in. 

Gerv

Comment 12

[Sean Su]

I'm working on it.  I've been recently distracted by other higher priority bugs.

Comment 13

[Gervase Markham [:gerv]]

Thanks :-) I quite understand.

Gerv

Comment 14

[scottputterman]

moving to 0.9.7

Comment 15

[Michele Carlson]

adding nsbeta1

Comment 16

[scottputterman]

moving back in.

Comment 17

[Sean Su]

Attachment: patch v1.1

This patch will replace the hard coded references of 'Netscape' with '%S'. 
I've added localization comments to each property affected.  There are no code
changes needed because I couldn't find any place (via lxr) that referenced
these property strings.

Comment 18

[Sean Su]

Attachment: patch v1.2

fixed a few typos in the comments only from patch v1.0

Comment 19

[tao]

Comment on attachment 62055 [details] [diff] [review]
patch v1.2

looks good. please check with original author of this
file to ensure those (key, value) pairs are not used.

Comment 20

[Gervase Markham [:gerv]]

If they aren't used, surely we should be removing them rather than fixing them?
They are just bloat otherwise.

Gerv

Comment 21

[Sean Su]

I'm not sure if removing them is the correct thing to do.  It looks like David
might have done some of this work.  David, did you work on this before?

Comment 22

[David :Bienvenu]

No, I just ported over the messages from 4.x in the very early days of 6.0 - it
turned out that we didn't use some of them, because we didn't get around to
upgrading from Communicator 4.0 (or maybe we decided we wouldn't support that).
 Let me know which messages you're suggesting we remove and I'll let you know if
it seems reasonable to me. If you want to remove the messages about upgrading to
imap subscription, that's fine.

Comment 23

[Sean Su]

The messages in question are the ones with 'Netscape' in them.  Here is a list
of the ones I found:

5016=Folder creation succeeded, but Netscape was unable to subscribe the new folder.
5017=Folder deletion succeeded, but Netscape was unable to unsubscribe from the
folder.
5018=Folder move succeeded, but Netscape was unable to subscribe to the new
folder name.
5019=Folder move succeeded, but Netscape was unable to unsubscribe from the old
folder name.
5022=While trying to automatically subscribe, Netscape has found a large number
of mail folders. Please select which folders you would like subscribed.
5023=Netscape has detected that you have upgraded from a previous version of
Communicator. You will need to choose which mail folders you want subscribed.
5025=Would you like Netscape to try to automatically subscribe to all your folders?
5027=Please wait while Netscape upgrades you to use IMAP mail folder
subscriptions...

Comment 24

[David :Bienvenu]

If none of those are used, go ahead and delete them.

Comment 25

[Sean Su]

Attachment: patch that removes the offending messages

Comment 26

[Gervase Markham [:gerv]]

I can say that this removes the messages, but I'm not qualified to say whether
it'll break anything. LXR seems to indicate that these aren't used, and if it
builds with them removed, then that should be fine.

If it builds and nothing breaks, r=gerv.

Gerv

Comment 27

[David :Bienvenu]

you'll need to remove the corresponding entries from nsImapStringBundle.h to see
if things rebuild. 

Comment 28

[Ben Bucksch (:BenB)]

Are you sure that no JS uses them?

Comment 29

[Gervase Markham [:gerv]]

I searched for the @name fields - was that the wrong thing to do?

You're right - they aren't preprocessor macros. My mistake.

Gerv

Comment 30

[Sean Su]

Attachment: patch #2 to remove resourced strings

This patch includes diffs to nsImapStringBundle.h and imapMsgs.properties. 
Imap dir (and the main mailnews dir) builds fine with the patch (I did a
clobber build in both).

I also did a global grep in the mailnews dir for the string ids in question,
and found no other references to them.

Let me know if there's a check I have missed.

Comment 31

[David :Bienvenu]

Comment on attachment 62401 [details] [diff] [review]
patch #2 to remove resourced strings

sr=bienvenu

Comment 32

[Scott MacGregor]

Comment on attachment 62401 [details] [diff] [review]
patch #2 to remove resourced strings

r=mscott

Comment 33

[Sean Su]

patch checked in.