Closed
Bug 80838
Opened 25 years ago
Closed 25 years ago
Mozilla and Netscape are hardwired in some DTD files
Categories
(Core :: Internationalization, defect)
Tracking
()
VERIFIED
FIXED
mozilla0.9.2
People
(Reporter: john, Assigned: nhottanscp)
Details
(Keywords: l12y)
Attachments
(2 files)
|
16.98 KB,
patch
|
Details | Diff | Splinter Review | |
|
3.25 KB,
patch
|
Details | Diff | Splinter Review |
This weekend I was working on the files in en-US for a branded version of
Mozilla, and noticed there are many files that have Mozilla or Netscape
hardwired into the files like this example from pref-offline.dtd
<!ENTITY offlineStartAskEach "Mozilla will ask you each time you start the
program.">
Lines like this should read
<!ENTITY offlineStartAskEach "&brandShortName; will ask you each time you start
the program.">
So that setting the value for brandShortName in brand.dtd is the only change
needed between Mozilla, Netscape, or another Vender.
| Assignee | ||
Updated•25 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
| Assignee | ||
Comment 1•25 years ago
|
||
l12y
Reassign to rchen, cc to mcarlson, msanz, tao.
Assignee: nhotta → rchen
Keywords: l12y
Comment 2•25 years ago
|
||
Ray - I don't think you own this one. Please reassign it to the core team.
thanks
The same problem happens again.
Reassigned to ben.
Assignee: rchen → ben
Comment 4•25 years ago
|
||
Jaime, this needs to be escalated. It must be fixed before RTM. Who should we
escalate this to?
Comment 5•25 years ago
|
||
Adding nsbeta1 keyword.
Ading Lyeices to cc: list. We'd like this one for nsbeta1, please review with PDT.
Keywords: nsbeta1
Comment 6•25 years ago
|
||
I'm on the case. I've got the problem scoped (I'm going to have to touch at
least 33 files) and will start on it tomorrow.
Gerv
Assignee: ben → gervase.markham
Updated•25 years ago
|
Target Milestone: --- → mozilla0.9.1
Comment 7•25 years ago
|
||
Thanks gervase. Much appreciated.
Comment 8•25 years ago
|
||
DTDs are done; .properties remain to be done. This is a bit more complex, as the
replacement has to be done by hand where the property is used, so it might take
a bit longer.
Gerv
Comment 9•25 years ago
|
||
OK, I'm splitting this up to get max benefit for 0.9.1. Here come the DTD file
changes. It's exactly the same sort of change everywhere - so it will either all
work or none ;-)
Looking for r= and sr=.
For future reference, the files with properties that need changing are:
# Containing "Mozilla"
mailnews/compose/resources/locale/en-US/composeMsgs.properties
mailnews/local/resources/locale/en-US/localMsgs.properties
# "Containing "Netscape"
mailnews/imap/resources/locale/en-US/imapMsgs.properties
security/manager/ssl/resources/locale/en-US/pipnss.properties
xpfe/browser/resources/locale/en-US/navigator.properties
xpfe/components/xfer/resources/locale/en-US/downloadProgress.properties
I may get around to this, but I may not. If someone wants to take this part of
the bug, please say.
Gerv
Comment 10•25 years ago
|
||
Comment 11•25 years ago
|
||
Bob & Frank - Who can we get to review and super-review this one, so it can be
checked in for M0.9.1? This is important and desired by L10N for M0.9.1.
Updated•25 years ago
|
QA Contact: andreasb → jonrubin
Comment 12•25 years ago
|
||
I can review them. Lots of changes! I will let you know when it's done.
Comment 13•25 years ago
|
||
Thanks Ray!
Comment 14•25 years ago
|
||
The patch looks good to me.
r=rchen
Comment 15•25 years ago
|
||
Ftang/Vishy - Who can SR this one?
| Assignee | ||
Comment 16•25 years ago
|
||
Asked blizzard for a superreview.
Comment 17•25 years ago
|
||
Rubber stamp fodder. rs=blizzard
Comment 18•25 years ago
|
||
Anyone can check this in; if no-one gets around to it, I will (yay!) sometime
tomorrow.
Gerv
Comment 19•25 years ago
|
||
DTD patch checked in. Properties patches still need doing.
Gerv
Comment 20•25 years ago
|
||
Tracking Bug 14532 is for bugs dealing with Netscape in the Mozilla tree. I went
through the active bugs and one of them is related to this bug and could be
considered a dupe of it.
Bug 43675 summary is Download alert shouldn't say "Netscape". The Netscape is in
one of the Properties files that haven't been fixed yet. There is a patch
attached to bug 43675 that will cause a regression in this bug if is checked in
after the Properties are changed to &brandShortName because the patch on that
bug simply changes Netscape to Mozilla.
Fixing the Properties files in this bug will also fix bug 43675
Comment 21•25 years ago
|
||
OK, I've fixed the two occurrences of Mozilla in ".properties" files. Some of
the occurrences of Netscape, particularly in imapMsgs.properties, will take a
bit more work, and some code changes. So, I'm leaving them in to make your lives
easier.
I full expect Netscape to reciprocate for the work I've just done by fixing the
occurrences of "Netscape" as soon as possible after 0.9.1. For reference, the
files concerned are:
mailnews/imap/resources/locale/en-US/imapMsgs.properties
security/manager/ssl/resources/locale/en-US/pipnss.properties
xpfe/components/xfer/resources/locale/en-US/downloadProgress.properties
New patch coming up. Again, requires r=. Properties-and-DTD-only changes have an
auto rs= from brendan, so we don't need to bother blizzard.
Gerv
Comment 22•25 years ago
|
||
Comment 23•25 years ago
|
||
Gervase - Should we keep this one open or open another one for the Netscape
proprietary issues? If we keep it open, I can reassign to a person in-house. Pls
lemme know.
Comment 24•25 years ago
|
||
Let's get the current patch reviewed and checked in, and then you can reassign
to whoever to fix the last bit. (The last issues are not "Netscape proprietary",
they merely deal with instances of the word Netscape in the Mozilla tree.)
Gerv
Comment 25•25 years ago
|
||
Ok . . . WFM.
Comment 26•25 years ago
|
||
r=doron
Comment 27•25 years ago
|
||
Ok, the Properties patch is in apart from the fix to pipnss.properties, as I
don't have checkin privs to the security partition.
CCing javi and thayes from the list CVS gave me: can one of you copy and paste
the pipnss.properties patch from the 2nd patch in this bug and check it in,
please? Thanks :-)
Gerv
Comment 28•25 years ago
|
||
The "Netscape" in CertDumpCertType should not be dropped because that is the
extension defined by Netscape before the industry developed a standard extension
to describe what the purpose of a certificate was. "Netscape Certificate Type"
is the industry standard description for the extension that string is used to
describe.
I will not check in this change to pipnss.properties because the string
adequately describes the change and in no way is forcing the "Netscape" brand on
other projects that decide to pick up PSM 2.
At most I will check in a comment to the properties file explaining this.
Comment 29•25 years ago
|
||
javi: please read the patch carefully. This change corrects typos in the word
"Certificate". It does not remove the word "Netscape".
Gerv
Comment 30•25 years ago
|
||
<sigh> This isn't important. javi: it would be good if you could check that
patch in, but it can wait.
Gerv
Target Milestone: mozilla0.9.1 → mozilla0.9.2
Comment 31•25 years ago
|
||
I think this is a 0.9.1 issue. 0.9.1 is the milestone embedders are suggested to
use to branch, and thus, removing hardcoded product names should go in,
especially since this is such a low risk patch.
Comment 32•25 years ago
|
||
Doron: The remaining patch in this bug corrects typos. There is no patch for the
other hardwired "Netscape"s in the files I quote above, because fixing them
would be non-low-risk (involving code changes.)
I would have thought most embedders would grep for "Netscape" and change it to
"FooBrowser" (unless there was a comment suggesting otherwise) at some point
before release ;-) So, if Javi checks in the _spelling correction_ patch, he
might want to add the comment he suggested.
Gerv
Comment 33•25 years ago
|
||
A fix for the typo is included in the patch for Bug 78806 which is in the review
process for check-in to 0.9.1
Comment 34•25 years ago
|
||
Great. All that this bug remains open for, then, is the other properties file
changes, which an as-yet-unnamed Netscape employee is going to sort out for
0.9.2. jaimejr has that under control.
Reassigning to default.
Gerv
Assignee: gervase.markham → nhotta
QA Contact: jonrubin → andreasb
| Assignee | ||
Comment 35•25 years ago
|
||
Filed mail/news files issue as bug 83196.
xpfe/browser/resources/locale/en-US/navigator.properties
browser.search.defaultenginename=Netscape Search
This is a default search name. I think this is fine.
security/manager/ssl/resources/locale/en-US/pipnss.properties
CertDumpCertType=Netscape Certificate Type
I am not sure about this, filed as bug 83199.
xpfe/components/xfer/resources/locale/en-US/downloadProgress.properties
"Netscape" is in comment only.
Mark this bug as fixed.
Status: NEW → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Comment 36•25 years ago
|
||
QA -> jonrubin@netscape.com
Jon, please verify this during your test cycle in this area. Check with nhotta
or ftang if you need test cases for this.
QA Contact: andreasb → jonrubin
Comment 37•25 years ago
|
||
Boys, great! Thanks for fixing this! :-)
Comment 38•25 years ago
|
||
FYI: Bug 60741 calls for a generic replacement solution (not involving specific
code for each instance) for .properties files.
Comment 39•25 years ago
|
||
mass change, switching qa contact from jonrubin to ruixu.
QA Contact: jonrubin → ruixu
Comment 40•25 years ago
|
||
Extracted and checked all DTD files in branch and trunk, couldn't found
hardwired Mozilla or Netscape. Mark bug as Verified.
Comment 41•25 years ago
|
||
ruixu: I don't believe you. What about:
mailnews/imap/resources/locale/en-US/imapMsgs.properties
?
This is bug 83196, and so this bug should remain fixed. However, you may want to
investigate why your search failed to find this file.
Gerv
Comment 42•25 years ago
|
||
Gervase, I am assuming that the bug reporter was talking about the defects in some DTD files originally.
As you pointed out, the .properties issues have been found and separated after that, and report as bug 83196, bug 60741, ...., etc.
Please let me know if still having hardwired Mozilla or Netscape in DTD files, since it is difficult to search all DTD files line by line, and it needs a quantity of time. Thank you.
You need to log in
before you can comment on or make changes to this bug.
Description
•