832876 - [Settings] Call settings - When wrong number is input in forwarding number field, there is no warning popup

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Leo]

1. Title : When wrong number is input in forwarding number field, there is no warning popup
2. Precondition : Settings >> Call settings
3. Tester's Action : Input wrong number (ex : "((((" )
4. Detailed Symptom (ENG.) : There is no popup
6. Expected : Appear warning popup or cannot input number
7. Reproducibility: Y
1) Frequency Rate : 100%
8. Gaia revision : a03f7b532e9998e646d55f93a0fc03a04d7ca7d9

Comment 1

[José Antonio Olivera Ortega [:jaoo]]

Attachment: Pointer to Github PR: https://github.com/mozilla-b2g/gaia/pull/7984

Kaze, this PR is about checking the number entered for the call forwarding rule before setting it up. Could you take a look at it please? Thx!

Comment 2

[José Antonio Olivera Ortega [:jaoo]]

Comment on attachment 710650 [details]
Pointer to Github PR: https://github.com/mozilla-b2g/gaia/pull/7984

Vivien, Kaze is PTO. Could you take a look at this PR please?. See comment #1 for more information. Thx!

Comment 3

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 710650 [details]
Pointer to Github PR: https://github.com/mozilla-b2g/gaia/pull/7984

Kaze will be back on monday so hopefully this bug will be reviewed!

Comment 4

[Fabien Cazenave [:kaze]]

Comment on attachment 710650 [details]
Pointer to Github PR: https://github.com/mozilla-b2g/gaia/pull/7984

Looks good to me. I just have a UX suggestion, feel free to see with Josh.

Comment 5

[José Antonio Olivera Ortega [:jaoo]]

Oops, forgot to land this.

https://github.com/mozilla-b2g/gaia/commit/46511e8b0e84b8ae18671fcd34a75ccbdb720ccf

Thanks kaze!

Comment 6

[Maria Angeles Oteo (:oteo)]

Asking for leo flag, as it seems a partner request

Comment 7

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted commit 46511e8b0e84b8ae18671fcd34a75ccbdb720ccf as:
v1-train: da59ffd209554f60a25af05d7ae1aaa0c1a4199d

Comment 8

[José Antonio Olivera Ortega [:jaoo]]

Noming for tef+, it blocks bug 857691.

Comment 9

[José Antonio Olivera Ortega [:jaoo]]

James, I'll uplift this bug once all the dependencies reach the corresponding branches/release repos. James, I'll contact you in case of I need help. Thanks a lot for your support in previous upliftings.

Comment 10

[José Antonio Olivera Ortega [:jaoo]]

v1.0.1: cbe9c73f8eaa25e10c00a29489edf519256d06b4

Comment 11

[Jeni]

Can you please provide steps to verify this fix - as we will blackbox test from the UI?

Comment 12

[José Antonio Olivera Ortega [:jaoo]]

See comment #0 please.

Comment 13

[pallavi]

Same issue is reproducing on Leo(v1.1.0). There is no warning pop up message for the user, Once after entering wrong input are while entering wrong input

Leo Build ID: 20130515070208
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/d06cfe7d67c2
Gaia: 0ddb515f15cbc6b74fc2742b7599d6ae74c6413f

Comming to the Inari(V1.0.1). The Call settings menu shows "error in query" message in the subtitle. Bug:821608

Inari Build ID: 20130515070203
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/0b6bcb1f4175
Gaia: 9648799c2e45917ff150fa9eef8aeac79a9ac008

Comment 14

[Sarah Parsons]

Verified fixed on Unagi 1.1 Build ID: 20130530070208

Kernel Date: Dec 5
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/09ac1fd2959c
Gaia: 1cca9324d4444ad28c6fa99875e17abf7e8230be

Unable to verify on Inari 1.0.1 per bug# 821608 The Call settings menu shows "error in query" message in the subtitle.

Inari Build ID: 20130530070208
Environmental  Variables:
Kernel Date: Dec 5
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/09ac1fd2959c
Gaia: 1cca9324d4444ad28c6fa99875e17abf7e8230be