857691 - Weird error message showed when checking Call Waiting status

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect, P1)

Description

[David Palomino [:dpalomino]]

Attachment: screenshot described before

Buildid "20130321070205", device: ikura

The first time the user tries to check the status of Call Wating (Settings > call settings > Call Wating), a weird error screen appears (see screenshot attached). 

Message shown (in Spanish) is something like: "It is not possible to confirm the call waiting preferences. The device cannot communicate with carrier. Try it later. Call Waiting (disabled)". 

Although it has not a really big impact on usability, is ugly to have this error message the first time you check Call Waiting status. I would nonimate for tef+. 

Thanks!
David

Comment 1

[Daniel Coloma:dcoloma]

jaoo, any idea why this screen is shown?

Comment 2

[José Antonio Olivera Ortega [:jaoo]]

(In reply to Daniel Coloma:dcoloma from comment #1)
> jaoo, any idea why this screen is shown?

This user experience/screen flow was suggested for the UX team. The call waiting status is unknown until the user enbles/disables it. There is no way to request its status so what we do is to show that alert message and let the user to enable/disable it. After enabling/disabling it we know precisely what the status is because the status comes in the response from the network. Sadly there is no way to request the call waiting status from the network which is truly the main issue.

Comment 3

[Daniel Coloma:dcoloma]

Have you check how other devices behave in this situation?

Comment 4

[Daniel Coloma:dcoloma]

David, is this a certification blocker?

Comment 5

[José Antonio Olivera Ortega [:jaoo]]

(In reply to Daniel Coloma:dcoloma from comment #3)
> Have you check how other devices behave in this situation?

Other OS (e.g. Android 4.2.2) implement the RIL_REQUEST_QUERY_CALL_WAITING request and provide a different UX. The call waiting status is requested to the network once the user visits the setting panel (e.g. as we do with call forwarding).

Comment 6

[David Palomino [:dpalomino]]

Hi, 

This issue has been reported as a certification blocker... 

Changing prio to P1 because of this. 

Br, 
David

Comment 7

[Daniel Coloma:dcoloma]

Which alternatives (if any) do we have here. Jaoo, can you please talk to dpv to discuss this?

Comment 8

[José Antonio Olivera Ortega [:jaoo]]

(In reply to Daniel Coloma:dcoloma from comment #7)
> Which alternatives (if any) do we have here. Jaoo, can you please talk to
> dpv to discuss this?

There's no any bug here, even It doesn't block IMHO. Call waiting feature is implemented and it works. Current UX behavior is based in UX suggestions done in bug 796824.

The alternative will be to implement RIL_REQUEST_QUERY_CALL_WAITING request in gecko and discuss and change the UX we have right now (e.g. suggest something like call forwarding UX).

Comment 9

[Daniel Coloma:dcoloma]

David, given comment 8 it seems we need to explain this to the certification team to check if we can get a waiver for this. Can you please do so?

Comment 10

[David Palomino [:dpalomino]]

Hi, 

This is a blocking issue for the certification in Spain. Although it's not confirmed yet, we can expect also to be blocking for LatAm. 

Thks!
David

Comment 11

[José Antonio Olivera Ortega [:jaoo]]

Stealing it since the code is so familiar to me and I'm in charge of the gecko development underneath.

Comment 12

[Germán Toro del Valle (:gtorodelvalle)]

Be my guest... :-p If you need any help, please let me know ;-) Thanks!

Comment 13

[José Antonio Olivera Ortega [:jaoo]]

Attachment: WIP v1.

Comment 14

[José Antonio Olivera Ortega [:jaoo]]

Attachment: Pointer to Github PR: https://github.com/mozilla-b2g/gaia/pull/9097

Arthur, this PR is about changing how we interact with the platform for setting call waiting options. I've implemented a couple of functions in mozMobileConnection API for it. There are getCallWaitingOption() and setCallWaitingOption(). Both functions are so similar to the ones that we have used for setting call forwarding options. Could you take a look please? Notice this work depends on bug 859318 and it must not land until bug 859318 bug gets landed. Thanks.

Comment 15

[Michael Schwartz [:m4]]

(In reply to José Antonio Olivera Ortega [:jaoo] from comment #14)
> Created attachment 735839 [details]
> Pointer to Github PR: https://github.com/mozilla-b2g/gaia/pull/9097
> 
Just passing through...not a full review but while looking around noticed your line 113 and 121 don't match up (kSimCardStates vs kSimCardState).  nit: You should probably be using let for simSardState (which I assume is a typo for simCardState).

Comment 16

[Arthur Chen [:arthurcc][inactive after 6/30]]

Jose, overall it looks good. I will have a final review after bug 859318 landed so that I can get the code works.

Comment 17

[David Palomino [:dpalomino]]

Also reported in Colombia. Adding dep.

Comment 18

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 735839 [details]
Pointer to Github PR: https://github.com/mozilla-b2g/gaia/pull/9097

Jose, could you send the review request again when the gecko part is ready? Thanks!

Comment 19

[Dietrich Ayala (:dietrich)]

Jose, do you have an ETA for the gecko part? Thanks!

Comment 20

[José Antonio Olivera Ortega [:jaoo]]

(In reply to Dietrich Ayala (:dietrich) from comment #19)
> Jose, do you have an ETA for the gecko part? Thanks!

I hope tomorrow, we just need to get the patches reviewed. Thanks!

Comment 21

[José Antonio Olivera Ortega [:jaoo]]

Comment on attachment 735839 [details]
Pointer to Github PR: https://github.com/mozilla-b2g/gaia/pull/9097

Arthur, I'm about to start landing bug 859318. Could you take a look at the Gaia changes?

Comment 22

[Evelyn Hung]

Comment on attachment 735839 [details]
Pointer to Github PR: https://github.com/mozilla-b2g/gaia/pull/9097

steal this review because Arthur is PTO today.

Comment 23

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 735839 [details]
Pointer to Github PR: https://github.com/mozilla-b2g/gaia/pull/9097

r=me. Jose, it works well, thanks for the effort!

Comment 24

[José Antonio Olivera Ortega [:jaoo]]

(In reply to Arthur Chen [:arthurcc] from comment #23)
> Comment on attachment 735839 [details]
> Pointer to Github PR: https://github.com/mozilla-b2g/gaia/pull/9097
> 
> r=me. Jose, it works well, thanks for the effort!

Thanks for reviewing it we know you are in PTO. Thanks!

Comment 25

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

https://github.com/jaoo/gaia/commit/cfe6ee1865e5e3025a98d57c941d96cee22f231b

Comment 26

[James Lal [:lightsofapollo]]

I was not able to uplift this bug to v1-train and v1.0.1.  If this bug has dependencies which are not marked in this bug, please comment on this bug.  If this bug depends on patches that aren't approved for v1-train and v1.0.1, we need to re-evaluate the approval.  Otherwise, if this is just a merge conflict, you might be able to resolve it with:

  git checkout v1-train
  git cherry-pick -x  cfe6ee1865e5e3025a98d57c941d96cee22f231b
  <RESOLVE MERGE CONFLICTS>
  git commit
  git checkout v1.0.1
  git cherry-pick -x $(git log -n1 v1-train --pretty=%H)

Comment 27

[José Antonio Olivera Ortega [:jaoo]]

A bunch of bugs (related) have been landed in gaia master branch before this one. The down side is that just a few of them have been uplifted to gaia v1-train and v1.0.1 branches. I'll give a detail description asap about what we need to uplift before this and the order for doing the upliftings. Thanks.

Comment 28

[José Antonio Olivera Ortega [:jaoo]]

Adding deps. Before uplifting this bug bugs 859318, 827282, 834103, 832876, and 823508 must land. The order would be:

1.- Uplift bug 859318 to mozilla-b2g18 and mozilla-b2g18_v1_0_1 release repos.
2.- Uplift bug 827282 to v1.0.1 gaia branch (already in v1-train gaia branch).
3.- Uplift bug 834103 to v1.0.1 gaia branch (already in v1-train gaia branch).
4.- Uplift bug 832876 to v1.0.1 gaia branch (already in v1-train gaia branch).
5.- Uplift bug 823508 to v1-train and v1.0.1 gaia branches.

I'll request tef+ flags for all of them.

Note: These dependencies are due to continuous changes in the code for call settings in the setting app.

Comment 29

[James Lal [:lightsofapollo]]

Still have conflicts when trying to uplift... see my comments on the bugs directly.
Might be better for you to uplift in this case.. I am more then happy to help but I can't resolve the conflicts which probably just makes my role in uplifting a bottleneck.

Comment 30

[José Antonio Olivera Ortega [:jaoo]]

James, I'll uplift this bug once all the dependencies reach the corresponding branches/release repos (e.g. this work heavily depends on bug 859318 and we need it reaches mozilla-b2g18 and mozilla-b2g18_v1_0_1 release repos). James, I'll contact you in case of I need help. Thanks a lot for your support in previous upliftings.

Comment 31

[José Antonio Olivera Ortega [:jaoo]]

v1-train: 9c6e9decdd1333f3b6dbed22538a85361cf944dc

Comment 32

[José Antonio Olivera Ortega [:jaoo]]

v1.0.1: a65ae36f1a6e0731c332ffbc68600410be496be0

Comment 33

[Juan Perez-Bedmar [:juanpbf]]

Hi jaoo, I have tested the latest nightly build available for Ikura (from April 29th), and now I see a different (and wrong behaviour):

Now, there is no "!" mark on the Call waiting status, and therefore the message shown in attachment 732941 [details] does not appear but, the whole "call settings" menu page gets frozen (call waiting status cannot be changed, and call forwarding information cannot be retrieved from the network); I will attach a new screenshot.

Can you please take a look at it?

Comment 34

[Juan Perez-Bedmar [:juanpbf]]

Attachment: Screenshot from the Call settings menu.

This is the screen that is shown forever in the Call settings menu: 
- Call waiting status cannot be changed
- Call forwarding info remains in "requesting to the NW" status forever.

Comment 35

[José Antonio Olivera Ortega [:jaoo]]

(In reply to Juan Perez-Bedmar [:juanpbf] from comment #34)
> Created attachment 743607 [details]
> Screenshot from the Call settings menu.
> 
> This is the screen that is shown forever in the Call settings menu: 
> - Call waiting status cannot be changed
> - Call forwarding info remains in "requesting to the NW" status forever.

Check if the commercial RIL version in that build includes the support added in bug 859318. AFAIK at the time this bug landed on v1.0.1 Gaia branch that support was not included in commercial RIL.

Comment 36

[Anshul]

Antonio, we would have support for call waiting in commercial RIL landed today. Sorry for the delay.

One thing I also noticed is that the call forwarding request is not send until the response for call waiting is received, which I don't think is correct.

Comment 37

[José Antonio Olivera Ortega [:jaoo]]

(In reply to Anshul from comment #36)
> One thing I also noticed is that the call forwarding request is not send
> until the response for call waiting is received, which I don't think is
> correct.

That's the expected behavior. Call waiting and call forwarding settings are in the same panel so the UI starts requesting the call waiting status and after getting it starts requesting the call forwarding one.

Comment 38

[Anshul]

Support for this bug in commercial RIL is available in AU_LINUX_GECKO_ICS_STRAWBERRY_V1.01.00.01.019.092