Closed Bug 833714 Opened 11 years ago Closed 11 years ago

B2G PhonenumberJS: Use lastKnownMcc from RIL

Categories

(Core :: DOM: Device Interfaces, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

()

RESOLVED DUPLICATE of bug 841234

People

(Reporter: allstars.chh, Assigned: allstars.chh)

References

Details

Attachments

(1 file)

Although in Bug 822528 it reads previous MCC from RIL, which is implemented in Bug 819560.
However when Bug 819560 is landed, the naming has been changed to 'lastKnownMcc', yet Bug 822528 still uses the original naming 'previousMcc'.

Also when Bug 825841 is landed, it has regression because the voiceConnectionInfo in RILContentHelper has been changed from 'ril.voiceConnectionInfo' to ril.rilContext.voiceConnectionInfo
Assignee: nobody → allstars.chh
Attached patch WIP - PatchSplinter Review
Gregor, I got some questions

1. When will MCC in SIM be unavailable? SIM not inserted?
   In that case how do you send/receive SMS or call?


I'd like to write some marionette test but I don't know understand what condition we cannot get MCC from SIM.
(In reply to Yoshi Huang[:yoshi][:allstars.chh] from comment #1)
> Created attachment 705801 [details] [diff] [review]
> WIP - Patch
> 
> Gregor, I got some questions
> 
> 1. When will MCC in SIM be unavailable? SIM not inserted?
>    In that case how do you send/receive SMS or call?

I think it's unavailable if you don't have a SIM card inserted or during startup.
We don't send/receive SMS or calls, but we open the SMS DB during startup. If we happen to upgrade the DB schema, we have to call into PhoneNumberJS and there we need a valid MCC code.

So it's not something we need every day but the last time we upgraded the SMS DB, we couldn't update existing SMS because PhoneNumberJS couldn't get any information about the MCC.

> 
> 
> I'd like to write some marionette test but I don't know understand what
> condition we cannot get MCC from SIM.

Yep it's complicated to trigger this scenario in a marionette test. You would have to push an old SMS DB to the emulator and test the upgrade code.
Oh I was looking for this bug but I filed and fixed it in bug 841234.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → DUPLICATE
Thanks,
I was still working on test cases so didn't send r?.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: