Closed Bug 834422 Opened 12 years ago Closed 11 years ago

Add Open Graph Protocol (OGP) and Twitter Cards to most mozilla.org pages

Categories

(www.mozilla.org :: Pages & Content, enhancement, P4)

Product:
www.mozilla.org
Component:
Pages & Content
Type:
enhancement

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: jjensen, Assigned: kohei)

References

Details

(Whiteboard: [kb=1031498] )

Attachments

(1 file)

Screen Shot after fix
60.83 KB, image/png
Details
We should make use of Twitter cards, at least on the pages of our site that are more likely to be tweeted by our followers/community members. https://dev.twitter.com/docs/cards
Hi John- Would you be willing to investigate any privacy concerns surrounding Twitter cards before we move forward with this one? Thx, Jen
Flags: needinfo?(jjensen)
Priority: -- → P4
Jen, I cannot think of any privacy implications at all. All it is some additional HTML markup on our public web pages.
Flags: needinfo?(jjensen)
OGP is also good for Facebook. http://ogp.me/
OS: Windows 8 → All
Hardware: x86_64 → All
Summary: Add Twitter cards to most mozilla.org pages → Add Open Graph Protocol Twitter Cards to most mozilla.org pages
To implement OGP and Twitter Cards, each page requires a unique, appropriate description. That has been discussed in Bug 850164.
Depends on: 850164
Michaela- Is this a priority for your team? Thx Jen
Flags: needinfo?(mthayer)
Hi Jen, "Twitter cards" actually refer to a number of things, including a few Twitter ad units and a new lead gen unit launched yesterday. I think you're referencing ways to share content through Twitter widgets on mozilla.org sites. Is that right? A similar conversation is happening regarding Facebook (see bug https://bugzilla.mozilla.org/show_bug.cgi?id=791870) and the importance of social sharing after desktop download. If I am understanding you correctly - yes - we should always do our best to incorporate social sharing into websites. Word of mouth marketing (the sharing of information between peers) is the most trusted form of advertising and this is a great way to generate that. All this being said, Chris M., Stacy, and I have reached out to Facebook and Twitter about them allowing us to build custom share widgets because their current policies do not adhere to our privacy policy. I will keep you updated when we hear back with a definitive yes or no from them. If I've misunderstood this chain, just let me know :). Might be giving you information that you didn't need to know! Thanks :), Michaela
Flags: needinfo?(mthayer)
I'm going to resolve -> won't fix this for now, pending the outcome of next steps in the cmore/Stacy/Michaela conversation. We can reopen if/when appropriate.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → WONTFIX
We need canonical URL to implement those social features (later).
Depends on: 481550
Summary: Add Open Graph Protocol Twitter Cards to most mozilla.org pages → Add Open Graph Protocol (OGP) and Twitter Cards to most mozilla.org pages
I think this is still valid. OGP + Twitter Card is an extra markup to expose better title, description, image, etc. to major social sites. Some Mozilla properties, including MDN, Mozilla Hacks and The Mozilla Blog, have already supported OGP, and MDN also supports Twitter Cards as I mentioned in my comment 7. Custom share widget, which involves user privacy, is different stuff. It has been discussed in Bug 725759.
Status: RESOLVED → REOPENED
Resolution: WONTFIX → ---
Hi Jen and Team, All sounds good to me. It would be great to get this up and running. However, in terms of priority from my team's perspective, getting the Firefox OS landing page ready to go is at the top of our list. (All things Firefox OS taking priority on my plate.) Once this can be prioritized (not sure what your workload is looking like), ping me and let me know what you need from me. Thanks, Michaela
I'll implement this soon, so people can share the Firefox OS landing page with the appropriate meta data. I have already written code to implement canonical URLs: https://github.com/kyoshino/bedrock/commit/f25df0c11a178b855cfb80f89a4e89549b524602 Though the description of the page should be written by a copywriter, the implementation of the template is easy.
Assignee: nobody → kohei.yoshino.bugs
Status: REOPENED → ASSIGNED
+1 to the canonical tags and the OG/twitter cards. I've been wanting us to do this for a *long* time, but there were bigger bedrock/php issues to work about. Nice job, Kohei!
Blocks: 885830
Whiteboard: [kb=1031498]
Depends on: 903886
No longer depends on: 481550
No longer blocks: 885830
Severity: normal → enhancement
Kohei, what are next steps here? Looks like you still need to submit a PR.
I'm writing a test for Bug 903886. Once the backend code is implemented, we can add the frontend assets easily.
My current WIP is here, but I'm likely running into Jinja's bug or something. I think the patch was working before. Still investigating. https://github.com/kyoshino/bedrock/commit/61015e9
Kohei: any update on this bug?
Sorry for the delay. I just send a pull request: https://github.com/mozilla/bedrock/pull/1260
My PR has been merged to master. https://www-dev.allizom.org/en-US/ https://www-dev.allizom.org/en-US/firefox/new/ and everywhere on Bedrock!
Status: ASSIGNED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
Hmm wait, Facebook says there's an error: https://developers.facebook.com/tools/debug/og/object?q=http://www.mozilla.org/en-US/ > Object Invalid Value > Object at URL 'http://www.mozilla.org/en-US/' of type 'website' is invalid > because the given value '//mozorg.cdn.mozilla.net/media/img/mozorg/mozilla-256.jpg' > for property 'og:image:url' could not be parsed as type 'url'. Will fix it :(
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(In reply to Kohei Yoshino [:kohei] from comment #25) > Hmm wait, Facebook says there's an error: > > https://developers.facebook.com/tools/debug/og/object?q=http://www.mozilla. > org/en-US/ > > > Object Invalid Value > > Object at URL 'http://www.mozilla.org/en-US/' of type 'website' is invalid > > because the given value '//mozorg.cdn.mozilla.net/media/img/mozorg/mozilla-256.jpg' > > for property 'og:image:url' could not be parsed as type 'url'. > > Will fix it :( probably doesn't like the protocol relative URL. Are you going to do http or https?
(In reply to Chris More [:cmore] from comment #26) > probably doesn't like the protocol relative URL. Are you going to do http or > https? Sent a new PR to add an option to media() to include a protocol: https://github.com/mozilla/bedrock/pull/1299 If a visitor uses HTTPS, the function should output https:// accordingly.
Replacing // with https:// might be the simplest solution here. Updated the pull request.
Commits pushed to master at https://github.com/mozilla/bedrock https://github.com/mozilla/bedrock/commit/747ca8ebb479f16ce53d78cb8ed9bd1823aad75f Bug 834422, og:image should include a protocol https://github.com/mozilla/bedrock/commit/ec0068945413f7d9160fe3f796b101e809155380 Merge pull request #1299 from kyoshino/bug-834422-meta-ogp-protocol Bug 834422, og:image should include a protocol
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
verified fixed on prod
Status: RESOLVED → VERIFIED
Blocks: 931247
Looks like the og:image is included in custom search results: http://www.google.com/cse?cx=002443141534113389537%3Aysdmevkkknw&q=Firefox
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: