835022 - Do not switch to private tabs automatically

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Michael Monreal [:micmon]]

Open just a normal tab and close it: the homescreen will show. Now open a normal tab and a private tab, then go to the normal tab and close it. Firefox automatically switches to the only remaining tab, which is the private one. IMHO this is bad, it should show the home screen just as before and only switch to the other tab set if you explictly do so.

Comment 1

[Michael Monreal [:micmon]]

The switch also happens if there are other normal tabs remaining but you close the lowest one. It switches to the "next" tab, which happens to be the private one.

Comment 2

[Sriram Ramasubramanian [:sriram]]

What's the expected behavior here?

Comment 3

[Ian Barlow (:ibarlow)]

I've noticed this too. We should always try to keep users in their current mode, and never surprise them by switching into Private without their explicitly making that change.

Expected behaviours:

Action: Close one of 2 or more normal tabs
Result: Switch to next normal tab in list

Action: Close last normal tab
Result: Load about:home in a normal tab

Action: Close one of 2 or more private tabs
Result: Switch to next normal tab in list

Action: Close last private tab
Result: Load about:home in a normal tab
NOTE: this last behaviour is inconsistent, because we are assuming in this case that a user's intent in closing the last remaining private tab is to cover their tracks and not leave evidence of whatever they were doing, not even a blank private tab.

Comment 4

[Kevin Brosnan [Ex-Mozilla]]

We should be consistent when accepting URL intents as well.

Comment 5

[Brian Nicholson (:bnicholson)]

Attachment: Switch to correct tab when a tab is closed

Comment 6

[Brian Nicholson (:bnicholson)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c3e41bbb40a5

Comment 7

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Backed out:

https://hg.mozilla.org/integration/mozilla-inbound/rev/00c09b326fee
https://hg.mozilla.org/integration/mozilla-inbound/rev/014e88baa216

for robocop orange:

https://tbpl.mozilla.org/php/getParsedLog.php?id=19799058&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=19798804&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=19798937&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=19799040&tree=Mozilla-Inbound

Comment 8

[Michael Monreal [:micmon]]

>> status-firefox21: --- → fixed

It's still affected

Comment 9

[Brian Nicholson (:bnicholson)]

That testTabsTray failure shouldn't be an issue anymore since that test case was disabled.

Try results: https://tbpl.mozilla.org/?tree=Try&rev=6bfa1dc46137

https://hg.mozilla.org/integration/mozilla-inbound/rev/cb2ccaf0b894

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/cb2ccaf0b894

Comment 11

[Brian Nicholson (:bnicholson)]

Argh, I got this bug mixed up with bug 828349, so this one isn't fixed yet.

Comment 12

[Brian Nicholson (:bnicholson)]

To clarify, I accidentally landed the patch for bug 828349 with this bug number.

Comment 9 should still hold true - pushing to try to verify that the correct patch works fine: https://tbpl.mozilla.org/?tree=Try&rev=90483b71e5b4

Comment 13

[Brian Nicholson (:bnicholson)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/dc86bd63b953

Comment 14

[Brian Nicholson (:bnicholson)]

Comment on attachment 714171 [details] [diff] [review]
Switch to correct tab when a tab is closed

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 582244 (pb)
User impact if declined: closing a normal tab can switch to a private tab, which has possible privacy implications
Testing completed (on m-c, etc.): m-i
Risk to taking this patch (and alternatives if risky): low risk
String or UUID changes made by this patch: none

Comment 16

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/dc86bd63b953

Comment 17

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 714171 [details] [diff] [review]
Switch to correct tab when a tab is closed

low risk and easy to verify - approving for uplift.

Comment 18

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/8f2e4b594cd8
https://hg.mozilla.org/releases/mozilla-beta/rev/6de22de62acc