835902 - [B2G][Settings] Date & Time: February is showing up as March in the drop down when changing the date.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Darren]

Repro Steps:
1. Load the Unagi build 20130125070201.
2. Open the Settings app.
3. Select "Date & Time" under the "Personalization" section.
4. Turn off "Set Automatically".
5. Click on Date.

Actual Results:
February is named March.

Expected Results:
There will only be One of each month name.

Notes:
Build ID: 20130125070201
Kernel: Dec 5

Repro rate-
3/3 times on 2 devices

Comment 1

[Darren]

Build ID: 20130125070201
Gecko:  http://hg.mozilla.org/releases/mozilla-b2g18/rev/94a2d6fcdfde
Gaia:   6369dbf33b622faf4b4d176fed30b77c5c319dfc

Comment 2

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

This is a bug that we overflowed a Date() object with "2/29", "2/30", so it proceeded to "March".

** Triage **
This is a general bug for date picker, so I think we should fix this.

Comment 3

[Lukas Blakk [:lsblakk] use ?needinfo]

Marking status-b2g18 and status-b2g18-v1.0.0 as affected, please update the status to fixed once this is verified landed on v1-train/mozilla-b2g18 and v1.0.0/mozilla-b2g18_v_1_0_0

Comment 4

[Misty Byrd]

Smoke Test Regression
Build 20130130070201
gaia: f7f5a0cd17e3d04308cc5850b254947e127122b9
gecko:066b9d7cf30884a001db22bde3ae939c02718062
Dec 5th kernel ,pmem_adsp_size=13631488
This issue also repros when selecting the date to add a calendar event
Repro frequency :
 5/5 times on 2/2 devices

Comment 5

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

(In reply to Rudy Lu [:rudyl] from comment #2)
> This is a bug that we overflowed a Date() object with "2/29", "2/30", so it
> proceeded to "March".
> 
> ** Triage **
> This is a general bug for date picker, so I think we should fix this.

(drive-by comment): We should also consider leap years properly - 2012, 2016 will have Feb 29 and we should be careful to test that those edge cases work correctly too.

Comment 6

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

(how to determine a leap year, from Wikipedia: http://en.wikipedia.org/wiki/Leap_year#Algorithm )

Comment 7

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/7925

Pointer to Github pull-request

Comment 8

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 708971 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/7925

Hi Tim,

Please help review the changes first.
Now, I am trying to write unit test for this patch.

Thank you.

Comment 9

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 708971 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/7925

r=me, given the fact that spin_date_picker.js is a 200+ line module pattern function, let not block on unit test for the fix.

Please file a follow up bug for the complete spin_date_picker unit tests, and (maybe) refactor.

Comment 10

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Merged to Gaia master,
https://github.com/mozilla-b2g/gaia/commit/82b47138452f636f937d40e8167c93f9336da773

Dear Tim,

Thanks for the review.

Bug 837082 created as a follow-up to add unit test for the date picker.

Comment 12

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Set this as fixed.
Please help uplift this to v1.0.0 since this is tef+ or let me know if you need me to do that.

Thanks.

Comment 13

[John Ford [:jhford] CET/CEST Berlin Time]

v1-train: 8de96e7d518ac0ad11c0d4889f6f52a79d4896d8
v1.0.0: 73ddf9763a3070f08963b28e3d97b6d18769459b

Comment 15

[Misty Byrd]

Smoke Test Regression
Unagi build#20130207070202

Gecko  cf1b9d27345e70daf242514733f848e76241ea1d

Gaia   7e54ca673277b20b1d91d18477dc44d6ad226761

Dec 5th kernel 
This issue also repros when selecting the date to add a calendar event
Repro frequency :
 5/5 times on 2/2 devices

Comment 16

[Allen Maxwell]

In comment 13 this bug was duped to bug 837259. Bug 837259, comment 3 duping it back to this one.

Comment 17

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Dear Misty,

Hi, I've tried the build you said but could not reproduce this issue.
Unagi build#20130207070202

Gecko  cf1b9d27345e70daf242514733f848e76241ea1d

Gaia   7e54ca673277b20b1d91d18477dc44d6ad226761

I also double confirmed this build should have included the patch for this issue.

Could you please help verify this issue again or provide the repro steps in more detail?

Thanks.

Comment 18

[Tim Guan-tin Chien [:timdream] (please needinfo)]

(In reply to Rudy Lu [:rudyl] - (AFK 2/9 - 2/17) from comment #17)
> Dear Misty,
> 
> Hi, I've tried the build you said but could not reproduce this issue.
> Unagi build#20130207070202
> 
> Gecko  cf1b9d27345e70daf242514733f848e76241ea1d
> 
> Gaia   7e54ca673277b20b1d91d18477dc44d6ad226761
> 
> I also double confirmed this build should have included the patch for this
> issue.
> 
> Could you please help verify this issue again or provide the repro steps in
> more detail?
> 
> Thanks.

Maybe the calendar app is using a re-implementation of the value selector and suffers the same bug? How about Clock app?

Comment 19

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

(In reply to Tim Guan-tin Chien [:timdream] (MoCo-TPE) from comment #18)
> 
> Maybe the calendar app is using a re-implementation of the value selector
> and suffers the same bug? How about Clock app?

I think Calendar is using the System Value Selector by using <input> element.
As of Clock app, I think it only implements the time picker itself, and doesn't include the date picker.

Thanks.

Comment 22

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Close this issue for QA to verify it again.
Thanks.

Comment 23

[Michael Vines [:m1] [:evilmachines]]

I see this issue still occurring on v1.0.1 even though it seems like the patch in this bug has landed there.  Re-opening so we can sort this out.

Comment 24

[Michael Vines [:m1] [:evilmachines]]

(oops, restoring ni?)

Comment 25

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Sorry that I still could not reproduce this, even with the latest HEAD of Gaia v1.0.1 branch.
 - Gaia v1.0.1 branch: 5691a16fff8e1403c75ed9d6f3a443b7e58198c6 

Could someone provide the build he/she used to reproduce this issue and the steps in detail?
Thank you.

Comment 26

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

I also tried the following pvtbuild but still could not reproduce.

https://pvtbuilds.mozilla.org/pub/mozilla.org/b2g/nightly/mozilla-b2g18_v1_0_1-unagi/2013/02/2013-02-22-07-02-01/

Comment 27

[Michael Vines [:m1] [:evilmachines]]

Sorry, I'm smoking crack again.  WFM in a clean environment.

Comment 28

[Natalya Kot [:nkot]]

(In reply to Rudy Lu [:rudyl] from comment #26)
> I also tried the following pvtbuild but still could not reproduce.
> 
> https://pvtbuilds.mozilla.org/pub/mozilla.org/b2g/nightly/mozilla-
> b2g18_v1_0_1-unagi/2013/02/2013-02-22-07-02-01/

repros for me

Unagi build ID: 2013-02-22-070201
Gecko: 9df4d6efd664
Gaia: 5691a16fff8e1403c75ed9d6f3a443b7e58198c6

2 ways to repro

I: Repro steps:
1) Open Calendar app
2) Tap "+" to create a new event
3) Tap the date field to bring up "Select day" drop down menu

II. Repro steps:
1) Open Settings app
2) Select Date and Time
3) Uncheck "Set automatically" (if it was checked)
4) Tap the date under "Set manually" section

Comment 29

[Justin Dolske [:Dolske]]

The battery in my phone died, and after recharging and updating I'm seeing this too.

"Build Identifier" is 20130219070200
"Git commit info" is 2013-02-18 4:25:50, edaca00b1...

Comment 30

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Hi all,

I am really confused since this issue is repeatedly reopened and marked as resolved (Comment 27).

Not sure if this is caused by something went wrong after updating.

Hi Justin,

Could you please try to reproduce this with a clean build without updating?
Thank you.

Comment 31

[Justin Dolske [:Dolske]]

I don't know how to do that. I'm using the Turkcell dogfooding phone.

Comment 32

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Going to mark this as qawanted, since I have tried several times on different builds but I could not see this reproduced after landing.

Thanks.

Comment 33

[Chris Kreinbring [:CKreinbring]]

Attachment: Screenshot of February as March

Comment 34

[Andrew Overholt [:overholt]]

I just verified with Sotaro that his local build from m-i including the patch in the pull request above still exhibits this problem.

Calendar > new event > date picker > double March

Comment 35

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/8349

Pointer to Github pull-request

Comment 36

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 718886 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/8349

This issue depends on timezone setting.
So it could be reproduced with the timezone is set as "UTC -08:00", e.g. in Mountain View, but not when it is "UTC+08".

[Root Cause]
We used "new Date(0)" to init a date object, which will be Jan. 1, 1970 00:00:00 in **UTC** time.
So when the timezone is set as "UTC -08:00", actually it represents:
  Date {Wed Dec 31 1969 16:00:00 GMT-0800 (PST)}

So this will make this happen again.
(Because we will use this date object to change its month value, and there is not Feb. 31...)

[Solution]
Use "new Date(1970, 0, 1)", which will always return Jan. 1, 1970 in local time.

--
Sorry that I did not notice time zone setting makes the difference.
Thanks to all for your help on checking this issue.

Comment 37

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 718886 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/8349

ah, my bad, r+

Comment 38

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Gaia master:
https://github.com/mozilla-b2g/gaia/commit/e1771e699d2c28f493845eceaab901c19a945173

v1-train:
https://github.com/mozilla-b2g/gaia/commit/f254d5b2af84cb680e60c4b747658f4cdf25c2b2

v1.0.1:
https://github.com/mozilla-b2g/gaia/commit/26b20494ef6b443250a94bc5a4e961777ab7592c

--
Tim, thanks for the review.
:schien, Al, thanks for your help to investigate/repro this issue.

Comment 39

[Al Tsai [:atsai]]

Verified w/ v1.0.1 nightly build.