835930 - B2G mochitests should use mozprofile for profile creation and management

Status: RESOLVED FIXED

(Testing :: Mochitest, defect)

Comment 1

[Andrew Halberstadt [:ahal]]

Attachment: WIP

Just wanted to get this attached. It is still untested and depends on bug 837719 landing first.

Comment 2

[Andrew Halberstadt [:ahal]]

Attachment: Patch 1.0 - b2g mochitests with mozprofile

I don't think this is perfect, but I think it's a step down the right path. This is blocked on bug 851292 landing, but I figured we can get started on the review process in the meantime.

This patch also gets the ball rolling on bug 830430. These bugs were so interrelated that I decided to just start them in the same patch.

Comment 3

[Jonathan Griffin (:jgriffin)]

Comment on attachment 725500 [details] [diff] [review]
Patch 1.0 - b2g mochitests with mozprofile

Review of attachment 725500 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/mochitest/runtestsb2g.py
@@ +556,5 @@
>                              os.path.join(bundlesDir, filename))
>  
>          return retVal
>  
>      def buildProfile(self, options):

It looks like the two versions of buildProfile are now identical; if so, the implementation should be moved to B2GMixin to avoid duplicating code.

::: testing/profiles/Makefile.in
@@ +8,5 @@
> +VPATH = @srcdir@
> +
> +include $(DEPTH)/config/autoconf.mk
> +
> +MODULE = testing_profiles

MODULE not needed afaict; see https://developer.mozilla.org/en-US/docs/MODULE

@@ +12,5 @@
> +MODULE = testing_profiles
> +
> +include $(topsrcdir)/config/rules.mk
> +
> +MOCHITEST_PROFILE_FILES = \

Are these really mochitest-specific, or are they generic enough to let us label these as UNITTEST_PROFILE_FILES or something?

Comment 4

[Andrew Halberstadt [:ahal]]

Attachment: Patch 1.1 - address nits and add option to specify profile data directory

This patch addresses the nits, but it ended up being big enough that I'm not comfortable checking it in without another review. In addition to the nits I added a command line option to specify a custom profile data directory to make running locally a little bit easier.

Comment 5

[Jonathan Griffin (:jgriffin)]

Comment on attachment 729744 [details] [diff] [review]
Patch 1.1 - address nits and add option to specify profile data directory

Review of attachment 729744 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/mochitest/runtestsb2g.py
@@ +28,5 @@
>  
>  from mozdevice import DeviceManagerADB, DMError
>  from mozprofile import Profile, Preferences
>  
> +class B2GMochitestMixin(Mochitest):

We should probably rename this to something like B2GMochitestBase, since we're not using it in a typical mixin, multiple-inheritance way any longer ... we're not mixing it in, just implementing a straight inheritance chain with it.

Or we could name this B2GMochitest and rename what is now B2GMochitest to B2GDeviceMochitest, which is probably even better.

@@ +332,5 @@
>      _dm = None
>  
>      def __init__(self, automation, devmgr, options):
>          self._automation = automation
>          Mochitest.__init__(self, self._automation)

We should call Mochitest.__init__ from within B2GMochitestMixin, since we're just doing straight inheritance again.

@@ +536,2 @@
>          #self._automation = automation
>          Mochitest.__init__(self, automation)

We should call Mochitest.__init__ from within B2GMochitestMixin, since we're just doing straight inheritance again.

Comment 6

[Andrew Halberstadt [:ahal]]

Try run looks good:
https://tbpl.mozilla.org/?tree=Try&rev=ba54a70f9f44&showall=1

Pushed to inbound:
https://hg.mozilla.org/integration/mozilla-inbound/rev/947b9aa5e2d3

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/947b9aa5e2d3

Comment 8

[Martijn Wargers (dead)]

I'm getting this error while trying to run b2g mochitests (after updating my build):
Traceback (most recent call last):
  File "runtestsb2g.py", line 30, in <module>
    from mozprofile import Profile, Preferences
ImportError: cannot import name Preferences

Anyone knows why I get this problem?

Comment 9

[Andrew Halberstadt [:ahal]]

You probably have an outdated version of mozprofile in your python packages (current is 0.6). Try upgrading it or installing the latest mozbase in a new virtualenv.

Comment 10

[Martijn Wargers (dead)]

Thanks, that was the problem. sudo pip install --upgrade mozprofile solved it.

Comment 11

[Martijn Wargers (dead)]

Now I'm getting a black emulator window with this message in the console:
"unable to execute 'cp' on device; consider installing busybox from Android Market"
This is after updating my tree and rebuilding.

Comment 12

[Jonathan Griffin (:jgriffin)]

The emulator build is currently broken; bug 858853