836023 - Click events on desktop homescreen are ignored

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

When using b2g-18 with gaia v1-train on desktop, click events on the homescreen are ignored.  I can click through the first-time-experience pages, but on the homescreen, clicking browser, contacts, etc., does nothing.

Git bisect seems to indicate that the problem began with this commit:
https://github.com/mozilla-b2g/gaia/commit/8d780363

I filed this issue for gaia:
https://github.com/mozilla-b2g/gaia/issues/7854

Comment 1

[Cristian Rodriguez (:crdlc)]

We are using touch events in the homescreen right now. Should we support mouse and touch events at the same time in code? should the emulator support touch events?

Comment 2

[Francisco Jordano [:arcturus] [:francisco]]

Hi all,

Unfortunately I don't think the emulator is going to support touch events soon.

The change that Cristian introduced was needed for the new developer phones, so I'll suggest we introduce the changes needed to support both, the phones with touch events and emulator with the mouse events.

Cheers!
F.

Comment 3

[Cristian Rodriguez (:crdlc)]

Attachment: Fixed hs on emulator

Comment 4

[Cristian Rodriguez (:crdlc)]

asking for tracking-b2g18 due to homescreen broken on b2g desktop emulator

Comment 5

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 708118 [details]
Fixed hs on emulator

Tried in both the emulator and the phone and works perfectly.

Thanks Cristian

Comment 6

[Julien Wajsberg [:julienw]]

Comment on attachment 708118 [details]
Fixed hs on emulator

NOTE: If blocking-basecamp+ is set, just land it for now.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Bug 831656
User impact if declined: homescreen doesn't work in b2g-desktop
Testing completed: yes
Risk to taking this patch (and alternatives if risky): low

Comment 7

[Cristian Rodriguez (:crdlc)]

https://github.com/mozilla-b2g/gaia/commit/3b48c3b5139f304355187f7750ba779a358c28a9

Comment 8

[John Ford [:jhford] CET/CEST Berlin Time]

The patch for this bug does not apply cleanly to v1-train.  Could you please
land this patch there?

git checkout v1-train
git cherry-pick -m 1 3b48c3b

Doing this will cause the merge conflict.

Comment 9

[Cristian Rodriguez (:crdlc)]

I don't know how to do this because it is my first time. I create a new branch from v1-train, after that, git cherry-pick -m 1 3b48c3b, fixed the conflict and push to my repo. 

https://github.com/mozilla-b2g/gaia/pull/7923

ok?

Comment 11

[John Ford [:jhford] CET/CEST Berlin Time]

This was uplifted to v1-train but was not marked as fixed for b2g18.

Comment 13

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

We need to back this patch out for causing bug 837931.

jhford, reverting a cherry-picked merge commit kinda gives me the willies.  Do you know the right way to back this out?

Comment 14

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Looks like bug 837601 has the fix for bug 837931.

Guys, we *absolutely* must test on device.  These kinds of regressions are killer :(.

Comment 15

[Cristian Rodriguez (:crdlc)]

I cannot reproduce, could we close this bug?

Comment 16

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

(In reply to crdlc from comment #15)
> I cannot reproduce, could we close this bug?

Thanks for your help, crdlc,

It was working well on desktop for me; I'll pull and build for unagi now just to double-check everything.

Chris, does everything seem ok to you?
Thanks,
j

Comment 17

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

I haven't seen issues with touch events since the fix, if that's the question to me.

Comment 18

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

It works for me on desktop. I'm having trouble flashing my phone with my latest build, but if you're all good with device, let's close this.

Comment 19

[Lukas Blakk [:lsblakk] use ?needinfo]

Batch edit: bugs fixed on b2g18 since 1/25 branch of v1.0 are fixed on v1.0.1