836201 - [FM Radio] Music is not playing while FM is playing in background

Status: VERIFIED WORKSFORME

(Firefox OS Graveyard :: Gaia::FMRadio, defect)

Description

[Leo]

1. Title : FM is playing in background by pressing HOME key. In this case, when Music app is invoke and select any file to play, it is not playing. 
2. Precondition : at least a music file is needed in device 
3. Tester's Action : (1). Open FM Radio -> play any channel -> 
                     (2). Press HOME key -> open MUSIC application -> 
                     (3). Open any file to play -> it is not playing  
4. Detailed Symptom (ENG.) : while FM is running in background, and MUSIC file is open, It is not playing. On pause of MUSIC, FM start playing. 
5. Gaia Revision #:  "7b8dea7e7ec377a2143151bbe5e9998d87f7b36d"
6. Expected : When Music is invoke, while FM is playing in background. Fm should pause and Music should start get playing. It should be vice versa. 
7.Reproducibility: Y
  1)Frequency Rate : 100%
8.Comparison Results : 
  1)Model Comparing : 
9. Attached files: 
   1)Log : 
   2)Test Contents : 
   3)Video file :

Comment 1

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

I think there has been some adjustments to how the behavior is occurring.  I'm seeing different behavior with:

Gecko  http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_0/rev/361d9359f4f3
Gaia   0abc95774d0bbdfe314fa588e09fc92cac3e6427
BuildID 20130130113326
Version 18.0
Unagi

see bug 834529.

Can you also list which Gecko version you are using?
v1.0.0 and master are two different branches now as well.  

I would highly recommend looking at the v1.0.0 for Gecko 18 and gaia.

Comment 2

[Dietrich Ayala (:dietrich)]

The use case for this is very narrow - the user is already listening to music.

This is a bug, but it should not block the 1.1 release, I think.

Comment 3

[Leo]

bug still exist in latest verison,
Gaia: 6916e18d1f72936e892543cf4a104a7d457f78ad
Gecko: e4a677c13bf35253fea99e6b85df1c707038d119

Comment 4

[Dietrich Ayala (:dietrich)]

Minus for now - extremely uncommon use-case with no basic applicability for users.

Comment 5

[Casey Yee]

(In reply to leo.bugzilla.gaia from comment #0)
> 6. Expected : When Music is invoke, while FM is playing in background. Fm
> should pause and Music should start get playing. It should be vice versa. 

This expected behavior is correct.  To be a little more detailed about the intended UX:


With FM radio in the background playing audio.  If the user starts the music app and starts playing music, FM radio should pause.  The radio should remained paused until the user returns to the FM radio and presses play again.

This vice-versa should also be true.   With Music playing in background.  If the user starts listening to FM radio, the music should be stopped.  The music should remained paused until the user returns to music app and presses play again.

Comment 6

[William Hsu [:whsu]]

Hi, Naoki-san, Casey, and all

Sorry to jump in.
As I tested this case, most of behaviors are same as Casey described.
But while I returns to the FM radio or Music App, the FM radio or Music app will play again without pressing Play button.
Do you think the behavior was reasonable?
If so, I didn't have further problem.

The following are my test environment.
* Hardware: unagi
* Firefox OS: mozilla-b2g18_v1_0_1-unagi-eng (2013-03-10-07-02-03)
* Mercurial-Information:
  Gecko revision="a0eb57759a92"
  Gaia revision="72a2e37d17f6"
* Git:
  Gecko revision="f42cd79f6036df3f102fcdb59ff1ab6944305000"
  Gaia revision="b4d644dd5ea79070479a9aa1b57e2e05a6442eee"

Thanks!


Best Regards,
William

Comment 7

[Joe Cheng [:jcheng] (please needinfo)]

triage: leo+ as the music will not play and user have no indication that they need to stop FM radio.
and needinfo from reporter for updated issue description.

Comment 8

[Marco Chen [:mchen]]

It seems that bug 850594 is duplicated with this one.

https://bugzilla.mozilla.org/show_bug.cgi?id=850594#c1

Comment 9

[Leo]

adding to comment 5,

1. While playing FM, and if the user tries to play Music , there is no sound played out of the device.
2. Both FM and Music doesn't play.
3. Expected : FM should be stopped and Music has to be played out.
4. Currently, What is happening: FM gets stopped, but Music continues to play without any sound.

Comment 10

[Marco Chen [:mchen]]

(In reply to leo.bugzilla.gaia from comment #9)
> adding to comment 5,
> 
> 1. While playing FM, and if the user tries to play Music , there is no sound
> played out of the device.
> 2. Both FM and Music doesn't play.
> 3. Expected : FM should be stopped and Music has to be played out.
> 4. Currently, What is happening: FM gets stopped, but Music continues to
> play without any sound.

Hi Leo,

In our implemetation now, FM is muted not stopped on point 4. May I confirm this in your own build?

Comment 11

[Marco Chen [:mchen]]

Attachment: Version 1

The original design when audio channel paused is
  a. Set level of FM Audio Stream to 0 (mute)
  b. Keep AUDIO_DEVICE_OUT_FM be set in Audio HAL.

The issue is that some device models can't mix audio stream between FM (external chip) and system audio (app processor) so when FM is paused the AUDIO_DEVICE_OUT_FM should be removed too then AudioPolicyManager will take the appropriate routing path.

So in this patch we do steps as below when paused and vice versa in resumed
  a. Set level of FM Audio Stream to 0 (mute)
  b. Remove AUDIO_DEVICE_OUT_FM be set in Audio HAL.

Comment 12

[Leo]

Adding the Comment no. 10
Yes, you are correct. FM is getting paused not gets stopped.
After following the reproduce step, minimized the MUSIC app and open the paused FM app. FM audio started getting played out from previous paused Frequency condition.

Comment 14

[bhavana bajaj [:bajaj]]

Passing this on to :mchen as it looks like he has a patch up on this.Please reassign if needed.

Comment 15

[leo.bugzilla.gecko]

Hi Macro chen.
I will update you audio priority as regards FM device output in AudioHardware.cpp.
We will inform history of modified case as a reference.

[changed]
Headset & Speaker path have priority over FM path.

[Case]
FM Path only use headset, Ring/Notification/Camera shutter/Alarm should be output by headset/speaker.
So, You can concurrently listen to ring/notification/camera shutter/alarm during turnning on fm radio by this mofied case.
But, FM Radio <-> Music case should turn off fm radio becase of using headset only. 

We are predicted to resolve FM Radio<->Music by the below case
a. Set level of FM Audio Stream to 0 (mute)
b. Remove AUDIO_DEVICE_OUT_FM be set in Audio HAL.

Comment 16

[Marco Chen [:mchen]]

> We are predicted to resolve FM Radio<->Music by the below case
> a. Set level of FM Audio Stream to 0 (mute)
> b. Remove AUDIO_DEVICE_OUT_FM be set in Audio HAL.

Yes, that is what I done in the patch waiting for review.

Comment 18

[Justin Lebar (not reading bugmail)]

Comment on attachment 731819 [details] [diff] [review]
Version 1

I'm sorry I took so long to get to this review.  It looks good to me, although I wish the API with the audio channel was cleaner.

Comment 19

[Marco Chen [:mchen]]

Attachment: Version 2

Hi Justin,

After doing more tests, the patch will cause a issue on enabling FMRadio in the background by inserting headset and there is a Music app in foregound on playing.

The reason is that in FMRadio::Enable(), 
  1. the calling of .StartPlaying() will cause .CanPlayChanged(false) be callbacked then .CanPlayChanged(false) will try to set routing path back to headset only and set mAudioChannelPaused to true. 
  2. then calling of audioManager->SetFmRadioAudioEnabled(true) set routing path back to FM again.
  3. then calling of .CanPlayChanged(false) in the end of FMRadio::Enable() is blocked by the checking of mAudioChannelPaused.

In content process it is asynchronous between .StartPlaying() & .CanPlayChanged() but it is synchronous in chrome process.

So I removed mAudioChannelPaused and replace by checking routing path in .CanPlayChanged().

Thanks.

Comment 20

[Justin Lebar (not reading bugmail)]

Comment on attachment 736188 [details] [diff] [review]
Version 2

Thanks for the explanation!

Comment 21

[Marco Chen [:mchen]]

https://tbpl.mozilla.org/?tree=Try&rev=c56ae1255502

Comment 22

[Marco Chen [:mchen]]

Attachment: Patch checkin-version

Pass the try server and add reviewer name.

Comment 23

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/projects/birch/rev/1df2ac13348f

Comment 24

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/1df2ac13348f

Comment 25

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/5eb76dd7c2a4

Comment 26

[Joe Cheng [:jcheng] (please needinfo)]

per bug 860586 comment 6, this bug will fix bug 860586, a tef+ bug. nominating this for tef+

Comment 27

[Dietrich Ayala (:dietrich)]

Triage says tef+, to fix both issues.

Comment 28

[Marco Chen [:mchen]]

Hi sheriff,

There is no addtional patch here and please just apply the one here into 1.0.1.

Thanks.

Comment 29

[Randy Lin [:rlin] - Be Mozillian on 2015/01/26]

Hi Ryan. 
Could you help to check-in this on v1.01 ?

Comment 30

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/2df1a7b1c342

Comment 31

[bov]

Tested with Build:
unagi-ICS.user.manifest.V1.0.1.Rel0.4.Sprint8.B-114.Gecko-ea6a890.Gaia-b750757
Tester's Action : 
(1). Open FM Radio -> play any channel -> 
(2). Press HOME key -> open MUSIC application -> 
(3). Open any file to play -> It plays  
(4). Press HOME key -> open FM RADIO application -> It continues playing in the same radio station