Closed Bug 836621 Opened 11 years ago Closed 11 years ago

Remote debugging (and hence ADB) should be enabled by default for eng builds

Categories

(Firefox OS Graveyard :: Gaia::Settings, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(blocking-b2g:tef+, b2g18 fixed, b2g18-v1.0.0 fixed)

VERIFIED FIXED
blocking-b2g tef+
Tracking Status
b2g18 --- fixed
b2g18-v1.0.0 --- fixed

People

(Reporter: dhylands, Assigned: dhylands)

References

Details

Attachments

(1 file)

Bug 836103 causes remote debugging (and hence ADB) to be off by default. This is desirable for VARIANT=user builds, but we should probably enable it by default for eng and userdebug builds.

This probably impacts the automation/test group, and developers will appreciate having it enabled by default for eng builds.
Adds --enable-debugger option which in turn controls the remote debugging/ADB option.

Add --enable-debugger for non-user builds

Fix --noftu parsing to not consume the next argument
Nominating for tef? since this bug should have really gone along with bug 836103
blocking-b2g: --- → tef?
Attachment #708464 - Flags: review+
Thanks!
Can we land this on gaia v1.0.0 right away? tef+, as this bug completely blows us away.  If it doesn't land in a couple hours on v1.0.0 we will land it here anyway
This patch should have landed with bug 836103 with is tef+. I will approve it since it is part of the tef+ bug imho.
Resolution: FIXED → DUPLICATE
Umm - I don't think this is a duplicate. It has a separate patch which needs to be applied in addition to the one in bug 836103.

Marking as FIXED.
Resolution: DUPLICATE → FIXED
blocking-b2g: tef? → tef+
v1-train: b91a6c29c382e6f97c7caf5edeb1455158ba8ba4
v1.0.0: 79d0073bfd8dd9210e5972eec679e1e322235792
(In reply to Dave Hylands [:dhylands] from comment #8)
> Umm - I don't think this is a duplicate. It has a separate patch which needs
> to be applied in addition to the one in bug 836103.
> 
> Marking as FIXED.

Sorry I have no clue why I resolved it as a duplicate...
Assignee: nobody → dhylands
Depends on: 836973
Verified FIXED; our builds are working fine again with this fix, thanks!
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: