Closed
Bug 836973
Opened 12 years ago
Closed 12 years ago
Marionette actor not getting connected to debugger
Categories
(Remote Protocol :: Marionette, defect)
Remote Protocol
Marionette
Tracking
(blocking-b2g:tef+, firefox19 wontfix, firefox20 wontfix, firefox21 fixed, b2g18 fixed, b2g18-v1.0.0 fixed, b2g18-v1.0.1 fixed)
People
(Reporter: jgriffin, Assigned: dhylands)
References
Details
(Keywords: dev-doc-needed)
Attachments
(1 file)
1.59 KB,
patch
|
fabrice
:
review+
|
Details | Diff | Splinter Review |
There's some problem which is causing the Marionette actor not to get connected to the debugger. Attempting to send any Marionette message results in:
response {u'message': u'Actor "conn4.1" does not recognize the packet type "getMarionetteID"', u'from': u'root', u'error': u'unrecognizedPacketType'}
There have been no recent changes to Marionette or the debugger that would explain this. In addition, we only see this error on tests running on unagis and pandas.
Reporter | ||
Comment 1•12 years ago
|
||
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → dhylands
Assignee | ||
Comment 2•12 years ago
|
||
I'm going to propose that if MARIONETTE is enabled, then adb will be always enabled, and disconnected from the remote-debugger setting.
The crux of the problem is that marionette wants adb on, but the remote debugger off.
What this means is that the remote debugger will always default to being off (so more or less reversing the gaia change mentioned in comment 1).
For non-user builds adb will always be on.
For user builds adb will be coupled to the remote debugger setting.
Assignee | ||
Comment 3•12 years ago
|
||
Nominating for tef? since this blocks bug 836621. Our partners run marionette tests, so they'll need/want this.
Blocks: 836621
blocking-b2g: --- → tef?
Comment 4•12 years ago
|
||
We do automated testing on -userdebug fyi.
Assignee | ||
Updated•12 years ago
|
Assignee | ||
Comment 5•12 years ago
|
||
This forces adb to be on when marionette is enabled (marionette requires that the remote-debugger be disabled).
Attachment #708903 -
Flags: review?(fabrice)
Updated•12 years ago
|
Attachment #708903 -
Flags: review?(fabrice) → review+
Assignee | ||
Comment 6•12 years ago
|
||
Comment 7•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
Comment 8•12 years ago
|
||
Blocks another tef+ blocker.
Comment 9•12 years ago
|
||
https://hg.mozilla.org/releases/mozilla-b2g18/rev/c6ef8bcf0b8d
https://hg.mozilla.org/releases/mozilla-b2g18_v1_0_0/rev/b21f703f1db1
Assignee | ||
Comment 10•12 years ago
|
||
dev-doc-needed is to document the fact that adb is always on for non-user builds (i.e. eng and userdebug) and for user (i.e. production/dogfooding) builds adb is controlled via the remote- debugger setting.
Keywords: dev-doc-needed
Verified FIXED; our builds are back and running fine with the fix, thanks!
Status: RESOLVED → VERIFIED
Updated•12 years ago
|
status-b2g18-v1.0.1:
--- → fixed
Updated•2 years ago
|
Product: Testing → Remote Protocol
You need to log in
before you can comment on or make changes to this bug.
Description
•