836973 - Marionette actor not getting connected to debugger

Status: VERIFIED FIXED

(Remote Protocol :: Marionette, defect)

Description

[Jonathan Griffin (:jgriffin)]

There's some problem which is causing the Marionette actor not to get connected to the debugger.  Attempting to send any Marionette message results in:

response {u'message': u'Actor "conn4.1" does not recognize the packet type "getMarionetteID"', u'from': u'root', u'error': u'unrecognizedPacketType'}

There have been no recent changes to Marionette or the debugger that would explain this.  In addition, we only see this error on tests running on unagis and pandas.

Comment 1

[Jonathan Griffin (:jgriffin)]

caused by: https://github.com/mozilla-b2g/gaia/commit/a86c204de00a83fede1c1ff7b4169da72c489af5

Comment 2

[Dave Hylands [:dhylands]]

I'm going to propose that if MARIONETTE is enabled, then adb will be always enabled, and disconnected from the remote-debugger setting.

The crux of the problem is that marionette wants adb on, but the remote debugger off.

What this means is that the remote debugger will always default to being off (so more or less reversing the gaia change mentioned in comment 1).

For non-user builds adb will always be on.
For user builds adb will be coupled to the remote debugger setting.

Comment 3

[Dave Hylands [:dhylands]]

Nominating for tef? since this blocks bug 836621. Our partners run marionette tests, so they'll need/want this.

Comment 4

[Michael Vines [:m1] [:evilmachines]]

We do automated testing on -userdebug fyi.

Comment 5

[Dave Hylands [:dhylands]]

Attachment: Forces adb to be on when marionette is enabled (i.e. non-user builds)

This forces adb to be on when marionette is enabled (marionette requires that the remote-debugger be disabled).

Comment 6

[Dave Hylands [:dhylands]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c46098d2964c

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c46098d2964c

Comment 8

[Lukas Blakk [:lsblakk] use ?needinfo]

Blocks another tef+ blocker.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/c6ef8bcf0b8d
https://hg.mozilla.org/releases/mozilla-b2g18_v1_0_0/rev/b21f703f1db1

Comment 10

[Dave Hylands [:dhylands]]

dev-doc-needed is to document the fact that adb is always on for non-user builds (i.e. eng and userdebug) and for user (i.e. production/dogfooding) builds adb is controlled via the remote- debugger setting.

Comment 11

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED; our builds are back and running fine with the fix, thanks!