837022 - Run xpcshell tests on Ubuntu

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P3)

Comment 1

[Rail Aliiev [:rail]]

It's orange on build-system (old style unittests) and green on cedar (mozharness based). Hmmm....

Comment 2

[Phil Ringnalda (:philor)]

It's deceptively green on Cedar: "TEST-INFO | skipping /builds/slave/test/build/tests/xpcshell/tests/netwerk/test/unit/test_spdy.js | run-if: hasNode"

Comment 3

[Rail Aliiev [:rail]]

Oooh, thanks philor.

aki, looks like mozharness is missing MOZ_NODE_PATH env variable from http://hg.mozilla.org/build/buildbotcustom/file/51bbb7dd3349/env.py#l80

Comment 4

[Aki Sasaki (not active)]

(In reply to Rail Aliiev [:rail] from comment #3)
> Oooh, thanks philor.
> 
> aki, looks like mozharness is missing MOZ_NODE_PATH env variable from
> http://hg.mozilla.org/build/buildbotcustom/file/51bbb7dd3349/env.py#l80

After investigating, I don't think we use that.

We use pf.get('unittest-env'):
http://hg.mozilla.org/build/buildbotcustom/file/51bbb7dd3349/misc.py#l551
which is only DISPLAY:
http://hg.mozilla.org/build/buildbot-configs/file/843cf98d9175/mozilla-tests/config.py#l368

The only thing I can see using linux-unittest is
http://hg.mozilla.org/build/buildbotcustom/file/51bbb7dd3349/misc.py#l2266
which is generateFuzzingObjects().

Comment 5

[Rail Aliiev [:rail]]

Hmm, https://tbpl.mozilla.org/php/getParsedLog.php?id=19642042&tree=Build-System&full=1 tell that MOZ_NODE_PATH does exist, what triggers SPDY tests (iirc)...

Comment 6

[Aki Sasaki (not active)]

I found http://hg.mozilla.org/build/buildbotcustom/file/51bbb7dd3349/misc.py#l568, but that only sets linux-perf afaict, not linux-unittest.
linux-perf doesn't have NODE.

Still investigating.  This affects bug 793022 so is high priority for me.

Comment 7

[Aki Sasaki (not active)]

Attachment: (custom) mozharness env

This patch:

a) sets ScriptFactory's env to an 'env' in the mozharness_suite_config if there, for mozharness desktop unittests
b) sets ScriptFactory's env to MozillaEnvironments[platform_config['env_name']] for mozharness desktop Talos.  (this is generally PLATFORM-perf)
c) sets the mozharness_suite_config's env to MozillaEnvironments(PLATFORM-unittest) and updates it with pf['unittest_env'] if it exists.

I had to add a .get() to the MozillaEnvironments call, or the test-masters run would die on ics_armv7_b2g.

I need to do a staging test run for bug 840309, so I should see this working on win32, at least.

Comment 8

[Rail Aliiev [:rail]]

Comment on attachment 712730 [details] [diff] [review]
(custom) mozharness env

Review of attachment 712730 [details] [diff] [review]:
-----------------------------------------------------------------

::: misc.py
@@ +1895,5 @@
>                          'slavebuilddir': slavebuilddir,
>                          'factory': factory,
>                          'category': branch,
>                          'properties': properties,
> +                        "env": MozillaEnvironments[platform_config['env_name']],

A nit. Can you use single quotes for consistency?

Comment 9

[Aki Sasaki (not active)]

Comment on attachment 712730 [details] [diff] [review]
(custom) mozharness env

I see the updated env on my latest staging win32 test run.

http://hg.mozilla.org/build/buildbotcustom/rev/d703f9167162

Comment 10

[Aki Sasaki (not active)]

This is live.

Comment 11

[Rail Aliiev [:rail]]

Attachment: Switch from Fedora to Ubuntu for xpcshell tests

nodejs update made xpcshell green, we can disable it on Fedora and use Ubuntu instead. I'd wait till Thursday to make sure that everything works.

Comment 12

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 715783 [details] [diff] [review]
Switch from Fedora to Ubuntu for xpcshell tests

Review of attachment 715783 [details] [diff] [review]:
-----------------------------------------------------------------

awesome!

Comment 13

[Rail Aliiev [:rail]]

Comment on attachment 715783 [details] [diff] [review]
Switch from Fedora to Ubuntu for xpcshell tests

http://hg.mozilla.org/build/buildbot-configs/rev/0a6aeb7381e4

Comment 15

[Rail Aliiev [:rail]]

in production