839439 - Convert HTMLAreaElement to WebIDL

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Comment 1

[Andrea Marchesini [:baku]]

Attachment: part 1 - renaming

Comment 2

[Andrea Marchesini [:baku]]

Attachment: part 2 - webidl

Comment 3

[Andrea Marchesini [:baku]]

https://tbpl.mozilla.org/?tree=Try&rev=10065ff1a4c2

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 711775 [details] [diff] [review]
part 2 - webidl

Review of attachment 711775 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm

Comment 5

[Boris Zbarsky [:bzbarsky]]

I assume SetHref never throws?

Comment 6

[Andrea Marchesini [:baku]]

not actually it can throws. We should probably do:

void SetHref(const nsAString&url, ErrorResult& rv) {
  rv = SetHref(url);
}

I'll fix this in a follow up bug.

Comment 7

[Boris Zbarsky [:bzbarsky]]

OK.  Please file the followup, mark as blocking this bug?

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7b35e4ac3824
https://hg.mozilla.org/integration/mozilla-inbound/rev/9417a5b0c452

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/7b35e4ac3824
https://hg.mozilla.org/mozilla-central/rev/9417a5b0c452