839773 - OSX: Private Browsing Window - Different behavior when switching into fullscreen, with shortcut and fullscreen button

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Mehmet]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_8_2) AppleWebKit/536.26.17 (KHTML, like Gecko) Version/6.0.2 Safari/536.26.17

Steps to reproduce:

Compare the two methods to switch into fullscreen mode in OSX:

a) Clicking on the Fullscreen Button

vs.

b) Using Shortcut SHIFT-CMD-F or CTRL-CMD-F


Actual results:

When using a) then there is not a smooth transition. The titlebar has an animation break.

When using b) then everything is nice with a smooth animation.


Expected results:

When using a) then it should be also nice and smooth.

Same problem, when you are in fullscreen with a PrivateMode Window and open a new one with SHIFT-CMD-P.

Comment 1

[(no longer active)]

This may or may not be a widget issue...

Comment 2

[Steven Michaud [:smichaud] (Retired)]

What version of Firefox are you testing?

Please try with the latest mozilla-central nightly.

Comment 3

[Mehmet]

(In reply to Steven Michaud from comment #2)
> What version of Firefox are you testing?
> 
> Please try with the latest mozilla-central nightly.

Hi Steven,

it also happens with the build from http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/latest-mozilla-central-l10n/

If you need more information, please let me know.

Comment 4

[Mehmet]

(In reply to Mehmet Sahin from comment #3)
> (In reply to Steven Michaud from comment #2)
> > What version of Firefox are you testing?
> > 
> > Please try with the latest mozilla-central nightly.
> 
> Hi Steven,
> 
> it also happens with the build from
> http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/latest-mozilla-
> central-l10n/
> 
> If you need more information, please let me know.

Here is a screencast for a download, which demonstrates the issue: http://www.file-upload.net/download-7231789/screencast.mov.html

--> First it shows the going into/out of fullscreen with the shortkey CTRL-CMD-F (No bug!!!)
--> Then it demonstrates going into/out of fullscreen by clicking on the fullscreen button (Bug!!!).

I hope this helps :-)

Thanks.

Comment 5

[Steven Michaud [:smichaud] (Retired)]

Thanks, Mehmet.  And hi, too :-)

I see the issue, and have some ideas about fixing it.  The codepaths are slightly different when you do Cmd-Shift-f and when you click the fullscreen button.  We need to make sure both paths do the right thing.

I should be able to get to this by next week ... presuming I don't have major fires to put out in the meantime.

I'll tentatively assign this to myself, at least for the time being.

Comment 6

[Mehmet]

(In reply to Steven Michaud from comment #5)
> Thanks, Mehmet.  And hi, too :-)
> 
> I see the issue, and have some ideas about fixing it.  The codepaths are
> slightly different when you do Cmd-Shift-f and when you click the fullscreen
> button.  We need to make sure both paths do the right thing.
> 
> I should be able to get to this by next week ... presuming I don't have
> major fires to put out in the meantime.
> 
> I'll tentatively assign this to myself, at least for the time being.

Thanks Steven for taking a look at this issue.

BTW: This also happens with the shortcut SHIFT-CMD-F and also, when you open a new Privat Window in fullscreen with SHIFT-CMD-P

Comment 7

[Steven Michaud [:smichaud] (Retired)]

I've finally had a chance to look at this.

I thought it was going to be simple, but it isn't.  It's not hard to make the Cocoa widgets codepaths the same for doing Cmd-Shift-f and pressing the fullscreen button -- but that's not enough to fix this issue.

Gecko must be doing some additional processing on the Cmd-Shift-f codepath, but it's not currently possible to tell what that is from Cocoa widgets code, or to have any direct control over it.  My hunch is that we'll need to redesign how Gecko handles the transition to and away from fullscreen mode, at the very least adding a new "prepare for fullscreen transition" event that can be sent from widget code.

This will probably also help with other bugs -- notably bug 740923, and possibly also bug 792304 and bug 802504.

Comment 8

[Clément Lefèvre]

This bug doesn't seem to be here anymore, please can you confirm?

Comment 9

[Mehmet]

Attachment: screencast.mov

It happens for me now in Private and Normal Mode. With both Short-Cuts.

Attached a screencast.

Comment 10

[Clément Lefèvre]

(In reply to Mehmet from comment #9)
> Created attachment 8911188 [details]
> screencast.mov
> 
> It happens for me now in Private and Normal Mode. With both Short-Cuts.
> 
> Attached a screencast.

Okay, I was essentially talking about having different behavior between shortcuts and button, which now seems fixed, do you agree?

If I understood correctly you now talks about the fact it does like a 3-steps to go to fullscreen mode, with the tabs moving to the left during those three steps, right?

If you refer to that, I guess it should maybe be another bug?

Comment 11

[Mehmet]

(In reply to Clément Lefèvre from comment #10)
> If I understood correctly you now talks about the fact it does like a
> 3-steps to go to fullscreen mode, with the tabs moving to the left during
> those three steps, right?
> 
> If you refer to that, I guess it should maybe be another bug?

Yup. Same behavior with bot short cuts. So I can file another report regarding the "3-steps-tab-move".

Please feel free to close this report. Thanks.

Comment 12

[Clément Lefèvre]

Closing as per comment 11. Follow-up in bug 1402352.