839073 - Titlebar is collapsed in private browsing windows

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

Attachment: screenshot

[Environment]
* OSX 10.8
* http://hg.mozilla.org/mozilla-central/rev/04e13fc9dbff

Please see screenshot.

Comment 1

[Josh Matthews [:jdm]]

Hmm, is this a regression from bug 647216?

Comment 2

[Josh Matthews [:jdm]]

Mike, would this be an unintended consequences from private browsing's use of in-titlebar drawing for private browsing windows?

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Ouch, possibly. Hang on - lemme poke at this.

Comment 4

[Mike Conley (:mconley) (:⚙️)]

STR:

1) Go to http://www.getpersonas.com and add a lightweight theme to Firefox
2) Open a Private Browsing window

Result:

See attachment 711336 [details]

According to DOMi, we're getting burned by this rule: http://mxr.mozilla.org/comm-central/source/mozilla/browser/themes/pinstripe/browser.css#42

I don't believe we need this rule in this new drawing-titlebar-in-OSX world we're living in now. Give me some time to confirm.

Comment 5

[Mike Conley (:mconley) (:⚙️)]

(In reply to Mike Conley (:mconley) from comment #4)
> 
> I don't believe we need this rule in this new drawing-titlebar-in-OSX world
> we're living in now. Give me some time to confirm.

Hm, so we *do* need this rule until we're permanently drawing in the titlebar a-la bug 625989.

Comment 6

[Mike Conley (:mconley) (:⚙️)]

Ugh, and I was wrong about needing to have a lw-theme installed. Was using the wrong build.

The STR in comment 4 are no longer valid. Just opening a private browsing window is sufficient to expose the bug.

Comment 7

[Mike Conley (:mconley) (:⚙️)]

Attachment: Patch v1

Don't display:none the titlebar if we're in a private browsing window.

Comment 8

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 711388 [details] [diff] [review]
Patch v1

Hey Dao, does this work for you?

Comment 9

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 711388 [details] [diff] [review]
Patch v1

Or perhaps you have some cycles to review this, Marco?

Comment 11

[Dão Gottwald [:dao]]

Comment on attachment 711388 [details] [diff] [review]
Patch v1

> #titlebar-buttonbox-container,
>-#titlebar:not(:-moz-lwtheme) {
>+#main-window:not([privatebrowsingmode=temporary]) > #titlebar:not(:-moz-lwtheme) {
>   display: none;
> }

I believe you want '#main-window:not([drawintitlebar=true]) > #titlebar' here.

> #main-window[drawintitlebar="true"] > #titlebar {
>   height: 22px;
> }

And then you can change this to just #titlebar.

Comment 12

[Mike Conley (:mconley) (:⚙️)]

Attachment: Patch v2

Oh yes - good thinking. That's much more direct.

Comment 13

[Mike Conley (:mconley) (:⚙️)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/aa22cad7f343

Comment 14

[Ryan VanderMeulen (PTO, back 6-April)]

https://hg.mozilla.org/mozilla-central/rev/aa22cad7f343

Comment 16

[Mehmet]

I think here is still an issue:

Switching into (and out of) fullscreen with a PrivateMode Window with the shortcut SHIFT-CMD-F or CTRL-CMD-F is very smooth.

But when you use the Fullscreen-Button then you will notice a short break with the titlebar and you will notice that there is not a nice transition while switching into (and out of) fullscreen.

Same behavior, when you are in fullscreen with a PrivateMode Window and open a new one with SHIFT-CMD-P.

Is this a known issue or should I file a new one ?

Thanks.

Comment 17

[Josh Matthews [:jdm]]

Please file a new one.

Comment 18

[Mehmet]

(In reply to Josh Matthews [:jdm] from comment #17)
> Please file a new one.

Filed bug 839773. Thanks.