840051 - [MMS][User Story] Message device timestamp

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect, P1)

Description

[Peter Dolanjski [:pdol]]

UCID: Messages-078

User Story:
As a user, I want to see a timestamp associated with a message being sent or received which reflects the device time, not network time.

Comment 1

[Neo Hsieh [:neo]]

Sorry, I don't know about last sentence " Not network time" .  Can you explain it more detail ? Thanks.

Comment 2

[Joe Cheng [:jcheng] (please needinfo)]

Vicamo, can you confirm if this is done in gecko already. thanks

Comment 3

[Brad Lassey [:blassey] (use needinfo?)]

The assumption is that this already works with the implementation of SMS, assigning to Bocoup to confirm.

Comment 4

[Casey Yee]

The message time-stamp should be local time on the device.

From a UX perspective, this should not be any different than what we already have in place with SMS.

Flagging Peter for NeedsInfo to confirm that the current implementation fulfills this requirement.

Comment 5

[Peter Dolanjski [:pdol]]

(In reply to Casey Yee [:cyee] from comment #4)
> The message time-stamp should be local time on the device.
> 
> From a UX perspective, this should not be any different than what we already
> have in place with SMS.
> 
> Flagging Peter for NeedsInfo to confirm that the current implementation
> fulfills this requirement.

It does.  This requirement is basically in place to ensure that this continues to be the case with MMS.

Comment 6

[Vicamo Yang [:vicamo][:vyang]]

(In reply to Peter Dolanjski [:pdol] from comment #5)
> (In reply to Casey Yee [:cyee] from comment #4)
> > The message time-stamp should be local time on the device.
> > 
> > From a UX perspective, this should not be any different than
> > what we already have in place with SMS.
> > 
> > Flagging Peter for NeedsInfo to confirm that the current
> > implementation fulfills this requirement.
> 
> It does.  This requirement is basically in place to ensure
> that this continues to be the case with MMS.

It does *NOT*, at least for received SMS.  Please see https://github.com/mozilla-b2g/gaia/issues/3087 for previous discussion.  As for current SMS implementation, for sent messages, we use device time; for received messages, network time instead.

Comment 7

[Kai-Chih Hu [:khu]]

Sorry. Just curious, if users change the timezone, will the time used for SMS/MMS be changed? Should it be changed?

Comment 8

[Kai-Chih Hu [:khu]]

Notes: Only received/incoming messages have network time stamp. Sent/outgoing messages don't have network time stamp. Outgoing messages have device time stamp only. 

2 different scenarios: 
(a) time zone changed. 
(b) users change the date/time without changing time zone. 

It looks like (b) will have problem and (a) won't have problem. Another issue we could discuss is: 
Should we use device time stamp for incoming messages and outgoing messages? 

We proposed to use device time stamp here. Does anyone have any concern? Thank you.

Comment 9

[Dietrich Ayala (:dietrich)]

Per partner and release-driver discussions, marking blocking- until all MMS functionality in bug 849867 is complete, allowing it all to be uplifted at once to avoid SMS bustage.

Comment 10

[Joe Cheng [:jcheng] (please needinfo)]

leo+ as this is a part of MMS and part of v1.1 to be included in leo+ queries. No_UPLIFT for now before the whole MMS is completed

Comment 11

[Paul Yang [:pyang] (away)]

moztrap #6542

Comment 12

[Borja Salguero [:borjasalguero]]

As agreed in Madrid assigned to us https://wiki.mozilla.org/Gaia/SMS by now. I will talk with Steve Chung in order to check who will be in charge of this.

Comment 13

[Vicamo Yang [:vicamo][:vyang]]

(In reply to Vicamo Yang [:vicamo][:vyang] from comment #6)
> It does *NOT*, at least for received SMS.  Please see
> https://github.com/mozilla-b2g/gaia/issues/3087 for previous discussion.  As
> for current SMS implementation, for sent messages, we use device time; for
> received messages, network time instead.

Bug 860604 had been landed to birch/m-c/b2g18/b2g18_v1_0_1, the existing behaviour is using device time for both sent and received SMS messages.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

status-b2g18:fixed based on comment 13