840066 - [MMS][User Story] Automatic download retry on failure

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect, P1)

Description

[Peter Dolanjski [:pdol]]

UCID: Messages-044

User Story:
As a user, I will not have to manually retry downloads if the download of media attached to an MMS message fails. Should a download of media fail the application will automatically retry downloading the content a minimum of four times when the network is active at intervals of 1, 5, 10, and 30 minutes, and an indication that content downloads are in progress will be presented to me. Should the content download fail, the failure should be anounced to me in the form of a message notification in the inbox to simplify the viewing of MMS message status for me.

Comment 1

[Neo Hsieh [:neo]]

My suggestion is let user manual download media content. If user download media content fail and then that user go to another area (Roaming), That will be a problem.

Comment 2

[Casey Yee]

Within the MMS spec we have a in-app setting "Auto retrieve messages" when toggled On should automatically retry the messages as per the user story.   

If Auto receive messages is toggled Off, the user will be prompted to manually download message contents each time they receive a MMS message.

There is also a "Roaming auto-retrieve" which when toggled On will automatically download message if the user is roaming.  

This is by default toggled Off and the user will be manually prompted to download message contents.

You can see this within the MMS spec on page 15:
https://www.dropbox.com/s/zc3hhd1mxi16p4w/MMS.pdf

Comment 3

[Dietrich Ayala (:dietrich)]

Per partner and release-driver discussions, marking blocking- until all MMS functionality in bug 849867 is complete, allowing it all to be uplifted at once to avoid SMS bustage.

Comment 4

[Rick Waldron [:rwaldron]]

Can you clarify this flag? "in-moztrap"

Comment 5

[Joe Cheng [:jcheng] (please needinfo)]

leo+ as this is a part of MMS and part of v1.1 to be included in leo+ queries. No_UPLIFT for now before the whole MMS is completed

Comment 6

[Paul Yang [:pyang] (away)]

#6674

Comment 7

[Gene Lian (I already quit Mozilla)]

This part should be solved in the Gecko part. Let me try it.

Comment 8

[Gene Lian (I already quit Mozilla)]

Attachment: Patch

Hi Vicamo, this patch is not yet tested but completed. Need your feedback. Thanks!

Comment 9

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

Comment on attachment 738012 [details] [diff] [review]
Patch

Looks good to me.

Comment 10

[Vicamo Yang [:vicamo][:vyang]]

Comment on attachment 738012 [details] [diff] [review]
Patch

Review of attachment 738012 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/mms/src/ril/MmsService.js
@@ +70,5 @@
> +  Services.prefs.getCharPref("dom.mms.retrievalRetryIntervals").split(",");
> +for (let i = 0; i < intervals.length; ++i) {
> +  intervals[i] = parseInt(intervals[i], 10);
> +}
> +const PREF_RETRIEVAL_RETRY_INTERVALS = intervals;

const PREF_RETRIEVAL_RETRY_INTERVALS = (function () {
    // Please also ensure intervals.length equals to PREF_RETRIEVAL_RETRY_COUNT.
  })();

So that we don't pollute global scope with temporary variables.

Comment 11

[Gene Lian (I already quit Mozilla)]

Attachment: Patch, V1.1

parseInt() doesn't throw exception when failing to parse. It returns Nan.

Comment 12

[Vicamo Yang [:vicamo][:vyang]]

https://hg.mozilla.org/projects/birch/rev/b4f4d4749b99

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b4f4d4749b99

Comment 14

[Gene Lian (I already quit Mozilla)]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/113b3227e87c

Comment 15

[Vicamo Yang [:vicamo][:vyang]]

Already uplifted to b2g18.