840678 - Use HTTPS instead of HTTP for input.mozilla.org submissions

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

+++ This bug was initially created as a clone of Bug #771788 +++

Steps to reproduce:

Go to about:config
Search for : http://


Actual results:

[...]
extensions.input.brokenURL;http://input.mozilla.com/feedback#broken
extensions.input.happyURL;http://input.mozilla.com/happy
extensions.input.ideaURL;http://input.mozilla.com/feedback#idea
extensions.input.sadURL;http://input.mozilla.com/sad
[...]

Expected results:

The secure HTTPS protocol should have been used, not the insecure HTTP protocol.

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

I don't understand this bug. Doesn't seem like anything we can fix in the input.mozilla.org site. Shouldn't this be a Firefox bug and not an Input bug? Or am I missing something?

Comment 2

[James Socol [:jsocol, :james]]

This is, indeed, a Firefox bug. This component is for the Input Server Software.

Comment 3

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Will, James, do you object to Firefox changing the URLs to "https://"? Could you verify that https://input.mozilla.org will work OK?

Comment 4

[James Socol [:jsocol, :james]]

(In reply to Brian Smith (:bsmith) from comment #3)
> Will, James, do you object to Firefox changing the URLs to "https://"? Could
> you verify that https://input.mozilla.org will work OK?

It works great. In fact, I was surprised that http:// doesn't redirect and we don't send HSTS headers.

Comment 5

[James Socol [:jsocol, :james]]

Brian, Android has a different set of URLs (starting with m.). I didn't see a blocker to bug 771788 specifically for Android.

Comment 6

[Raymond Lee [:raymondlee]]

Attachment: v1

http://mxr.mozilla.org/mozilla-central/search?string=input.mozilla.com

I see there some places in the following directories which use HTTP instead of HTTPS.  Should we update them as well?
/b2g/app/
/mobile/android/app/profile/extensions/[e-mail]/
/mobile/xul/app/

Comment 7

[Raymond Lee [:raymondlee]]

Attachment: v2

Since they are all simple changes, I have just updated b2 and mobile directories

Comment 8

[:Gavin Sharp [email: [e-mail]]]

While we're at it, it looks like input.mozilla._org_ is the canonical URL, so we should probably also switch to that.

Comment 9

[Raymond Lee [:raymondlee]]

Attachment: v3

Use https and mozilla.org

Comment 10

[Raymond Lee [:raymondlee]]

Redirect chain
https://input.mozilla.org/feedback/ ->https://input.mozilla.org/en-US/feedback/
https://input.mozilla.org/happy -> https://input.mozilla.org/en-US/feedback#happy
https://input.mozilla.org/sad -> https://input.mozilla.org/en-US/feedback#sad
https://input.mozilla.org/feedback#broken -> https://input.mozilla.org/en-US/feedback#broken
https://input.mozilla.org/feedback#idea -> https://input.mozilla.org/en-US/feedback#idea

Comment 11

[Will Kahn-Greene [:willkg] ET needinfo? me]

I've never seen any indication there's handling for #broken. I think that doesn't exist. We probably should take out the brokenURL thing.

Comment 12

[Raymond Lee [:raymondlee]]

(In reply to Will Kahn-Greene [:willkg] from comment #11)
> I've never seen any indication there's handling for #broken. I think that
> doesn't exist. We probably should take out the brokenURL thing.

This preference is being used by testpilot.

http://mxr.mozilla.org/mozilla-central/source/browser/app/profile/extensions/[e-mail]/modules/feedback.js#35

Jono: Do you know more about that? Can we remove that?

Comment 13

[Will Kahn-Greene [:willkg] ET needinfo? me]

If you go to the above #broken url, you just end up on the feedback form (the #broken part doesn't do anything). So it "works", but doesn't do anything in particular unless metrics is tracking it somehow outside of Input.

One other thing is that we're in the process of getting the new Input to production and it should be there this month. End of March at the latest. At that point, all these urls are going to need to change again.

I'd hold off on making url changes until the new Input is in production.

Comment 14

[:Gavin Sharp [email: [e-mail]]]

We're also re-writing testpilot (bug 840108) and removing some of the "input" pieces from it (bug 841437). So for the moment we should probably just not touch that code.

It looks to me though that app.feedbackURL is a remnant from mobile XUL's about page that got copied to b2g/metro but isn't used there. So perhaps we can just remove it? 

We may want to avoid touching mobile/ in this bug too (and perhaps file a followup on them), so maybe this bug should just cover making the utilityOverlay change.

Comment 15

[Raymond Lee [:raymondlee]]

Attachment: v4

(In reply to :Gavin Sharp (use [e-mail] for email) from comment #14)
> We're also re-writing testpilot (bug 840108) and removing some of the
> "input" pieces from it (bug 841437). So for the moment we should probably
> just not touch that code.
> 
> It looks to me though that app.feedbackURL is a remnant from mobile XUL's
> about page that got copied to b2g/metro but isn't used there. So perhaps we
> can just remove it? 

Filed bug 847784 and bug 847786

> 
> We may want to avoid touching mobile/ in this bug too (and perhaps file a
> followup on them), 

Filed bug 847788 and bug 847789

> so maybe this bug should just cover making the
> utilityOverlay change.

The patch only contains the utilityOverlay change.

Comment 16

[Raymond Lee [:raymondlee]]

Attachment: Patch for check-in

Comment 17

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2a84cfaf3a6a

Comment 18

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2a84cfaf3a6a