840698 - Activities are broken

Status: VERIFIED FIXED

(Core Graveyard :: DOM: Apps, defect)

Description

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

STR
 (1) Follow steps in https://wiki.mozilla.org/index.php?title=B2G/Memory_acceptance_criteria#MW2:_Active_call_stays_active

Neither the gallery nor the camera will launch to "Add image".

Sigh.

Comment 1

[Mike Habicher [:mikeh] (high bugzilla latency)]

Can't choose wallpaper either in bug 840145.

Comment 2

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Process buster stopped working too.

Comment 5

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Works in cb007bcbaaffacf2e8ea93a60cf7c4ccd1164437, broken in fb102153d75ae635dcb96d85e9be248beadeb7fe.

Comment 6

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Bisection failed, but bug 838102 has to be it.

Comment 7

[Jason Smith [:jsmith]]

(In reply to Chris Jones [:cjones] [:warhammer] from comment #6)
> Bisection failed, but bug 838102 has to be it.

Sounds like we've got our regression window then. That sounds like the right bug.

Comment 8

[Jason Smith [:jsmith]]

It's bugs like these that remind me why we need mochitests for the apps API. Thankfully, Dale is closing in on getting the hosted app cases checked in and ferjm is hard at work on the packaged app cases.

When we do get the basic framework checked in, let's jump back to this bug later to get a sanity test here.

Comment 9

[Mike Habicher [:mikeh] (high bugzilla latency)]

I wonder if bug 839261 could be related to this as well.

Comment 10

[[:fabrice] Fabrice Desré]

Attachment: patch

Unbreaking my breakage...

Comment 11

[Alex Keybl [:akeybl]]

(In reply to Fabrice Desré [:fabrice] from comment #10)
> Created attachment 713128 [details] [diff] [review]
> patch
> 
> Unbreaking my breakage...

tef+ so that this can land today without approval (basically blocking a blocker). If not a forward fix, a=akeybl to back out bug 838102 for tomorrow's build.

Comment 12

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Comment on attachment 713128 [details] [diff] [review]
patch

Not my front yard, but need to fix asap.  Confirmed this fixes the bug.

>diff --git a/dom/apps/src/Webapps.jsm b/dom/apps/src/Webapps.jsm

>+      // Do a copy of the description object since we don't want to modify

"Make a copy"

>       debug('_createActivitiesToRegister: ' + aApp.manifestURL + ', activity ' +
>           activity + ', description.href is ' + href);

newDesc.href, right?

Comment 13

[[:fabrice] Fabrice Desré]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/8c6b6a7e02e9

Comment 14

[[:fabrice] Fabrice Desré]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6228ddc49fc2

Comment 15

[Justin Lebar (not reading bugmail)]

Oh goodness.  I spent all day bisecting broken activities (for some reason I needed to do it three times before I got the right result), and then I see that you've already fixed it!

Lesson learned: Next time I'll ask on IRC.

Thanks for fixing this.

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/6228ddc49fc2

Comment 17

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18_v1_0_0/rev/41c97d59dc30

Comment 18

[mlevin]

Verified fixed.

The following tests pass:

1. Both camera and gallery launch and add the image to contact in test steps on wiki:  https://wiki.mozilla.org/index.php?title=B2G/Memory_acceptance_criteria#MW2:_Active_call_stays_active

2. Wallpaper chooser works as described in bug 840145.

3. Create a new contact with first and last name and a mobile phone number, then from that contact attempt to open sms app.

Notes:
Gaia: 07aa79239ced90a7ca0e8da8829fbcb330c42e9f
Gecko:  http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/6fec2938ac1e
Build ID: 20130213071150

Comment 19

[Sarah Parsons]

This issue reproducing again on Inari Build ID: 20130515070208

Opened a new ticket, Bug 837210

Environmental  Variables:
Kernel Date: Feb 21
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/d06cfe7d67c2
Gaia: 0ddb515f15cbc6b74fc2742b7599d6ae74c6413f

Comment 20

[Sarah Parsons]

Sorry, its actually bug 873210