840854 - Toolbar notification icons don't close on second click on OS X

Status: VERIFIED FIXED

(Firefox Graveyard :: SocialAPI, defect)

Description

[Matthew N. [:MattN]]

The problem from bug 789859 now appears on OS X.  This just started recently so I would guess it's caused by bug 811514.

(Quoting Mark Hammond (:markh) from bug 789859 comment #0)
> * Click once in the toolbar notification area - notification opens
> * Click again in the same area:
> 
> ** Expected: The notification area closes and stays closed.
> ** Actual: The notification area closes, then immediately re-opens.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

I didn't see this issue on Windows. We can just back out the patch for bug 811514.

Comment 2

[Matthew N. [:MattN]]

(In reply to Jared Wein [:jaws] from comment #1)
> I didn't see this issue on Windows. We can just back out the patch for bug
> 811514.

Why wouldn't we just fix this for all platforms? I agree with bug 811514 that the panels shouldn't consume outside clicks.

Comment 3

[Mark Hammond [:markh] [:mhammond]]

Attachment: Remove the attribute entirely

I could repro this on linux, and it seems the problem is that we now set consumeoutsideclicks="false" - nsMenuPopupFrame has code that explicitly checks for "false" whereas the lack of an attribute causes it to attempt to "do the right thing" - and the right thing seems to be done as removing the attribute fixes the problem for me on Linux.

Is anyone able to confirm this trivial patch solves the problem on Mac?

Comment 4

[Matthew N. [:MattN]]

(In reply to Mark Hammond (:markh) from comment #3)
> Is anyone able to confirm this trivial patch solves the problem on Mac?

WFM. r=me if you want it.

Comment 5

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 713805 [details] [diff] [review]
Remove the attribute entirely

Taking r+ from MattN

https://hg.mozilla.org/integration/mozilla-inbound/rev/6df7745580ff

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/6df7745580ff

Comment 7

[u279076]

I've not seen this for a while, marking verified fixed.