Closed Bug 841616 Opened 7 years ago Closed 7 years ago

Open Location dialog should be able to open a private window

Categories

(SeaMonkey :: UI Design, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.18

People

(Reporter: neil, Assigned: neil)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Without setting any preferences in that case of course.
Attached patch Possible patchSplinter Review
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #714186 - Flags: review?(philip.chee)
Attachment #714186 - Flags: review?(iann_bugzilla)
Comment on attachment 714186 [details] [diff] [review]
Possible patch

>+++ b/editor/ui/composer/content/ComposerCommands.js
>@@ -2091,16 +2091,19 @@ var nsOpenRemoteCommand =
>       case "2": // edit
>         editPage(params.url);
>         break;
>       case "3": // new tab
>         win.focus();
>         var browser = win.getBrowser();
>         browser.selectedTab = browser.addTab(params.url, {allowThirdPartyFixup: true});
>         break;
>+      case "4": // private
>+        openNewPrivateWith(params.url):
Oops, ";" not ":"

r=me with that fixed
Attachment #714186 - Flags: review?(iann_bugzilla) → review+
(In reply to Ian Neal from comment #2)
> Oops, ";" not ":"
Bah, I'd mistyped it in navigator.js, copied and pasted it into ComposerCommands.js, then noticed and fixed it in navigator.js but promptly forgotten to check editor :-(
Comment on attachment 714186 [details] [diff] [review]
Possible patch

r=me with the ":" vs ";" fixed.
Attachment #714186 - Flags: review?(philip.chee) → review+
Pushed comm-central changeset 94c2be83ba41.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.18
Depends on: 844497
You need to log in before you can comment on or make changes to this bug.