Open Location dialog should not save state when opened in a private window

RESOLVED FIXED in seamonkey2.19

Status

SeaMonkey
UI Design
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: neil@parkwaycc.co.uk, Assigned: neil@parkwaycc.co.uk)

Tracking

(Blocks: 1 bug)

unspecified
seamonkey2.19
Dependency tree / graph

SeaMonkey Tracking Flags

(seamonkey2.18 fixed)

Details

Attachments

(2 attachments)

(Assignee)

Description

4 years ago
The open location dialog never saves state when you use it to open a new private window. Except in that case, if open it from a private window it still saves state.
(Assignee)

Comment 1

4 years ago
Created attachment 717536 [details] [diff] [review]
Possible patch

The other alternative would be to make private be "5", but I think that results in a slightly bigger patch.
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #717536 - Flags: review?(iann_bugzilla)

Comment 2

4 years ago
(In reply to neil@parkwaycc.co.uk from comment #1)
> Created attachment 717536 [details] [diff] [review]
> Possible patch
> 
> The other alternative would be to make private be "5", but I think that
> results in a slightly bigger patch.

I think my preference would be to have "5" being private.
(Assignee)

Comment 3

4 years ago
Created attachment 717539 [details] [diff] [review]
Possible patch

Unfortunately making private "5" messes up the nice numbering in ComposerCommands.js and navigator.js ;-)
Attachment #717539 - Flags: review?(iann_bugzilla)

Comment 4

4 years ago
Comment on attachment 717536 [details] [diff] [review]
Possible patch

Hmmm, I agree this one is better.
Attachment #717536 - Flags: review?(iann_bugzilla) → review+

Updated

4 years ago
Attachment #717539 - Flags: review?(iann_bugzilla)
(Assignee)

Comment 5

4 years ago
Pushed comm-central changeset 5eaf09f06d3a.
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
(Assignee)

Updated

4 years ago
status-seamonkey2.18: --- → affected
Target Milestone: --- → seamonkey2.19
(Assignee)

Comment 6

4 years ago
Comment on attachment 717536 [details] [diff] [review]
Possible patch

[Approval Request Comment]
Regression caused by (bug #): 
User impact if declined: Potential information leak
Testing completed (on m-c, etc.): Uplifted to c-a
Risk to taking this patch (and alternatives if risky): 
String changes made by this patch: None
Attachment #717536 - Flags: approval-comm-beta?

Updated

4 years ago
Blocks: 460895

Updated

4 years ago
Attachment #717536 - Flags: approval-comm-beta? → approval-comm-beta+
(Assignee)

Comment 7

4 years ago
http://hg.mozilla.org/releases/comm-beta/rev/73971e6fef8d
status-seamonkey2.18: affected → fixed
You need to log in before you can comment on or make changes to this bug.