[tracking] Build Thunderbird ESR and Mainline from a single repo

RESOLVED FIXED

Status

Release Engineering
Release Automation
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: jhopkins, Assigned: jhopkins)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 3 obsolete attachments)

Comment hidden (empty)
(Assignee)

Updated

5 years ago
Depends on: 811770
(Assignee)

Updated

5 years ago
Depends on: 815604
(Assignee)

Updated

5 years ago
Depends on: 815606
(Assignee)

Updated

5 years ago
Depends on: 815607
(Assignee)

Updated

5 years ago
Depends on: 815613
Created attachment 697183 [details] [diff] [review]
Build Thunderbird release from esr repos, update mozconfig names

This patch should make Thunderbird release build from comm-esr17/mozilla-esr17.

It will also switch the Thunderbird esr release to use the newly created esr mozconfigs, the Thunderbird release build sticking with 'release'.

Obviously, I've not tested this but hopefully it should work.
Attachment #697183 - Flags: review?(jhopkins)
Attachment #697183 - Flags: review?(bhearsum)
Blocks: 810326
We decided not to take this for this cycle because we don't have time to properly test it. Marking this as blocking the next set of releases, though. John, this bug is assigned to you - are you able to test it sometime in the next 6 weeks?
Blocks: 825317, 825316
No longer blocks: 810326
Component: Release Engineering → Release Engineering: Automation (Release Automation)
QA Contact: bhearsum
(Assignee)

Comment 3

4 years ago
Comment on attachment 697183 [details] [diff] [review]
Build Thunderbird release from esr repos, update mozconfig names

We'll need a patch for staging_XXXX files as well.
Attachment #697183 - Flags: review?(jhopkins) → review+
Created attachment 697443 [details] [diff] [review]
Build Thunderbird release from esr repos

The mozconfig name changes landed in a separate bug.
Attachment #697183 - Attachment is obsolete: true
Attachment #697183 - Flags: review?(bhearsum)
Attachment #697443 - Flags: review?(jhopkins)
(Assignee)

Updated

4 years ago
Attachment #697443 - Flags: review?(jhopkins) → review+
(Assignee)

Comment 5

4 years ago
We're building 17.0.1 based on comm-release.  In the meantime, yes, I can test this patch in staging.
Depends on: 836041
Created attachment 708024 [details] [diff] [review]
Switch comm-esr17 branch to esr mozconfigs

We tried this for 17.0.2esr but had to back out because of the branding being wrong on the resultant builds.

John: Can we get a staging run of TB 17esr from the latest default comm-esr17 revision, plus this patch on buildbot-configs?

I'll want to see the en-US plus at least one other locale for each of Windows, Mac and Linux platforms.

If we know these branding changes work, we can land them and use them going forward. We can then work on the 17.0.2 mainstream changes afterwards (or in parallel) which require some additional work as I've commented in the dependent bugs.
Attachment #708024 - Flags: review?(jhopkins)
(In reply to Mark Banner (:standard8) from comment #6)
> John: Can we get a staging run of TB 17esr from the latest default
> comm-esr17 revision, plus this patch on buildbot-configs?
> 
> I'll want to see the en-US plus at least one other locale for each of
> Windows, Mac and Linux platforms.

You'll also need to get bug 836036 fixed before trying the staging run (unless you don't run the check mozconfigs step there).
Depends on: 836036
(Assignee)

Updated

4 years ago
Attachment #708024 - Flags: review?(jhopkins) → review+
Comment on attachment 708024 [details] [diff] [review]
Switch comm-esr17 branch to esr mozconfigs

http://hg.mozilla.org/build/buildbot-configs/rev/5a2512247972
Attachment #708024 - Flags: checked-in+
(Assignee)

Updated

4 years ago
Blocks: 815606
No longer depends on: 815606
Created attachment 710925 [details] [diff] [review]
Build Thunderbird release from esr repos v2

Updated patch to include staging configs.
Attachment #697443 - Attachment is obsolete: true
Attachment #710925 - Flags: review?(jhopkins)
In production
(Assignee)

Comment 11

4 years ago
Created attachment 712550 [details] [diff] [review]
[buildbot-configs] Build Thunderbird release from esr repos v2

standard8: your patch looked good except for the ['sourceRepositories'][x]['name'] had to be left unchanged, otherwise no release-comm-release builders were present on the buildbot master.
I ran my staging builds with this patch in place.
Attachment #710925 - Attachment is obsolete: true
Attachment #710925 - Flags: review?(jhopkins)
Attachment #712550 - Flags: review?(mbanner)
Comment on attachment 712550 [details] [diff] [review]
[buildbot-configs] Build Thunderbird release from esr repos v2

That makes sense.

The staging builds look fine wrt branding as well, so I think we're good to go with this for 17.0.3.
Attachment #712550 - Flags: review?(mbanner) → review+
(Assignee)

Comment 13

4 years ago
Comment on attachment 712550 [details] [diff] [review]
[buildbot-configs] Build Thunderbird release from esr repos v2

Landed in https://hg.mozilla.org/build/buildbot-configs/rev/820e714f526c
Attachment #712550 - Flags: checked-in+
(Assignee)

Updated

4 years ago
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
(Assignee)

Updated

4 years ago
Depends on: 841550
(Assignee)

Comment 14

4 years ago
Reopened due to bug 841550
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
This caused us to update the wrong release config during release runner: https://hg.mozilla.org/build/buildbot-configs/rev/9399f2f0e6d3

Thankfully, the esr config got re-bumped to the ESR before that release was kicked off.
Depends on: 841891
Depends on: 841903
(In reply to Ben Hearsum [:bhearsum] from comment #15)
> This caused us to update the wrong release config during release runner:
> https://hg.mozilla.org/build/buildbot-configs/rev/9399f2f0e6d3
> 
> Thankfully, the esr config got re-bumped to the ESR before that release was
> kicked off.

Filed this as bug 842741.
(Assignee)

Comment 17

4 years ago
All dependent bugs are closed.
Status: REOPENED → RESOLVED
Last Resolved: 4 years ago4 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.