843455 - B2G STK: Import scripts for marionette tests

Status: RESOLVED FIXED

(Firefox OS Graveyard :: RIL, defect)

Description

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

In Bug 797296 we add many test case for STK marionete tests,
however there are many code duplicated so once Bug 805838 is landed we'd use import script to avoid the duplicated code.

Comment 1

[Georgia Wang]

Attachment: B2G STK Import scripts for marionette tests.

https://tbpl.mozilla.org/?tree=Try&rev=f59be29b8c30

Comment 2

[Georgia Wang]

Attachment: B2G STK Import scripts for marionette tests. v1

Update attachment for the missing file.
try: https://tbpl.mozilla.org/?tree=Try&rev=f90c1d3a3c41

Comment 3

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Comment on attachment 823220 [details] [diff] [review]
B2G STK Import scripts for marionette tests. v1

Review of attachment 823220 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/icc/tests/marionette/test_stk_display_text.js
@@ +1,4 @@
>  /* Any copyright is dedicated to the Public Domain.
>     http://creativecommons.org/publicdomain/zero/1.0/ */
>  
> +MARIONETTE_HEAD_JS = 'stk_helper.js';

nit, we use double quotes '"' here.
Same for other files.

::: dom/icc/tests/marionette/test_stk_get_input.js
@@ +169,5 @@
>              maxLength: 10}},
>  ];
>  
>  // TODO - Bug 843455: Import scripts for marionette tests.
> +/*

??

@@ +204,5 @@
>  
>    SpecialPowers.removePermission("mobileconnection", document);
>    finish();
>  }
> +*/

??

::: dom/icc/tests/marionette/test_stk_proactive_command.js
@@ +1,5 @@
>  /* Any copyright is dedicated to the Public Domain.
>     http://creativecommons.org/publicdomain/zero/1.0/ */
>  
> +MARIONETTE_HEAD_JS = 'stk_helper.js';
> +/*

??

@@ +8,5 @@
>  SpecialPowers.addPermission("mobileconnection", true, document);
>  
>  let icc = navigator.mozIccManager;
>  ok(icc instanceof MozIccManager, "icc is instanceof " + icc.constructor);
> +*/

??

@@ +109,5 @@
>     func: testTimerManagementDeactivate},
>    {command: "d00c810301270282028182a40108",
>     func: testTimerManagementGetCurrentValue},
>   ];
> +/*

??

@@ +144,5 @@
>  
>    SpecialPowers.removePermission("mobileconnection", document);
>    finish();
>  }
> +*/

??

Comment 4

[Georgia Wang]

Attachment: B2G STK Import scripts for marionette tests. v2

https://tbpl.mozilla.org/?tree=Try&rev=129812bb8f45

Comment 5

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Comment on attachment 823789 [details] [diff] [review]
B2G STK Import scripts for marionette tests. v2

Review of attachment 823789 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/icc/tests/marionette/stk_helper.js
@@ +33,5 @@
> +    return;
> +  }
> +
> +  let command = "stk pdu " + test.command;
> +  sendStkPduToEmulator(command, test.func, test.expect)

missing ; at the end.

Comment 6

[Georgia Wang]

Attachment: B2G STK Import scripts for marionette tests. v3

Add ; 
(after sendStkPduToEmulator(command, test.func, test.expect);)

Comment 7

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

https://hg.mozilla.org/integration/b2g-inbound/rev/7351bfb23ce6

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7351bfb23ce6