B2G STK: Don't introduce global variables in stk_helper.js

RESOLVED WONTFIX

Status

Firefox OS
RIL
RESOLVED WONTFIX
4 years ago
4 years ago

People

(Reporter: allstars, Assigned: allstars)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
In 
http://mxr.mozilla.org/mozilla-central/source/dom/icc/tests/marionette/stk_helper.js#8

http://mxr.mozilla.org/mozilla-central/source/dom/icc/tests/marionette/stk_helper.js#21

http://mxr.mozilla.org/mozilla-central/source/dom/icc/tests/marionette/stk_helper.js#24

http://mxr.mozilla.org/mozilla-central/source/dom/icc/tests/marionette/stk_helper.js#21

stk_helper introduces some global variables, which pollutes the global namespace.
And cause some problem, 
https://bugzilla.mozilla.org/show_bug.cgi?id=938466#c15

We should try to not define globals in the helper script.
(Assignee)

Updated

4 years ago
Summary: B2G STK: Don't introduce global variables in stk_helper.js during marionette tests → B2G STK: Don't introduce global variables in stk_helper.js
(Assignee)

Updated

4 years ago
Assignee: nobody → allstars.chh
(Assignee)

Comment 1

4 years ago
CCing Edgar, I'd remove iccManager from stk_helper.js, so all STK marionette tests would declare 'iccManager' by themselves.
(Assignee)

Comment 2

4 years ago
Created attachment 8343580 [details] [diff] [review]
Bug944220.patch
(Assignee)

Updated

4 years ago
Attachment #8343580 - Flags: review?(vyang)
(Assignee)

Updated

4 years ago
Attachment #8343580 - Flags: review?(vyang)
(Assignee)

Comment 3

4 years ago
After discussing with Vicamo we think we don't need to do this.
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.