Closed
Bug 944220
Opened 11 years ago
Closed 11 years ago
B2G STK: Don't introduce global variables in stk_helper.js
Categories
(Firefox OS Graveyard :: RIL, defect)
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: allstars.chh, Assigned: allstars.chh)
References
Details
Attachments
(1 file)
|
17.21 KB,
patch
|
Details | Diff | Splinter Review |
In
http://mxr.mozilla.org/mozilla-central/source/dom/icc/tests/marionette/stk_helper.js#8
http://mxr.mozilla.org/mozilla-central/source/dom/icc/tests/marionette/stk_helper.js#21
http://mxr.mozilla.org/mozilla-central/source/dom/icc/tests/marionette/stk_helper.js#24
http://mxr.mozilla.org/mozilla-central/source/dom/icc/tests/marionette/stk_helper.js#21
stk_helper introduces some global variables, which pollutes the global namespace.
And cause some problem,
https://bugzilla.mozilla.org/show_bug.cgi?id=938466#c15
We should try to not define globals in the helper script.
|
Assignee | |
Updated•11 years ago
|
Summary: B2G STK: Don't introduce global variables in stk_helper.js during marionette tests → B2G STK: Don't introduce global variables in stk_helper.js
|
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → allstars.chh
|
|
Assignee | |
Comment 1•11 years ago
|
||
CCing Edgar, I'd remove iccManager from stk_helper.js, so all STK marionette tests would declare 'iccManager' by themselves.
|
|
Assignee | |
Comment 2•11 years ago
|
||
|
|
Assignee | |
Updated•11 years ago
|
Attachment #8343580 -
Flags: review?(vyang)
|
|
Assignee | |
Updated•11 years ago
|
Attachment #8343580 -
Flags: review?(vyang)
|
|
Assignee | |
Comment 3•11 years ago
|
||
After discussing with Vicamo we think we don't need to do this.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•