Closed
Bug 844175
Opened 11 years ago
Closed 11 years ago
Twitter stays on Connecting: Requesting user timelines...
Categories
(Thunderbird :: Instant Messaging, defect)
Tracking
(thunderbird21+ fixed)
RESOLVED
FIXED
Thunderbird 22.0
People
(Reporter: Paenglab, Assigned: florian)
References
Details
(Keywords: regression)
Attachments
(2 files)
7.43 KB,
patch
|
clokep
:
review+
mconley
:
review+
standard8
:
approval-comm-aurora+
|
Details | Diff | Splinter Review |
1.90 KB,
patch
|
Details | Diff | Splinter Review |
Twitter is always in Connecting: Requesting user timelines... state. In console I have this: Error: Component returned failure code: 0x8000ffff (NS_ERROR_UNEXPECTED) [nsIPrefBranch.getCharPref] Source file: resource://gre/components/imIncomingServer.js Line: 179 After disconnecting and connecting again I'm seeing this: Fri Feb 22 2013 18:45:40 Error: NS_ERROR_ILLEGAL_VALUE: Illegal value Source file: resource://app/modules/http.jsm Line: 13 Last good was TB 21 from 16.2.2013. Because of build bustage the next build was from 19.2.2013 and this shows the issue. Maybe it has something to do with Bug 842183 which land in this time. I tried this on Win7 and Linux.
Comment 1•11 years ago
|
||
The second error looks like it's from a fork in http.jsm between chat/ [1] and mail/ [2]: Mail: > function doXHRequest(aUrl, aHeaders, aPOSTData, aOnLoad, aOnError, aThis, aMethod) Chat: > function doXHRequest(aUrl, aHeaders, aPOSTData, aOnLoad, aOnError, aThis, aLogger) We now pass aLogger, this gets considered (in Thunderbird) as aMethod and causes that error. [1] http://mxr.mozilla.org/comm-central/source/chat/modules/http.jsm [2] http://mxr.mozilla.org/comm-central/source/mail/base/modules/http.jsm
Same here - for old accounts that was worked before v21 uodate i got - requesting user timelines.. but before there was a second dialog asking (usually annoying because i was activating it for mail already) for master password; for the same twi acc. i've created a new kinda account in bird - and i got: Connecting: initiating authentication process but irc is running already in the same time not sure about fb.
Assignee | ||
Comment 3•11 years ago
|
||
Comment 4•11 years ago
|
||
Comment on attachment 719723 [details] [diff] [review] Sync the two http.jsm files These changes look good and should get Twitter back on track. I don't think I can actually review things in mail/base, however.
Attachment #719723 -
Flags: review?(mconley)
Attachment #719723 -
Flags: review?(clokep)
Attachment #719723 -
Flags: review+
Assignee | ||
Updated•11 years ago
|
Severity: normal → major
tracking-thunderbird21:
--- → ?
Target Milestone: --- → Thunderbird 22.0
Version: unspecified → 21
Comment 5•11 years ago
|
||
Comment on attachment 719723 [details] [diff] [review] Sync the two http.jsm files Review of attachment 719723 [details] [diff] [review]: ----------------------------------------------------------------- I'm alright with this. It blows that we have duplicated http.jsm, though. If both InstantBird and Thunderbird are using it, it belongs in toolkit.
Attachment #719723 -
Flags: review?(mconley) → review+
Assignee | ||
Comment 6•11 years ago
|
||
https://hg.mozilla.org/comm-central/rev/361ace8a7590 http://hg.instantbird.org/instantbird/rev/237424fae13f
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 7•11 years ago
|
||
Assignee | ||
Comment 8•11 years ago
|
||
(In reply to Florian Quèze [:florian] [:flo] from comment #7) > Created attachment 721706 [details] [diff] [review] > Bustage fix https://hg.mozilla.org/comm-central/rev/94f3a8a2bdf7 (rs=mconley over IRC)
Assignee | ||
Comment 9•11 years ago
|
||
(In reply to Florian Quèze [:florian] [:flo] from comment #8) > (In reply to Florian Quèze [:florian] [:flo] from comment #7) > > Created attachment 721706 [details] [diff] [review] > > Bustage fix > > https://hg.mozilla.org/comm-central/rev/94f3a8a2bdf7 (rs=mconley over IRC) And http://hg.instantbird.org/instantbird/rev/2b9937637ece
Assignee | ||
Comment 10•11 years ago
|
||
Comment on attachment 719723 [details] [diff] [review] Sync the two http.jsm files [Approval Request Comment] Regression caused by (bug #): bug 842183 User impact if declined: Twitter completely unusable. Testing completed (on c-c, etc.): Already landed for c-c and Instantbird. Risk to taking this patch (and alternatives if risky): Taking only the change to twitter.js may be possible, but I'm not sure that would really reduce the risk. Note: I'm requesting approval on only one attachment, but we need to port both 361ace8a7590 and 94f3a8a2bdf7 to comm-aurora.
Attachment #719723 -
Flags: approval-comm-aurora?
Updated•11 years ago
|
Attachment #719723 -
Flags: approval-comm-aurora? → approval-comm-aurora+
Assignee | ||
Comment 11•11 years ago
|
||
(In reply to Florian Quèze [:florian] [:flo] from comment #10) > Note: I'm requesting approval on only one attachment, but we need to port > both 361ace8a7590 and 94f3a8a2bdf7 to comm-aurora. Pushed both at once as https://hg.mozilla.org/releases/comm-aurora/rev/0fd17de09e0e
Assignee | ||
Updated•11 years ago
|
status-thunderbird21:
--- → fixed
Updated•11 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•