265.66 KB, image/png
105.56 KB, image/png
34.92 KB, image/png
6.49 KB, patch
|Details | Diff | Splinter Review|
Firefox for Android Version: 21.0a2 (2013-02-24) Device: Acer Iconia A500 OS: Android 3.2.1 Steps to reproduce: 1. Open Fennec 2. Go to a website 3. Long tap on the URL bar 4. Choose "Site Settings" from the Context Menu Actual results: - The text color is the same as its background: white (see attached screenshot) Expected results: - The text color should be visible.
Looks fine on Jellybean. Honeycomb issue?
WesJ fallout from the holo theming?
tracking-fennec: --- → ?
Patch. Build with this at: http://people.mozilla.com/~wjohnston/sitePrefs.apk Can you test it on a Honeycomb device kbrosnan?
(In reply to Wesley Johnston (:wesj) from comment #4) > Created attachment 719727 [details] [diff] [review] > Patch v1 > > Patch. Build with this at: > > http://people.mozilla.com/~wjohnston/sitePrefs.apk > > Can you test it on a Honeycomb device kbrosnan? I somehow don't like moving padding to the styles. It breaks the layout file. Could you please move only the "textAppearance" to the styles file? Also, you might want to add "res/values-v14" to RES_DIRS in the Makefile.
Removed the padding stuff. I think this should be in the style files (hence why I moved it, but we can figure that out some other time/place).
Comment on attachment 720161 [details] [diff] [review] Patch v2 This looks good to me.
Attachment #720161 - Flags: review?(sriram) → review+
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 22
Comment on attachment 720161 [details] [diff] [review] Patch v2 [Approval Request Comment] Bug caused by (feature/regressing bug #): 832321 User impact if declined: Site settings dialog looks bad Testing completed (on m-c, etc.): Has been on mc for a few weeks. No regressions Risk to taking this patch (and alternatives if risky): Low risk. Mostly themeing String or UUID changes made by this patch: None.
Attachment #720161 - Flags: approval-mozilla-aurora?
Attachment #720161 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Verified fixed on: -build: Firefox for Android 22.0a1 (2013-03-12) -device: Acer Iconia A500 -OS: Android 3.2.1
Verified fixed on: -build: Firefox for Android 21.0a2 (2013-03-14) -device: Acer Iconia A500 -OS: Android 3.2.1
You need to log in before you can comment on or make changes to this bug.