847849 - Hostname in site settings dialog is misaligned

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[:Margaret Leibovic]

Attachment: screenshot

See screenshot.

Also, the ellipsis in the title looks awkward, but this would be fixed if we fix bug 786999.

Comment 2

[Wesley Johnston (:wesj)]

I'm not sure how removing the ellipsis fixes this? Its likely fallout from bug 844834.

Comment 3

[:Margaret Leibovic]

I guess I wasn't clear. Removing the ellipsis just fixes the fact that the ellipsis in the title is awkward :)

We still need to do something to fix the host name alignment.

Comment 5

[:Margaret Leibovic]

Attachment: put back padding that was removed

The patch in bug 844834 got rid of this padding.

I also found that the title and subtitle are both black on black on gingerbread. That also needs a fix.

Comment 6

[Wesley Johnston (:wesj)]

Comment on attachment 723702 [details] [diff] [review]
put back padding that was removed

The patch at:

https://hg.mozilla.org/mozilla-central/rev/5668dcdcdbdd

has padding on the left and right. I moved them to styles and then supposedly moved them back (which apparently means I didn't move them back). Might as well put both back.

Comment 7

[:Margaret Leibovic]

Attachment: put back padding on both sides

Comment 8

[Wesley Johnston (:wesj)]

Comment on attachment 723705 [details] [diff] [review]
put back padding on both sides

Review of attachment 723705 [details] [diff] [review]:
-----------------------------------------------------------------

I realize now what happened. I moved these to styles (where I still think they should live) then I moved them back, but since I was using inheritence in the styles so we didn't have to duplicate this all over, I forgot to add them back here (aka if they were styles this would have been prettier and easier).

Comment 9

[:Margaret Leibovic]

https://hg.mozilla.org/integration/mozilla-inbound/rev/905682481543

Comment 10

[:Margaret Leibovic]

Comment on attachment 723705 [details] [diff] [review]
put back padding on both sides

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 844834
User impact if declined: site settings dialog title looks bad
Testing completed (on m-c, etc.): just landed on inbound
Risk to taking this patch (and alternatives if risky): low-risk, small style change
String or UUID changes made by this patch: n/a

Comment 11

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/905682481543

Comment 12

[bhavana bajaj [:bajaj]]

Comment on attachment 723705 [details] [diff] [review]
put back padding on both sides

Approving the low risk uplift of a minor alignment glitch in site settings dialog.

Comment 13

[:Margaret Leibovic]

https://hg.mozilla.org/releases/mozilla-aurora/rev/6f2799b58776

Comment 14

[Paul Feher]

Verified on Firefox for Android 21.0b7 and Aurora 22.0a2 (2013-05-07) using: Nexus 4 (4.2.2)