Closed
Bug 845151
Opened 12 years ago
Closed 11 years ago
new services icon and name
Categories
(Firefox Graveyard :: SocialAPI, defect)
Tracking
(firefox22+ verified, firefox23 verified)
VERIFIED
FIXED
Firefox 23
People
(Reporter: mixedpuppy, Assigned: mixedpuppy)
References
Details
(Keywords: uiwanted)
Attachments
(8 files, 2 obsolete files)
2.01 KB,
image/png
|
Details | |
5.48 KB,
image/png
|
Details | |
937 bytes,
image/png
|
Details | |
2.16 KB,
image/png
|
Details | |
19.18 KB,
patch
|
markh
:
review+
akeybl
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
5.48 KB,
image/png
|
Details | |
14.57 KB,
image/png
|
Details | |
60.26 KB,
patch
|
mixedpuppy
:
review+
|
Details | Diff | Splinter Review |
We need a new icon for the services section in about:addons, as well as a signoff on the name "Services".
Assignee | ||
Updated•12 years ago
|
Whiteboard: [needs-ux]
Comment 1•11 years ago
|
||
We discussed & will be keeping the name "Services" for now. I'm CC'ing Shorlander re an icon. To Shorlander - this will appear in the Firefox toolbar when no social provider is active in the spot where a social network's logo and possibly notification icons will go. While the name "Services" will appear in things like the add-ons manager, users will associate this spot more with the social networks they have installed. Do we have an icon we can use for this?
Updated•11 years ago
|
Assignee: nobody → shorlander
Assignee | ||
Comment 2•11 years ago
|
||
This really needs to happen for 22, even if uplifted after merge to aurora.
tracking-firefox22:
--- → ?
Comment 3•11 years ago
|
||
This will presumably have the same fate as bug 755126 in FF22, so no need to track until we reach consensus there.
Comment 4•11 years ago
|
||
Whoops, I meant bug 836452.
Comment 5•11 years ago
|
||
Attachment #733334 -
Flags: ui-review?(jboriss)
Comment 6•11 years ago
|
||
Comment 7•11 years ago
|
||
Comment 8•11 years ago
|
||
Assignee | ||
Comment 9•11 years ago
|
||
(In reply to Stephen Horlander from comment #5) > Created attachment 733334 [details] > Services Icon - 32 Do we need aero versions? All of the icons in about:addons have one. See https://mxr.mozilla.org/mozilla-central/source/toolkit/themes/windows/mozapps/extensions/ I'll prepare patches with what is here.
Comment 10•11 years ago
|
||
(In reply to Shane Caraveo (:mixedpuppy) from comment #9) > (In reply to Stephen Horlander from comment #5) > > Created attachment 733334 [details] > > Services Icon - 32 > > Do we need aero versions? All of the icons in about:addons have one. No, we are trying to unify most of our icons where possible. Thanks!
Assignee | ||
Comment 11•11 years ago
|
||
presuming that we'll get uireview+, here's the patch for about:addons. This one will need uplift to aurora as well.
Assignee: shorlander → mixedpuppy
Attachment #733522 -
Flags: review?(felipc)
Assignee | ||
Comment 12•11 years ago
|
||
(In reply to Stephen Horlander from comment #10) > (In reply to Shane Caraveo (:mixedpuppy) from comment #9) > > (In reply to Stephen Horlander from comment #5) > > > Created attachment 733334 [details] > > > Services Icon - 32 > > > > Do we need aero versions? All of the icons in about:addons have one. > > No, we are trying to unify most of our icons where possible. Thanks! Still need the 64x icon.
Assignee | ||
Comment 13•11 years ago
|
||
not ready since I need the real 64x icons, but at least reviewable up to that point.
Comment 14•11 years ago
|
||
Comment on attachment 733522 [details] [diff] [review] toolkit-about:addons icon update Review of attachment 733522 [details] [diff] [review]: ----------------------------------------------------------------- This looks fairly straightforward.
Attachment #733522 -
Flags: review?(felipc) → review+
Updated•11 years ago
|
Attachment #733662 -
Attachment is patch: true
Assignee | ||
Comment 15•11 years ago
|
||
(In reply to Mark Hammond (:markh) from comment #14) > Comment on attachment 733522 [details] [diff] [review] > toolkit-about:addons icon update > > Review of attachment 733522 [details] [diff] [review]: > ----------------------------------------------------------------- > > This looks fairly straightforward. toolkit patch pushed https://hg.mozilla.org/integration/mozilla-inbound/rev/3a9ac6eb47b5
Assignee | ||
Comment 16•11 years ago
|
||
Comment on attachment 733522 [details] [diff] [review] toolkit-about:addons icon update [Approval Request Comment] User impact if declined: extensions icon used in about:addons Testing completed (on m-c, etc.): manual on m-c Risk to taking this patch (and alternatives if risky): just css and images. alternative is to keep extensions icon String or IDL/UUID changes made by this patch: none
Attachment #733522 -
Flags: approval-mozilla-aurora?
Comment 17•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/3a9ac6eb47b5
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 23
Assignee | ||
Comment 18•11 years ago
|
||
reopening because the second patch still needs to land, is waiting on another icon from shorlander.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 19•11 years ago
|
||
Comment 20•11 years ago
|
||
Assignee | ||
Comment 21•11 years ago
|
||
path with new 64x icons
Attachment #733662 -
Attachment is obsolete: true
Attachment #734391 -
Flags: review?(mhammond)
Comment 22•11 years ago
|
||
Comment on attachment 734391 [details] [diff] [review] icon patch for install panel, etc Review of attachment 734391 [details] [diff] [review]: ----------------------------------------------------------------- The -32 versions of the images should be removed from both the patch and the jar.nm
Attachment #734391 -
Flags: review?(mhammond) → review+
Assignee | ||
Comment 23•11 years ago
|
||
remove unused 32x icons, carry forward r+=markh
Attachment #734391 -
Attachment is obsolete: true
Attachment #734444 -
Flags: review+
Assignee | ||
Comment 24•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/d8095f79eb0e
Comment 25•11 years ago
|
||
Comment on attachment 733522 [details] [diff] [review] toolkit-about:addons icon update UX asset addition without string impact, good for Aurora.
Attachment #733522 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 26•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/d8095f79eb0e
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
Comment 27•11 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/bf7fcfdeeb5f
status-firefox22:
--- → fixed
status-firefox23:
--- → fixed
Comment 28•11 years ago
|
||
Verified fixed on Nightly 23.0a1 : 20130410031044 Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:23.0) Gecko/20130410 Firefox/23.0 Verified fixed on Firefox Aurora 22.0a2: 20130410004014 Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:22.0) Gecko/20130410 Firefox/22.0
Updated•11 years ago
|
Comment 29•11 years ago
|
||
Marking verified fixed based on comment 28. Thanks for your help Tiziana. I also confirm this is fixed on Windows 7, Windows XP, and Ubuntu 12.04 32-bit.
Status: RESOLVED → VERIFIED
Updated•5 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•