845151 - new services icon and name

Status: VERIFIED FIXED

(Firefox Graveyard :: SocialAPI, defect)

Description

[Shane Caraveo (:mixedpuppy)]

We need a new icon for the services section in about:addons, as well as a signoff on the name "Services".

Comment 1

[Jennifer Morrow [:Boriss] (UX)]

We discussed & will be keeping the name "Services" for now.  I'm CC'ing Shorlander re an icon.  To Shorlander - this will appear in the Firefox toolbar when no social provider is active in the spot where a social network's logo and possibly notification icons will go.  While the name "Services" will appear in things like the add-ons manager, users will associate this spot more with the social networks they have installed.  Do we have an icon we can use for this?

Comment 2

[Shane Caraveo (:mixedpuppy)]

This really needs to happen for 22, even if uplifted after merge to aurora.

Comment 3

[Alex Keybl [:akeybl]]

This will presumably have the same fate as  bug 755126 in FF22, so no need to track until we reach consensus there.

Comment 4

[Alex Keybl [:akeybl]]

Whoops, I meant bug 836452.

Comment 5

[Stephen Horlander [:shorlander]]

Attachment: Services Icon - 32

Comment 6

[Stephen Horlander [:shorlander]]

Attachment: Services Icon - 32 @2x

Comment 7

[Stephen Horlander [:shorlander]]

Attachment: Services Icon - 16

Comment 8

[Stephen Horlander [:shorlander]]

Attachment: Services Icon - 16 @2x

Comment 9

[Shane Caraveo (:mixedpuppy)]

(In reply to Stephen Horlander from comment #5)
> Created attachment 733334 [details]
> Services Icon - 32

Do we need aero versions?  All of the icons in about:addons have one.

See https://mxr.mozilla.org/mozilla-central/source/toolkit/themes/windows/mozapps/extensions/

I'll prepare patches with what is here.

Comment 10

[Stephen Horlander [:shorlander]]

(In reply to Shane Caraveo (:mixedpuppy) from comment #9)
> (In reply to Stephen Horlander from comment #5)
> > Created attachment 733334 [details]
> > Services Icon - 32
> 
> Do we need aero versions?  All of the icons in about:addons have one.

No, we are trying to unify most of our icons where possible. Thanks!

Comment 11

[Shane Caraveo (:mixedpuppy)]

Attachment: toolkit-about:addons icon update

presuming that we'll get uireview+, here's the patch for about:addons.  This one will need uplift to aurora as well.

Comment 12

[Shane Caraveo (:mixedpuppy)]

(In reply to Stephen Horlander from comment #10)
> (In reply to Shane Caraveo (:mixedpuppy) from comment #9)
> > (In reply to Stephen Horlander from comment #5)
> > > Created attachment 733334 [details]
> > > Services Icon - 32
> > 
> > Do we need aero versions?  All of the icons in about:addons have one.
> 
> No, we are trying to unify most of our icons where possible. Thanks!

Still need the 64x icon.

Comment 13

[Shane Caraveo (:mixedpuppy)]

Attachment: icon patch for install panel, etc

not ready since I need the real 64x icons, but at least reviewable up to that point.

Comment 14

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 733522 [details] [diff] [review]
toolkit-about:addons icon update

Review of attachment 733522 [details] [diff] [review]:
-----------------------------------------------------------------

This looks fairly straightforward.

Comment 15

[Shane Caraveo (:mixedpuppy)]

(In reply to Mark Hammond (:markh) from comment #14)
> Comment on attachment 733522 [details] [diff] [review]
> toolkit-about:addons icon update
> 
> Review of attachment 733522 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> This looks fairly straightforward.

toolkit patch pushed

https://hg.mozilla.org/integration/mozilla-inbound/rev/3a9ac6eb47b5

Comment 16

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 733522 [details] [diff] [review]
toolkit-about:addons icon update

[Approval Request Comment]
User impact if declined:  extensions icon used in about:addons
Testing completed (on m-c, etc.): manual on m-c
Risk to taking this patch (and alternatives if risky): just css and images.  alternative is to keep extensions icon
String or IDL/UUID changes made by this patch: none

Comment 17

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/3a9ac6eb47b5

Comment 18

[Shane Caraveo (:mixedpuppy)]

reopening because the second patch still needs to land, is waiting on another icon from shorlander.

Comment 19

[Stephen Horlander [:shorlander]]

Attachment: Services Icon - 64

Comment 20

[Stephen Horlander [:shorlander]]

Attachment: Services Icon - 64 @2x

Comment 21

[Shane Caraveo (:mixedpuppy)]

Attachment: icon patch for install panel, etc

path with new 64x icons

Comment 22

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 734391 [details] [diff] [review]
icon patch for install panel, etc

Review of attachment 734391 [details] [diff] [review]:
-----------------------------------------------------------------

The -32 versions of the images should be removed from both the patch and the jar.nm

Comment 23

[Shane Caraveo (:mixedpuppy)]

Attachment: icon patch for install panel, etc

remove unused 32x icons, carry forward r+=markh

Comment 24

[Shane Caraveo (:mixedpuppy)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d8095f79eb0e

Comment 25

[Alex Keybl [:akeybl]]

Comment on attachment 733522 [details] [diff] [review]
toolkit-about:addons icon update

UX asset addition without string impact, good for Aurora.

Comment 26

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d8095f79eb0e

Comment 27

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/bf7fcfdeeb5f

Comment 28

[Tiziana Sellitto [:tiziana]]

Verified fixed on Nightly 23.0a1 : 20130410031044 Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:23.0) Gecko/20130410 Firefox/23.0

Verified fixed on Firefox Aurora 22.0a2: 20130410004014 Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:22.0) Gecko/20130410 Firefox/22.0

Comment 29

[u279076]

Marking verified fixed based on comment 28. Thanks for your help Tiziana. I also confirm this is fixed on Windows 7, Windows XP, and Ubuntu 12.04 32-bit.