888867 - chat nub not sized correctly on a Mac retina screen

Status: VERIFIED FIXED

(Firefox Graveyard :: SocialAPI, defect)

Description

[Florian Quèze [:florian]]

Attachment: Screenshot

The chat nub icon is displayed with a height of 16px but a width of 32px on Mac retina screens. See attached screenshot.

Comment 1

[Florian Quèze [:florian]]

Attachment: Patch

Simple patch. Given that the file [e-mail] exists only on Mac, I wonder why the rule making use of it is in browser/themes/shared/social/chat.inc.css rather than in browser/themes/osx/browser.css, but I think it makes sense to have the rule setting the image width for the retina case close to the rule setting the retina icon.

Comment 2

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 769647 [details] [diff] [review]
Patch

move the added css outside of the @media section (I tested on osx, is fine). r+ with that

Comment 3

[Florian Quèze [:florian]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1947e3caa654

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/1947e3caa654

Comment 5

[Florian Quèze [:florian]]

Comment on attachment 769647 [details] [diff] [review]
Patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 845151 (http://hg.mozilla.org/mozilla-central/rev/d8095f79eb0e)
User impact if declined: The chat nub is ugly on Mac retina screens (screenshot in attachment 769646 [details]).
Testing completed (on m-c, etc.): Landed on m-c a few days ago.
Risk to taking this patch (and alternatives if risky): low.
String or IDL/UUID changes made by this patch: none.

Note: some parts of bug 845151 landed on mozilla-aurora for Firefox 22, but the changes to chat.inc.css only landed in mozilla-central for Firefox 23+.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/bbbcec4b8860
https://hg.mozilla.org/releases/mozilla-beta/rev/7d5c422bc2c5

Comment 7

[u279076]

Matt, can you please verify if this is fixed?

Comment 8

[u279076]

Adding steps to reproduce since it's really not clear how to get this UI element to appear.

1. Load http://mixedpuppy.github.io/socialapi-demo/
2. Activate the demo provider
3. Click "sign in"
4. Click the "chat panel" button
5. Repeat step 4 until the window overflows with chats
> The "chat nub" icon should appear at the bottom-left of the window

Expected: The icon should not appear stretched on a Retina Mac

Florian, in accordance with our bug writing guidelines[1], please include steps to reproduce in future bugs you report. Thanks.

1. https://developer.mozilla.org/en-US/docs/Mozilla/QA/Bug_writing_guidelines

Comment 9

[Matt Wobensmith [:mwobensmith][:matt:]]

Confirmed problem in m-c 2013-07-01.
Confirmed fixed in m-c 2013-07-10.
Confirmed fixed in Aurora FF24 2013-07-10.
Confirmed fixed in Beta FF23b4 2013-07-09.

Comment 10

[u279076]

Much appreciated Matt, thank you.